Repository navigation
[Search v2.2] Update Trips empty state on Search to avoid double empty state #47937
Description
Right now when you access the Trips empty state via search, you press a big green button that leads to an RHP view with virtually the same information.
CleanShot.2024-08-23.at.07.26.56.mp4
Let's just combine everything into the Trips empty state view so that it looks like this:
Rather than adding two buttons into the empty state like the RHP does, I'm suggesting we just change the "Book a demo" button to be a link in the text above.
cc @filip-solecki in case this might be interesting to you.
cc @dylanexpensify & @luacmartins to file this one under #44038
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01042577ade1f53d6d
- Upwork Job ID: 1827040366251521288
- Last Price Increase: 2024-08-23
- Automatic offers:
- DylanDylann | Reviewer | 103693340
Issue Owner
Current Issue Owner: @lschurrMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
[-]Update Trips empty state on Search to avoid double empty state[/-][+][$250] Update Trips empty state on Search to avoid double empty state[/+]melvin-bot commentedon Aug 23, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01042577ade1f53d6d
melvin-bot commentedon Aug 23, 2024
Triggered auto assignment to @lschurr (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.[-][$250] Update Trips empty state on Search to avoid double empty state[/-][+][Search v2.2] Update Trips empty state on Search to avoid double empty state[/+]melvin-bot commentedon Aug 23, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)38 remaining items
melvin-bot commentedon Sep 27, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Oct 4, 2024
This issue has not been updated in over 15 days. @luacmartins, @lschurr, @DylanDylann, @daledah eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
daledah commentedon Oct 7, 2024
@lschurr This is ready for payment. Please help to sort it out
lschurr commentedon Oct 7, 2024
Thanks @daledah - Could you point me to the PR that fixed the bug?
daledah commentedon Oct 7, 2024
These PRs:
lschurr commentedon Oct 7, 2024
Great, ok! So was there a regression or should this be paid in full? @luacmartins @DylanDylann @daledah
daledah commentedon Oct 7, 2024
We have a regression
lschurr commentedon Oct 9, 2024
Payment summary:
daledah commentedon Oct 9, 2024
@lschurr Offer accepted thanks
lschurr commentedon Oct 9, 2024
All set!