Repository navigation
[$250] Expense report-Submit & approve button not disappear until page refreshed #48463
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.28.0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validation PR: #48362
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition: log into OD as an admin, create a control policy, enable workspace chats, select "Advanced Approvals", invite 3 members (non-admin): 2 approvers and 1 submitter, set the approval flow as submitter submits to approver 1
- Log into ND as submitter
- Navigate to the workspace chat
- Submit one manual expense
- Open the report and click on the "Submit" button
- As admin, change the the submitter's submitsTo to approver 2 in OD
- Log into ND as approver 1
- Opened the submitted report
- Click on the "Approve" button
Expected Result:
The 'Submit" button disappears immediately for the submitter (step 4) and the "Approve" button disappears for the approver (step 8)
Actual Result:
The "Submit" and "Approve" button do not disappear until the page is refreshed or it is clicked on the second time (the "Approve" button)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6591339_1725333837619.Recording__737.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01efec68070b933fc3
- Upwork Job ID: 1831071506567798044
- Last Price Increase: 2024-10-29
- Automatic offers:
- nkdengineer | Contributor | 104649054
Issue Owner
Current Issue Owner:Metadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Sep 3, 2024
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 3, 2024
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Sep 3, 2024
We think this issue might be related to the #wave-control
izarutskaya commentedon Sep 3, 2024
Production
Recording.739.mp4
Recording.2788.mp4
srikarparsi commentedon Sep 3, 2024
Looked into this and I think this might be a problem with manually submitting reports. I verified this by:
(First part of the video is from staging and the second is from production)
manualSubmitBug.mov
srikarparsi commentedon Sep 3, 2024
I don't think this is a backend bug because the SubmitReport response is the same on staging and production.
134 remaining items
Beamanator commentedon Nov 29, 2024
I know I USED TO think that way 😅 then I did a decent amount of testing and found that not to be the case, I thinkkkkk I explained in slack somewhere... it's all related to this "conclusion" i posted
Beamanator commentedon Nov 29, 2024
So the point is: If a report already has a manager & they get removed from the approval chain, we stop caring about the current manager's approval chain, and we purely care about "who is next to approve in the submitter's current / new approval chain"
Beamanator commentedon Nov 29, 2024
In ReportUtils::buildApprovalChain (this is the OldDot approval-chain building... NewDot does it all in Auth) you can see that the current report manager is never inserted into the chain, we ONLY insert:
$ruleApprovers(category / tag approvers)submitsTo->forwardsTo-> ...melvin-bot commentedon Dec 2, 2024
@slafortune, @NikkiWines, @eh2077, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
eh2077 commentedon Dec 2, 2024
Not overdue, discussion is ongoing
trjExpensify commentedon Dec 2, 2024
Great stuff! So I agree we can close this issue then. :)
slafortune commentedon Dec 3, 2024
Thanks all! Those details are super helpful
nkdengineer commentedon Dec 16, 2024
@slafortune I believe compensation is due for this issue since it was assigned and I spent a lot of effort following this issue and worked on the PR here before we decided to close this as expected.
This is a similar case, seems the rule based on that thread is full compensation in such case.
nkdengineer commentedon Dec 24, 2024
@slafortune friendly bump here
nkdengineer commentedon Feb 4, 2025
@slafortune Please help to check my comment when you have a chance.
slafortune commentedon May 8, 2025
Sorry I've not done this! https://www.upwork.com/nx/wm/offer/107230785