Repository navigation
[HOLD FOR PAYMENT 9/26]Expense - Nothing happens when hitting Enter on amount page #49368
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat.
- Click + > Submit expense > Manual.
- Enter amount.
- Hit Enter.
Expected Result:
Enter key will proceed to next step.
Actual Result:
Nothing happens when hitting Enter on amount page.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Sep 18, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Sep 18, 2024
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Sep 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Sep 18, 2024
We think that this bug might be related to #wave-collect - Release 1
luacmartins commentedon Sep 18, 2024
Pretty sure it came from this PR #49023 @suneox @alitoshmatov
nkdengineer commentedon Sep 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Task title is overlapped by task arrow
What is the root cause of that problem?
The input has the role is
CONST.ROLE.PRESENTATIONand we don't exclude it here. It happens after this PRApp/src/components/Button/index.tsx
Line 152 in 448ca57
What changes do you think we should make in order to solve the problem?
We should return
shouldDisableEnterShortcutasfalseif theactiveElementRoleisCONST.ROLE.PRESENTATIONas we did in the past like the diff in this PRApp/src/components/Button/index.tsx
Line 152 in 448ca57
OPTIONAL: We can exclude other roles if this role is not a pressable element.
What alternative solutions did you explore? (Optional)
NA
nkdengineer commentedon Sep 18, 2024
@luacmartins This comes from this #49316.
7 remaining items
nkdengineer commentedon Sep 18, 2024
@luacmartins The PR is ready.
melvin-bot commentedon Sep 18, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon Sep 19, 2024
this was fixed but we forgot to remove the label I believe
CortneyOfstad commentedon Sep 23, 2024
PR was deployed to production 4 days ago — updating the title!
[-]Expense - Nothing happens when hitting Enter on amount page[/-][+][HOLD FOR PAYMENT 9/26]Expense - Nothing happens when hitting Enter on amount page[/+]CortneyOfstad commentedon Sep 27, 2024
@nkdengineer — offer sent to you here in Upwork — please let me know once you accept and I'll get that paid ASAP. Thanks!
nkdengineer commentedon Sep 30, 2024
@CortneyOfstad I accepted thanks
CortneyOfstad commentedon Oct 1, 2024
Payment Summary
@nkdengineer — paid $250 via Upwork