Skip to content

[$250] Expense, task, room - Unable to create a new line in description field with SHIFT+Enter #49374

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Click + > Submit expense > Manual.
  4. Enter amount > Next.
  5. Click Description.
  6. Press SHIFT+ENTER (enter key for mweb).

Expected Result:

A new line will be created with SHIFT+ENTER.

Actual Result:

A new line is not created with SHIFT+ENTER. The description is saved instead.

This issue happens in IOU, task and room description.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6607157_1726619223526.20240918_082254.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836355229392782754
  • Upwork Job ID: 1836355229392782754
  • Last Price Increase: 2024-09-18
  • Automatic offers:
    • DylanDylann | Reviewer | 104086887
    • nkdengineer | Contributor | 104086888
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 18, 2024
  2. melvin-bot commented on Sep 18, 2024

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Sep 18, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. IuliiaHerets commented on Sep 18, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  5. github-actions commented on Sep 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. etCoderDysto commented on Sep 18, 2024

    @etCoderDysto
    Contributor

    This might have the same RCA with #49368

  7. 36 remaining items

  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 20, 2024
  9. melvin-bot commented on Sep 20, 2024

    @melvin-bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  10. miljakljajic commented on Sep 20, 2024

    @miljakljajic
    Contributor

    @slafortune thank you for taking this one over as I start my parental leave.

    @luacmartins @cead22 will we be going with @nkdengineer 's proposal? Stevie can get them assigned and take this one forward

  11. DylanDylann commented on Sep 23, 2024

    @DylanDylann
    Contributor

    @luacmartins @cead22 Could you please check my comment ?

  12. cead22 commented on Sep 23, 2024

    @cead22
    Contributor

    Both work from my perspective, so I'd lean on what you @DylanDylann and @luacmartins think is best

  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 23, 2024
  14. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  15. melvin-bot commented on Sep 23, 2024

    @melvin-bot

    📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  16. DylanDylann commented on Oct 8, 2024

    @DylanDylann
    Contributor

    @slafortune This is ready for payment. The PR is deployed to production on 1/10

  17. slafortune commented on Oct 9, 2024

    @slafortune
    Contributor

    @DylanDylann role - contributor - Paid $250 via upworks
    @nkdengineer Role - C+ - Paid $250 via upworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions