[HOLD for payment 2024-10-14] [$250] Web - Pay - Not here page opens when Gmail user Pay with Expensify

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gocemate+a2207@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

Open 1:1 chat with other user
Go to Pay
Select USD -$ currency>Enter amount> Next> Pay with Expensify

Expected Result:

Add bank account page should open

Actual Result:

Not here page opens when Gmail user Pay with Expensify

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6609354_1726782468479.Recording__3967.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837168425885571920
Upwork Job ID: 1837168425885571920
Last Price Increase: 2024-09-20
Automatic offers:

ikevin127 | Reviewer | 104140946
cretadn22 | Contributor | 104140948

Issue Owner

Current Issue Owner: @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@isabelastisser

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-09-20 11:10:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay - Not here page opens when gmail user Pay with Expensify

What is the root cause of that problem?

When user is not validated and navigates to bankAccountRoute (settings/wallet/add-bank-account) hmm it not page is displayed

App/src/components/MoneyRequestConfirmationList.tsx

Line 849 in d009d8e

addBankAccountRoute={bankAccountRoute}

App/src/pages/AddPersonalBankAccountPage.tsx

Line 70 in d009d8e

What changes do you think we should make in order to solve the problem?

We should check if the user is validated first before we display pay with expensify button here. And hide the button when the user is not validated

get currentUserPersoanlDetails using

const currentUserPersonalDetails = useCurrentUserPersonalDetails();

Display paywith Expensify button when the user is validated

const canUseWallet = !isExpenseReport && !isInvoiceReport && currency === CONST.CURRENCY.USD && currentUserPersonalDetails.validated;

App/src/components/SettlementButton/index.tsx

Line 98 in d009d8e

    
           const canUseWallet = !isExpenseReport && !isInvoiceReport && currency === CONST.CURRENCY.USD;

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021837168425885571920

@ikevin127

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@davidcardoza

@davidcardoza, I can't add this issue to the bill pay project. Can you please help? Thanks!

Not able to reproduce!

@ikevin127

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@ikevin127

@ikevin127 @cretadn22, can you please provide an update? Did the PR cause a regression? What's next here?

@isabelastisser

@isabelastisser Yes, we had the following regression:

[HOLD for payment 2024-11-21] [$250] Pay someone - User is signed out after verifying account during pay someone flow #50284

which was caused by lack of testing on both PR reviewer and author sides. The issue mentioned above is open for proposals, unless the author wants to fix the issue given that we're still within the regression period.

Note: The issue was that we relied on the other PRs implementation of the new route without actually testing if the implementation works, ignoring this issue's Expected result which states Add bank account page should open as we stopped the testing at "seeing the magic code input showing up in RHP".

@ikevin127

So unless the author wants to fix this, we're open for proposals. Peace out ✌️

@ikevin127 Are you suggesting that I need to create a PR to address this new issue? I believe it's outside the scope of this problem.

@cretadn22

@cretadn22 No. Truth is that because neither of us actually tested what happens once the validation code is inputted - we're both going to get the regression penalty here.

It's also true that the issue of being logged out was not caused directly by logic you introduced in the PR, but rather an edge case / side effect of using the logic of the other PR in our specific case.

Given this, as I mentioned in the regression issue -> it's open for proposals.

@ikevin127

[@ikevin127] The PR that introduced the bug has been identified. Link to the PR: Consolidate options on settlement "Pay" button #37174.
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37174/files#r1797481938.
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Login to new account (unverified).
Start a chat with an existing user > [+] > Pay [userName].
Select USD > Pay with Expensify.
Verify that the 'verify account page' shows up in RHP prompting user to enter the magic code.

Do we agree 👍 or 👎.

@isabelastisser As for payment, there was one regression:

[HOLD for payment 2024-11-21] [$250] Pay someone - User is signed out after verifying account during pay someone flow #50284

which wasn't caused directly by the code implemented by this issue's fix but as a side effect of our previous logic not being adjusted to handle updating the authToken while logged in - more details in issue #50284 (comment).

Given this, both me (reviewer) and contributor should get a -50% penalty on the issue's bounty.

I was OOO yesterday. I will review this today!

@ikevin127

@ikevin127, thanks for the detailed explanation above! I've processed the payments in Upwork now.

All set!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] [$250] Web - Pay - Not here page opens when Gmail user Pay with Expensify #49523

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

37 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-14] [$250] Web - Pay - Not here page opens when Gmail user Pay with Expensify #49523

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 20, 2024

IuliiaHerets commented on Sep 20, 2024

IuliiaHerets commented on Sep 20, 2024

etCoderDysto commented on Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

isabelastisser commented on Sep 20, 2024

1subodhpathak commented on Sep 20, 2024

37 remaining items

melvin-bot commented on Oct 7, 2024

isabelastisser commented on Oct 8, 2024

ikevin127 commented on Oct 8, 2024

cretadn22 commented on Oct 9, 2024

ikevin127 commented on Oct 9, 2024

ikevin127 commented on Oct 11, 2024

Regression Test Proposal

isabelastisser commented on Oct 15, 2024

isabelastisser commented on Oct 15, 2024

isabelastisser commented on Oct 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions