Repository navigation
[HOLD for payment 2024-11-21] [$250] Pay someone - User is signed out after verifying account during pay someone flow #50284
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #50169
Email or phone of affected tester (no customers): yonghongkok2+sddwe23@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Log in with a new Gmail account.
- Complete the onboarding.
- Open DM with any user.
- Click + > Pay someone.
- Select currency in USD, enter amount and click Next.
- Click Pay with Expensify.
- Enter the correct magic code.
Expected Result:
User will not be signed out after verifying account during pay someone flow.
Actual Result:
User is signed out after verifying account during pay someone flow.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6624999_1728086378423.20241005_075652.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021843360929752935358
- Upwork Job ID: 1843360929752935358
- Last Price Increase: 2024-10-14
Issue Owner
Current Issue Owner: @zanyrenneyMetadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Oct 5, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 5, 2024
Triggered auto assignment to @arosiclair (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
arosiclair commentedon Oct 7, 2024
I reproduced on staging v9.0.45-2 and not on prod v9.0.44-12 (the original bug from #49523 is still present).
arosiclair commentedon Oct 7, 2024
This is actually not reproducible in dev with the latest changes on
main.ikevin127 commentedon Oct 7, 2024
We discussed this issue here in #48041 (comment) since that was the issue which introduced the new validation route logic.
Looks like the cause of the logout is/was that when we input the magic code, one of the API endpoints is called with the old / outdated
authTokenfrom when the account was not validated.The issue seems unrelated to the PR I reviewed and more related to the PR that introduced the new validation route logic.
If we were to follow-up with a fix and pinpoint the offending PR, that would be #49230 even if the logout issue did not pop-up while testing issue #48041.
The fix for this should be something along the lines of making sure that once the magic code was provided in the new route, we make sure to clear the old
authTokenbefore making any API calls post-validation.This can be done either on FE or BE.
Please, correct me if any of my above statements are wrong!
I'll have to double check, but if the issue is indeed not reproducible anymore, can we assume that this was fixed from the BE side ? 🤔
arosiclair commentedon Oct 7, 2024
I can't verify locally, but reverting #50169 would probably restore the behavior on prod (the not found page). However, I'm not sure that's really "better" than what we have now (forced logout but working after logging back in). I think the best path forward is to not block on this and use this issue to investigate and fix the problem.
53 remaining items
[-][$250] Pay someone - User is signed out after verifying account during pay someone flow[/-][+][HOLD for payment 2024-11-21] [$250] Pay someone - User is signed out after verifying account during pay someone flow[/+]melvin-bot commentedon Nov 14, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 14, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 14, 2024
@sobitneupane @zanyrenney @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Nov 21, 2024
Payment Summary
Upwork Job
BugZero Checklist (@zanyrenney)
zanyrenney commentedon Nov 21, 2024
BE issue.
zanyrenney commentedon Nov 21, 2024
Payment Summary
Upwork Job - closed.
garrettmknight commentedon Dec 12, 2024
$250 approved for @sobitneupane