You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-10] Android – Sign in – Able to dismiss the Onboarding modal using back button #49990
Version Number: 9.0.42-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5027336 Email or phone of affected tester (no customers):ponikarchuks+1311024@gmail.com Issue reported by: Applause Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Android – Sign in – Able to dismiss the Onboarding modal using back button[/-][+][HOLD for payment 2024-10-10] Android – Sign in – Able to dismiss the Onboarding modal using back button[/+]on Oct 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@johnmlee101] The PR that introduced the bug has been identified. Link to the PR:
[@johnmlee101] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@johnmlee101] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@johnmlee101] Determine if we should create a regression test for this bug.
[@johnmlee101] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 1, 2024
Triggered auto assignment to @johnmlee101 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 1, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Oct 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
blazejkustra commentedon Oct 1, 2024
I think it is connected to #49586, do you know how we prevented this in the past? @allgandalf
johnmlee101 commentedon Oct 1, 2024
Bump @allgandalf !
15 remaining items
mountiny commentedon Oct 2, 2024
No payments required here as the authors handled the fix, closing
[-]Android – Sign in – Able to dismiss the Onboarding modal using back button[/-][+][HOLD for payment 2024-10-10] Android – Sign in – Able to dismiss the Onboarding modal using back button[/+]melvin-bot commentedon Oct 3, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 3, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-10. 🎊
melvin-bot commentedon Oct 3, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 21, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
alexpensify commentedon Oct 22, 2024
@johnmlee101 - is this notice accurate or a false alarm?
johnmlee101 commentedon Nov 12, 2024
Looks like a false alarm, I don't see the linked issue at all