Skip to content

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page #50086

New issue
New issue
Closed
Closed
[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page#50086
Assignees
pecanoromallenexpensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Unable to validate in Prod because of Bank Setup
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5032805
Email or phone of affected tester (no customers): applausetester+vd_web100224.2@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Pre-requisite: with Expensifail account, user must have created a workspace and have enabled Workflows.

  1. Go to Settings > Workspaces > Workspace > Workflows.
  2. Click on "Connect bank account".
  3. Select "Connect online with Plaid", use Regions bank and testing credentials.
  4. Go trough the add bank account flow until you reach the Company info section.
  5. Keep going trough the flow, when you reach the company website page, leave it as it is and click "Next".
  6. Reach the confirmation page.

Expected Result:

Company website filed should be filled with default value on the confirmation page.

Actual Result:

Company website filed appears empty on the confirmation page.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6622243_1727882739579.bandicam_2024-10-02_11-15-32-633.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 2, 2024
  2. melvin-bot
    assigned
    pecanoro
    on Oct 2, 2024

  3. melvin-bot commented on Oct 2, 2024

    @melvin-bot
    melvin-botBot
    on Oct 2, 2024 – with Melvin Bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    mallenexpensify
    on Oct 2, 2024

  5. melvin-bot commented on Oct 2, 2024

    @melvin-bot
    melvin-botBot
    on Oct 2, 2024 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 2, 2024

  7. github-actions commented on Oct 2, 2024

    @github-actions
    github-actionsBot
    on Oct 2, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. gijoe0295 commented on Oct 2, 2024

    @gijoe0295
    gijoe0295
    on Oct 2, 2024
    Contributor

    Regression from #49957.

    Remove the useEffect here got the default website value not being saved because the FormProvider wouldn't save default input value.

  9. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    jasperhuangg
    on Oct 2, 2024
    Contributor

    Thanks @gijoe0295, gonna get a revert up for that PR since it sounds like the proposal on that one is flawed.

  10. pecanoro commented on Oct 2, 2024

    @pecanoro
    pecanoro
    on Oct 2, 2024
    Contributor

    I am reverting already 😄

  11. 13 remaining items

  12. melvin-bot commented on Oct 3, 2024

    @melvin-bot
    melvin-botBot
    on Oct 3, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 3, 2024

    @melvin-bot
    melvin-botBot
    on Oct 3, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-10. 🎊

  14. melvin-bot commented on Oct 3, 2024

    @melvin-bot
    melvin-botBot
    on Oct 3, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
    • [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@pecanoro] Determine if we should create a regression test for this bug.
    • [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  15. mallenexpensify commented on Oct 3, 2024

    @mallenexpensify
    mallenexpensify
    on Oct 3, 2024
    Contributor

    Thanks, closing.
    Posted on the other review and linked to this issue.

  16. mallenexpensify
    reopened this on Oct 3, 2024
  17. jasperhuangg
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 3, 2024

  18. allgandalf commented on Oct 4, 2024

    @allgandalf
    allgandalf
    on Oct 4, 2024
    Contributor

    @mallenexpensify i guess you reopened this issue instead of closing 😅

  19. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Oct 4, 2024
  20. melvin-bot
    changed the title [-][HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page[/-] [+][HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Bank account - Company website field appears empty on company info confirmation page[/+] on Oct 4, 2024

  21. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-11. 🎊

  22. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
    • [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@pecanoro] Determine if we should create a regression test for this bug.
    • [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  23. allgandalf commented on Oct 7, 2024

    @allgandalf
    allgandalf
    on Oct 7, 2024
    Contributor

    bump @mallenexpensify to close this one 🙇

  24. mallenexpensify commented on Oct 7, 2024

    @mallenexpensify
    mallenexpensify
    on Oct 7, 2024
    Contributor

    Thanks @allgandalf , closing, for real....

  25. mallenexpensify
    closed this as completedon Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions