Skip to content

[HOLD for payment 2024-11-22] [$250] Search - Not here page appears when selecting a non-existing user and then going online #51651

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.55-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5140184
Email or phone of affected tester (no customers): applausetester+bm176@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Go offline
  3. Click on the search icon at the top right
  4. Search for a non-existing user
  5. Click on the search result
  6. Go online

Expected Result:

Not here page should not appear, and the chat with the non-existing user should remain visible

Actual Result:

Not here page appears when going online, which contradicts the behavior when performing these steps while online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6649175_1730198793234.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021851703015510861438
  • Upwork Job ID: 1851703015510861438
  • Last Price Increase: 2024-10-30
  • Automatic offers:
    • dukenv0307 | Contributor | 104740405
    • NJ-2020 | Contributor | 104800732
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 29, 2024
  2. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Oct 29, 2024

    @lanitochka17
    Author

    @isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Oct 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-control

  5. NJ-2020 commented on Oct 29, 2024

    @NJ-2020
    Contributor

    Same RCA as #51473

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 30, 2024
  7. changed the title [-]Search - Not here page appears when selecting a non-existing user and then going online[/-] [+][$250] Search - Not here page appears when selecting a non-existing user and then going online[/+] on Oct 30, 2024
  8. melvin-bot commented on Oct 30, 2024

    @melvin-bot
  9. melvin-bot commented on Oct 30, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  10. isabelastisser commented on Oct 30, 2024

    @isabelastisser
    Contributor

    Heads up, I will be OOO from Oct 31 until Nov 4, so please re-apply the Bug label and assign a new member if needed. Thanks!

  11. 28 remaining items

  12. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-22. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Nov 15, 2024

    @melvin-bot

    @dukenv0307 @isabelastisser @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. isabelastisser commented on Nov 22, 2024

    @isabelastisser
    Contributor

    Payment summary:

    Payment made in Upwork to @NJ-2020 - contributor $250

    @dukenv0307, payment pending in NewDot - $250 C+.

  16. dukenv0307 commented on Nov 25, 2024

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/51093/files#r1855741040

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open Expensify app
    2. Go offline
    3. Click on the search icon at the top right
    4. Search for a non-existing user
    5. Click on the search result
    6. Go online
    7. Make sure the not here page should not appear

    Do we agree 👍 or 👎

  17. dukenv0307 commented on Nov 25, 2024

    @dukenv0307
    Contributor

    @dukenv0307, please accept the offer in Upwork and I will process the payment. Thanks!

    Hey @isabelastisser I'll request payment via NewDot.

  18. isabelastisser commented on Nov 25, 2024

    @isabelastisser
    Contributor
  19. isabelastisser commented on Nov 25, 2024

    @isabelastisser
    Contributor

    All set!

  20. JmillsExpensify commented on Dec 5, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @dukenv0307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions