Skip to content

[HOLD App#52252] [$250] [Workspace Feeds] Company Cards - Unable to remove card feed that's under review #51858

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.56-2
Reproducible in staging?: Y
Reproducible in production?: No, unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #51569

Action Performed:

  1. Open the app
  2. Log in with a new expensifail account
  3. Create a workspace
  4. Navigate to Workspace settings - More features
  5. Enable "Company cards"
  6. Navigate to Workspace settings - Company cards
  7. Navigate to Add company cards - American Express - American Express Corporate Cards - Next
  8. Input any name and tap on the "Next" button
  9. Tap on the "Submit" button
  10. Tap on the "Settings" button
  11. Tap on the "Remove card feed" button
  12. Tap on the "Delete" button

Expected Result:

I should be able to delete the feed

Actual Result:

Unable to remove card feed that's under review. "Import company cards" page can be seen briefly but the "review" page loads again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651880_1730441266538.HVLE9707.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021852426699884185074
  • Upwork Job ID: 1852426699884185074
  • Last Price Increase: 2024-11-01
  • Automatic offers:
    • allgandalf | Contributor | 104730679
Issue OwnerCurrent Issue Owner: @mountiny

Activity

  1. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Nov 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Nov 1, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 2

  5. marcochavezf commented on Nov 1, 2024

    @marcochavezf
    Contributor

    This is happening in production, so not a blocker

    Screen.Recording.2024-11-01.at.1.03.32.p.m.mov
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 1, 2024
  7. changed the title [-]Company Cards - Unable to remove card feed that's under review[/-] [+][$250] Company Cards - Unable to remove card feed that's under review[/+] on Nov 1, 2024
  8. 28 remaining items

  9. allgandalf commented on Nov 11, 2024

    @allgandalf
    Contributor

    @mountiny should we hold this for #52252 (BE) one ?

  10. mountiny commented on Nov 11, 2024

    @mountiny
    Contributor

    Yep, working on that one today

  11. changed the title [-][$250] [Workspace Feeds] Company Cards - Unable to remove card feed that's under review[/-] [+][HOLD App#52252] [$250] [Workspace Feeds] Company Cards - Unable to remove card feed that's under review[/+] on Nov 11, 2024
  12. mountiny commented on Nov 12, 2024

    @mountiny
    Contributor
  13. mountiny commented on Nov 14, 2024

    @mountiny
    Contributor

    There is a follow up merged so we can test again shortly

  14. melvin-bot commented on Nov 18, 2024

    @melvin-bot

    @lschurr, @mountiny, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. mountiny commented on Nov 18, 2024

    @mountiny
    Contributor

    I believe @joekaufmanexpensify tested removing the pending card so this worked well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions