You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected #51984
Version Number: 9.0.57-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):applausetester+kh22100010ad@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to Search.
Tap on the filter icon.
Add any filter.
Tap Save search.
Tap on the dropdown.
Expected Result:
Only the currently opened saved search will be highlighted.
Actual Result:
"Saved" header is also highlighted when saved search is selected.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]mWeb - "Saved" header is also highlighted when saved search is selected[/-][+][HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected[/+]on Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Nov 4, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 4, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 4, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Nodebrute commentedon Nov 4, 2024
This is likely coming from this PR: #51937.
luacmartins commentedon Nov 4, 2024
That PR seems to be the culprit, yea. Looking into a fix
luacmartins commentedon Nov 4, 2024
I have a PR up. Since this is a small issue, I'll remove the blocker label so we can properly test it to make sure it wont cause other regressions.
8 remaining items
[-]mWeb - "Saved" header is also highlighted when saved search is selected[/-][+][HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected[/+]melvin-bot commentedon Nov 11, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
melvin-bot commentedon Nov 11, 2024
@luacmartins @adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
greg-schroeder commentedon Nov 18, 2024
FYI @adelekennedy this was a regression from #50779, so I don't believe payment is due for the reviewer role in this case
melvin-bot commentedon Nov 18, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
luacmartins commentedon Nov 18, 2024
I agree. Closing.