Skip to content

[HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected #51984

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh22100010ad@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Tap on the filter icon.
  4. Add any filter.
  5. Tap Save search.
  6. Tap on the dropdown.

Expected Result:

Only the currently opened saved search will be highlighted.

Actual Result:

"Saved" header is also highlighted when saved search is selected.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6654586_1730744593941.1730744264454_Screen_Recording_20241105_021736_Chrome.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 4, 2024
  2. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Nodebrute commented on Nov 4, 2024

    @Nodebrute
    Contributor

    This is likely coming from this PR: #51937.

  7. luacmartins commented on Nov 4, 2024

    @luacmartins
    Contributor

    That PR seems to be the culprit, yea. Looking into a fix

  8. luacmartins commented on Nov 4, 2024

    @luacmartins
    Contributor

    I have a PR up. Since this is a small issue, I'll remove the blocker label so we can properly test it to make sure it wont cause other regressions.

  9. 8 remaining items

  10. changed the title [-]mWeb - "Saved" header is also highlighted when saved search is selected[/-] [+][HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected[/+] on Nov 11, 2024
  11. melvin-bot commented on Nov 11, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Nov 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-18. 🎊

  13. melvin-bot commented on Nov 11, 2024

    @melvin-bot

    @luacmartins @adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. greg-schroeder commented on Nov 18, 2024

    @greg-schroeder
    Contributor

    FYI @adelekennedy this was a regression from #50779, so I don't believe payment is due for the reviewer role in this case

  15. melvin-bot commented on Nov 18, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  16. luacmartins commented on Nov 18, 2024

    @luacmartins
    Contributor

    I agree. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions