Skip to content

[Reject] [Tracking] Reject (fka Decline) Expense in NewDot #52049

Closed

Description

@garrettmknight

DESIGN DOC
Customer Notification Issue

Note: we switched from Decline to Reject midstream. The old doc referencing Decline is here.

Proposal

WN Post

Proposal: Allow approvers to reject individual expenses in NewDot

Background: Generally, users have full control over the expenses assigned to them for processing. Submitters can create, edit, submit, or delete expenses to manage their reports effectively. Approvers typically have the ability to act on expenses by approving, editing, or rejecting them, aligning with the general expectation that individuals can manage tasks assigned to them. This level of control ensures efficiency and meets user expectations based on their use of Expensify Classic and expense reporting processes across the industry.

Problem: When submitted expenses just don’t fit within expense policy guidelines and will never be approved or paid, approvers are unable to remove them from their inbox. This prevents them from effectively and efficiently managing the tasks in their inbox, causing frustration and confusion.

Solution: Add the ability for approvers to unreport individual expenses submitted to them in NewDot. The naming of this function is TBD, but I’ll use ‘reject’ for familiarity’s sake. At a high level, let’s do the following:

  • Add a ‘Reject’ button to the expense details page
  • When an approver taps the button, we’ll show a confirmation page where we explain the difference between reject and hold, and allow the approver to confirm rejection with a comment or cancel.
  • When the approver confirms rejection with a comment, we’ll remove the expense from the report, and the submitter will be able to access it in their Self DM.

This solution aligns NewDot with functionality approvers are accustomed to in OldDot and gives approvers full control of the expenses in their inbox.

Implementation

Frontend:

Backend:

Follow up issues:

Tasks

  • Post Proposal (full Problem/Solution statement) in #expensify-open-source
  • Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
  • Paste Proposal in the space above with a link to the Slack thread
  • Email strategy@expensify.com and paste in the Proposal
  • Fill out the High-level overview of the problem, Timeline, and Terminology sections of the Design Doc
  • Email strategy@expensify.com (continue the same email chain as before) with the link to your Design Doc
  • Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
  • Fill out the High-level of proposed solution section
  • Email stategy@expensify.com again with links to the doc and pre-design conversation in Slack
  • Add the DesignDocReview label to get the High-level of proposed solution section reviewed
  • Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
  • Fill out the Detailed implementation of the solution and related sections.
  • Re-add the DesignDocReview label to this issue
  • Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
  • Confirm that the doc has the minimum necessary number of reviews before proceeding
  • Email strategy@expensify.com one last time to let them know the Design Doc is moving into the implementation phase
  • Implement the changes
  • Add regression tests so that QA can test your feature with every deploy (instructions)
  • Send out a follow up email to strategy@expensify.com once everything has been implemented and do a Project Wrap-Up retrospective that provides:
    • Summary of what we accomplished with this project
    • What went well?
    • What could we have done better?
    • What did we learn?
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    Current assignee @garrettmknight is eligible for the NewFeature assigner, not assigning anyone new.

  2. moved this to Future Cohort Project in #expensify-bugson Nov 5, 2024
  3. garrettmknight commented on Nov 13, 2024

    @garrettmknight
    ContributorAuthor

    Started to mock out the pre-design.

  4. garrettmknight commented on Nov 22, 2024

    @garrettmknight
    ContributorAuthor

    Same as above

  5. changed the title [-][Tracking] Reject Individual Expenses in NewDot[/-] [+][Tracking] Decline (formerly Reject) Expense in NewDot[/+] on Nov 28, 2024
  6. 288 remaining items

  7. melvin-bot commented on Dec 19, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@garrettmknight)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  8. melvin-bot commented on Dec 22, 2025

    @melvin-bot

    @garrettmknight Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. changed the title [-][Due for payment 2025-12-19] [Reject] [Tracking] Reject (fka Decline) Expense in NewDot[/-] [+][Reject] [Tracking] Reject (fka Decline) Expense in NewDot[/+] on Dec 24, 2025
  10. melvin-bot commented on Dec 24, 2025

    @melvin-bot

    @garrettmknight Huh... This is 4 days overdue. Who can take care of this?

  11. melvin-bot commented on Dec 26, 2025

    @melvin-bot

    @garrettmknight 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  12. garrettmknight commented on Dec 30, 2025

    @garrettmknight
    ContributorAuthor

    Wrap up is out, just awaiting payment before we close.

  13. mananjadhav commented on Dec 31, 2025

    @mananjadhav
    Collaborator

    Should we close this issue because there's a separate issue for the payment?

  14. garrettmknight commented on Jan 2, 2026

    @garrettmknight
    ContributorAuthor

    Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions