Skip to content

[Due for payment 2025-12-08] Remove the rterRejectedExpense warning when a submitter edits the expense #70484

Closed

Description

@garrettmknight

Main issue: #52049

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
Slack conversation (hyperlinked to channel name): migrate

Action Performed:

Prerecs:

  • Workspace with delay submissions enabled
  • Enable approvals
  1. As submitter, submit an expense
  2. As the approver, reject the expense
  3. As the submitter, edit the category of the expense (or anytihng about it really)

Expected Result:

In Classic, when users edit an expense that has been rejected, we automatically remove the warning.

Actual Result:

The user needs to manually click 'Mark as resovled' to remove the warn.

Workaround:

The user can manually click 'Mark as resolved' to remove the warn.

Platforms:

Select the officially supported platforms where the issue was reproduced:
All

Issue OwnerCurrent Issue Owner: @mananjadhav
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 12, 2025
  2. melvin-bot commented on Sep 12, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mananjadhav commented on Sep 14, 2025

    @mananjadhav
    Collaborator

    Will pick this tomorrow.

  4. moved this to Second Cohort - CRITICAL in [#whatsnext] #migrateon Sep 15, 2025
  5. mananjadhav commented on Sep 17, 2025

    @mananjadhav
    Collaborator

    Will pick this once the current bugs are fixed.

  6. melvin-bot commented on Sep 22, 2025

    @melvin-bot

    @mananjadhav Eep! 4 days overdue now. Issues have feelings too...

  7. 23 remaining items

  8. mananjadhav commented on Nov 24, 2025

    @mananjadhav
    Collaborator

    PR is raised, being reviewed

  9. mananjadhav commented on Nov 27, 2025

    @mananjadhav
    Collaborator

    PR was merged today.

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 1, 2025
  11. changed the title [-]Remove the rterRejectedExpense warning when a submitter edits the expense[/-] [+][Due for payment 2025-12-08] Remove the rterRejectedExpense warning when a submitter edits the expense[/+] on Dec 1, 2025
  12. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.66-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-08. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @truph01 requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    @mananjadhav / @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. mananjadhav commented on Dec 2, 2025

    @mananjadhav
    Collaborator

    We can wait for few days and close this one. Payout for this will be handled with the project.

  16. mananjadhav commented on Dec 5, 2025

    @mananjadhav
    Collaborator

    This is deployed to production and will be paid as a part of the project. Best to close this one in 2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions