Repository navigation
[HOLD for payment 2024-11-26] Card - In issue card page, no outline box is shown around amount #52370
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team
Action Performed:
- Go to https://staging.new.expensify.com/home
- Go to workspace settings
- Enable expensify card and add bank account
- Add both physical and virtual card with big amount
Expected Result:
In issue card page, outline box must be shown around amount.
Actual Result:
In issue card page, no outline box is shown around amount.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
bandicam.2024-11-12.11-41-47-727.mp4
Issue Owner
Current Issue Owner: @saklugerMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Nov 12, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 12, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 12, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
52 remaining items
sakluger commentedon Nov 25, 2024
@mountiny can you please clarify if this is a regression and who needs payment? You mentioned in this comment that it was a regression from a previous PR, but other comments state that it was an oversight in the original design. Thanks!
DylanDylann commentedon Nov 25, 2024
@sakluger I believe that it isn't regression. This seems like a new improvement. Thus, I think both me and @nkdengineer should get paid here
mountiny commentedon Nov 25, 2024
I think this was a regression, we missed this case in the previous styles PR so I would not issue a payment here as the original issue should be paid out.
the original issue should be paid out at full though. No payments here
sakluger commentedon Nov 26, 2024
Okay, thanks @mountiny for confirming! We're good to close 👍
nkdengineer commentedon Nov 26, 2024
@sakluger @mountiny I agree with @DylanDylann that it isn't regression. The bug described in OP as expected has been confirmed here, and we are currently handling another bug where the limit is being truncated. And in the issue and PR, we also made quite a few style changes.
mountiny commentedon Nov 26, 2024
@nkdengineer @DylanDylann I dont think so, I think this issue was a direct consequence of the previous PR and the fact we did not notice it in the previous design rounds or PR review is not and excuse
There its a third PR issue here #52663 that was also linked to these changes, I dont think it would be fair to issue $750 reward for all these changes that technically should have been done in one PR. So I think having $500 in total is more than enough in this case
nkdengineer commentedon Nov 26, 2024
@mountiny The truncated bug that we fixed on this issue also happened before we merged the first PR and it also isn't mentioned in the first issue
Another point, I get paid 125$ on the first issue only
mountiny commentedon Nov 26, 2024
So its $375 total as this was a regression #52663 from the PRs which leads to reduction of the original pay. So even if we consider this one as full one, I think it checks out. $250 for this one, $125 for the original one, because there was a regression in the design #52663 so $375 sounds right to me
nkdengineer commentedon Nov 27, 2024
Thanks @mountiny, i agree with you 375$ for all. This issue is not paid yet so you mean we need to make a payment here, right?
mountiny commentedon Nov 28, 2024
we can handle the payment #52663