You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-17] [$250] iOS/Android - Contact method - Contact method not displayed until re-login or cleaning cache #53481
Version Number: 9.0.71.3 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5291147 Issue reported by: Applause Internal Team
Action Performed:
Open the app and log in
Navigate to Account settings > Profile > Contact methods
Select New contact method
Enter an email of a new contact method
Enter the magic code and tap the Verify button
Expected Result:
New unverified contact method with GBR is displayed in the table
Actual Result:
New unverified contact method is not displayed in the table until user re-logs in or clears cache and restarts
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I'm curious if our site stability issues are causing this, but I will look at recent PRs since I'm not 100% sure this should be broken on staging and not prod.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] iOS/Android - Contact method - Contact method not displayed until re-login or cleaning cache[/-][+][HOLD for payment 2024-12-17] [$250] iOS/Android - Contact method - Contact method not displayed until re-login or cleaning cache[/+]on Dec 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@brunovjk@muttmuure@brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Case 1:
Navigate to Account Settings > Profile > Contact Methods.
Select "New Contact Method."
Enter a valid email.
Enter the correct magic code.
Verify that the new contact method is displayed in the contact methods list.
Case 2:
Navigate to Account Settings > Profile > Contact Methods.
Select "New Contact Method."
Enter an already registered email.
Enter the correct magic code.
Verify that you see "Existing account cannot be added ..."
Dismiss the error.
Go back to the contact methods list.
Verify that the unverified contact method isn't displayed.
Case 3:
Navigate to Account Settings > Profile > Contact Methods.
Select "New Contact Method."
Enter a valid email.
Enter an incorrect magic code.
Dismiss the error.
Go back to the contact methods list.
Verify that the unverified contact method isn't displayed.
Activity
melvin-bot commentedon Dec 3, 2024
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 3, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 3, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Dec 3, 2024
Production
Screenrecorder-2024-12-03-20-33-30-202.mp4
AndrewGable commentedon Dec 3, 2024
I'm curious if our site stability issues are causing this, but I will look at recent PRs since I'm not 100% sure this should be broken on staging and not prod.
github-actions commentedon Dec 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
46 remaining items
[-][$250] iOS/Android - Contact method - Contact method not displayed until re-login or cleaning cache[/-][+][HOLD for payment 2024-12-17] [$250] iOS/Android - Contact method - Contact method not displayed until re-login or cleaning cache[/+]melvin-bot commentedon Dec 10, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 10, 2024
@brunovjk @muttmuure @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
brunovjk commentedon Dec 16, 2024
We had a regression here, but it was promptly identified and resolved here.
brunovjk commentedon Dec 16, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: comment
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Case 1:
Case 2:
Case 3:
Do we agree 👍 or 👎
fix: several improvements
muttmuure commentedon Dec 19, 2024
Paid up