You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat #53990
Version Number: 9.0.75-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+kh1311020@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Search
Action Performed:
Precondition:
Scheduled submit is disabled on Old Dot.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense to the workspace chat.
Note that Submit button is green.
Go to Search.
Note that Submit buton is also green.
Go back to workspace chat.
Go to transaction thread.
Click on the report header > Hold > Hold the expense.
Note that Submit button is still green in the workspace chat.
Go to Search.
Expected Result:
Submit button in Search should remain green because the same button is green in workspace chat when the expense is held.
Actual Result:
For held expense, Submit button is gray in Search, and green in workspace chat.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Hmm I'm not sure if that's coming from that PR. The Search behavior seems correct to me, the button should be gray when there's a held transaction. I can take a look at this one
changed the title [-] Search - For held expense, Submit button is gray in Search, and green in workspace chat[/-][+][HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat[/+]on Dec 12, 2024
Activity
melvin-bot commentedon Dec 12, 2024
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 12, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 12, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 12, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Dec 12, 2024
Production behavior
bandicam.2024-12-12.07-20-32-302.mp4
MonilBhavsar commentedon Dec 12, 2024
Minor design issue. Not a blocker
@luacmartins @ishpaul777 looks like it is coming from #53641
luacmartins commentedon Dec 12, 2024
Hmm I'm not sure if that's coming from that PR. The Search behavior seems correct to me, the button should be gray when there's a held transaction. I can take a look at this one
luacmartins commentedon Dec 12, 2024
BTW we're gonna revert how we're handling grey/green buttons in App. So this should be on hold for now
[-] Search - For held expense, Submit button is gray in Search, and green in workspace chat[/-][+][HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat[/+]jliexpensify commentedon Dec 16, 2024
@luacmartins should we change the priority, or keep it as a
Daily?I'm also OOO from the 19th - 29th, but I don't think there will be anything for me to action, right?
luacmartins commentedon Dec 16, 2024
I think we can close this in favor of #54054