You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.0.78-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):nathanmulugetatesting+2558@gmail.com Issue reported by: Applause Internal Team Device used: iPhone 11 / iOS 18.1 App Component: Other
Action Performed:
Open NewDot app
Navigate to Workspaces
Navigate to a Workspace
Navigate to Members
Expected Result:
The icon next to the header "Members" should have the right color:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Activity
melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 24, 2024
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 24, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 24, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon Dec 24, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Icons are corrupted on IOS
What is the root cause of that problem?
We are using
fill={iconFill ?? theme.icon}inApp/src/components/HeaderWithBackButton/index.tsx
Line 185 in dc784de
That makes the icon has the
theme.iconcolorWhat changes do you think we should make in order to solve the problem?
We should add the new prop like
shouldUseThemeIconColordefault as true, the disable it in case we need like inWorkspacesListPage, ...What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Result
daledah commentedon Dec 24, 2024
@sonialiap @aldo-expensify Here's the offending PR: #52823. I can raise the quick PR to fix it
aldo-expensify commentedon Dec 24, 2024
The corruption is also reproducible in web:
1 remaining item
daledah commentedon Dec 24, 2024
@aldo-expensify My solution works well on web too.
aldo-expensify commentedon Dec 24, 2024
Thanks @daledah for the investigation, I tried to go with a simpler approach that I think should also work: #54531
daledah commentedon Dec 24, 2024
@aldo-expensify Can I help review the PR?
aldo-expensify commentedon Dec 24, 2024
No need @daledah , I think we need a C+ or someone from the Expensify engineering team. Thanks for offering though.
shawnborton commentedon Dec 24, 2024
Just to clarify this one, isn't it a regression? If so, shouldn't as ask the offending PR author to fix it?
aldo-expensify commentedon Dec 24, 2024
It is a regression.
Yes, but that sometimes can take time and here the fix seems to be easy, so I put a PR to be able to clear the deploy blocker asap.
parasharrajat commentedon Dec 24, 2024
This is a duplicate issue of #54480. I have already created a PR for it. #54494
@aldo-expensify
parasharrajat commentedon Dec 24, 2024
May be you can review that and merge. Or I review your PR as C+, this way my efforts will not go waste. Then I will close my PR.
aldo-expensify commentedon Dec 24, 2024
Closing this as a dupe of #54480
melvin-bot commentedon Dec 24, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.