Skip to content

Bank account - Workspace currency is not changed to USD after clicking Update to USD #54691

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace default currency is not USD.
  1. Go to staging.new.expensify.com
  2. Go to Workspace settings > Workflows.
  3. Click Connect bank account.
  4. Click Update to USD.
  5. Go to Workspace profile.

Expected Result:

Workspace currency will be changed to USD after clicking Update to USD

Actual Result:

Workspace currency is not changed to USD after clicking Update to USD

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704687_1735685150019.20250101_064254.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 31, 2024
  2. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. linhvovan29546 commented on Jan 1, 2025

    @linhvovan29546
    Contributor

    Offending PR: #52812

  7. mallenexpensify commented on Jan 1, 2025

    @mallenexpensify
    Contributor

    Thanks @linhvovan29546 ! I'm unable to reproduce on my mallen@expensifail.com account, after I click Connect bank account in workflow I'm stuck on

    We’re taking a look at your information. You'll be able to continue with next steps shortly.

    With it being NYE here and New Year's Day tomorrow, I don't imagine we'll be deploying to production for a bit.

  8. mallenexpensify commented on Jan 1, 2025

    @mallenexpensify
    Contributor

    @pasyukevich 👀 please as #52812 might be the offending PR

  9. linhvovan29546 commented on Jan 1, 2025

    @linhvovan29546
    Contributor

    With it being NYE here and New Year's Day tomorrow, I don't imagine we'll be deploying to production for a bit.

    I looked into the details, and it fails in other places as well. That PR only update in the WorkspaceProfileCurrencyPage and not update other places
    image

    eg: #54696 (comment)

  10. pasyukevich commented on Jan 2, 2025

    @pasyukevich
    Contributor

    Not reproducible after fix pr - #54722

  11. grgia commented on Jan 2, 2025

    @grgia
    Contributor

    Closing as completed, I can't reproduce on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions