Skip to content

[HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated #54696

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com
  2. Create a WS and navigate to WS profile
  3. Try to edit WS name

Expected Result:

WS name can be edited/ Updated

Actual Result:

WS name could not be edited/ updated

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704696_1735687069171.bandicam_2025-01-01_02-13-42-508.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 1, 2025
  2. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mallenexpensify commented on Jan 1, 2025

    @mallenexpensify
    Contributor

    Confirming I am able to reproduce on staging and not on production.
    @marcaaron is working ~25% today so he might already be off.

    We're not deploying to production on NYE or New Year's Day, right ? Which makes me think that Thurs would be the earliest.

    Only issue I could quickly find that looked like it could be related

  7. NJ-2020 commented on Jan 1, 2025

    @NJ-2020
    Contributor

    Offending PR: #52812

    We're changing the param name here from
    policyID, name, currencyValue
    to
    name, currencyValue, policyID

    But we're not updating here which is (policyID, name, currencyValue)

    Policy.updateGeneralSettings(policy.id, values.name.trim(), policy.outputCurrency);

    So inside the onSubmit function here we will exit from updating the workspace name if the policy value is undefined

    Since we do not update it here the policyID value is the currencyValue and when we check here it will return true

    Policy.updateGeneralSettings(policy.id, values.name.trim(), policy.outputCurrency);

    function updateGeneralSettings(name: string, currencyValue?: string, policyID?: string) {
    const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
    if (!policy || !policyID) {
    return;
    }

    cc: @mallenexpensify


    I can raise a PR if needed

  8. melvin-bot commented on Jan 1, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 13 remaining items

  10. Beamanator commented on Jan 2, 2025

    @Beamanator
    Contributor

    amazing, thanks!! closing since no payment due 👍

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 6, 2025
  12. changed the title [-]Workspace- Workspace name could not be edited/updated[/-] [+][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+] on Jan 6, 2025
  13. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-13. 🎊

  14. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. changed the title [-][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/-] [+][HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+] on Jan 8, 2025
  16. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-15. 🎊

  17. melvin-bot commented on Jan 8, 2025

    @melvin-bot

    @Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions