You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated #54696
Version Number: v9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):testpayment935@gmail.com Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome, Samsung s10/ Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Workspace- Workspace name could not be edited/updated[/-][+][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+]on Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Beamanator@mallenexpensify@Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/-][+][HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+]on Jan 8, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Beamanator@mallenexpensify@Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 1, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mallenexpensify commentedon Jan 1, 2025
Confirming I am able to reproduce on staging and not on production.
@marcaaron is working ~25% today so he might already be off.
We're not deploying to production on NYE or New Year's Day, right ? Which makes me think that Thurs would be the earliest.
Only issue I could quickly find that looked like it could be related
NJ-2020 commentedon Jan 1, 2025
Offending PR: #52812
We're changing the param name here from
policyID, name, currencyValueto
name, currencyValue, policyIDBut we're not updating here which is (policyID, name, currencyValue)
App/src/pages/workspace/WorkspaceNamePage.tsx
Line 34 in e5108a1
So inside the onSubmit function here we will exit from updating the workspace name if the policy value is undefined
Since we do not update it here the policyID value is the currencyValue and when we check here it will return true
App/src/pages/workspace/WorkspaceNamePage.tsx
Line 34 in e5108a1
App/src/libs/actions/Policy/Policy.ts
Lines 1196 to 1200 in e5108a1
cc: @mallenexpensify
I can raise a PR if needed
melvin-bot commentedon Jan 1, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
13 remaining items
Beamanator commentedon Jan 2, 2025
amazing, thanks!! closing since no payment due 👍
[-]Workspace- Workspace name could not be edited/updated[/-][+][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+]melvin-bot commentedon Jan 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-13. 🎊
melvin-bot commentedon Jan 6, 2025
@Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/-][+][HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated[/+]melvin-bot commentedon Jan 8, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-15. 🎊
melvin-bot commentedon Jan 8, 2025
@Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]