Skip to content

Wallet - Account number field shows two error messages when it is empty #54692

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Wallet.
  3. Click Add bank account.
  4. Select Malaysia as country if not selected.
  5. Without entering Account number, click Next.

Expected Result:

Account number field should only show one error message (This field is required) when it is empty.

Actual Result:

Account number field shows two error messages when it is empty -
This field is required.
Beneficiary Account Number is invalid. Value should be 1 to 50 characters long.

It should only show "Beneficiary Account Number is invalid. Value should be 1 to 50 characters long." after entering invalid account number.

The same issue happens with Bank account holder field.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704690_1735685441395.20250101_064755.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 31, 2024
  2. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 31, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. NJ-2020 commented on Dec 31, 2024

    @NJ-2020
    Contributor

    Offending PR: #52322

    function getValidationErrors(values: FormOnyxValues<typeof ONYXKEYS.FORMS.INTERNATIONAL_BANK_ACCOUNT_FORM>, fieldsMap: CorpayFieldsMap, translate: LocaleContextProps['translate']) {
    const errors = {};
    for (const fieldName in fieldsMap) {
    if (!fieldName) {
    // eslint-disable-next-line no-continue
    continue;
    }
    if (fieldsMap[fieldName].isRequired && values[fieldName] === '') {
    ErrorUtils.addErrorMessage(errors, fieldName, translate('common.error.fieldRequired'));
    }

    I think we need to add return statement here
    if (fieldsMap[fieldName].isRequired && values[fieldName] === '') {
    ErrorUtils.addErrorMessage(errors, fieldName, translate('common.error.fieldRequired'));
    }

  7. jliexpensify commented on Jan 1, 2025

    @jliexpensify
    Contributor

    Assigning @DylanDylann and @MonilBhavsar as they worked on the offending PR.

  8. deleted a comment from melvin-bot on Jan 1, 2025
  9. DylanDylann commented on Jan 1, 2025

    @DylanDylann
    Contributor

    @shubham1206agra Could you please fix this bug?

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 1, 2025
  11. MonilBhavsar commented on Jan 1, 2025

    @MonilBhavsar
    Contributor

    @joekaufmanexpensify curious for your thoughts. In this case, should we display, "required" error first and then if user's input is out of 1-50 range, then display the another error?

    We can discuss here https://expensify.slack.com/archives/C01GTK53T8Q/p1735689150858259

  12. izarutskaya commented on Jan 2, 2025

    @izarutskaya

    Hi @MonilBhavsar We have similar issue in Account Holder Name Field and Beneficiary bank branch name. Should we need create a separate issue or it is the same? Thank you

    Screenshot 2025-01-02 at 7 43 40 in the morning

    Screenshot 2025-01-02 at 7 44 38 in the morning

  13. shubham1206agra commented on Jan 2, 2025

    @shubham1206agra
    Contributor
  14. shubham1206agra commented on Jan 2, 2025

    @shubham1206agra
    Contributor

    No

  15. MonilBhavsar commented on Jan 2, 2025

    @MonilBhavsar
    Contributor

    No separate issue is required 👍

  16. MonilBhavsar commented on Jan 3, 2025

    @MonilBhavsar
    Contributor

    Closing as we're tracking in #54743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringPlanningChanges still in the thought process

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions