You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wallet - Account number field shows two error messages when it is empty #54692
Version Number: 9.0.80-1 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+394034@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Go to Wallet.
Click Add bank account.
Select Malaysia as country if not selected.
Without entering Account number, click Next.
Expected Result:
Account number field should only show one error message (This field is required) when it is empty.
Actual Result:
Account number field shows two error messages when it is empty -
This field is required.
Beneficiary Account Number is invalid. Value should be 1 to 50 characters long.
It should only show "Beneficiary Account Number is invalid. Value should be 1 to 50 characters long." after entering invalid account number.
The same issue happens with Bank account holder field.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@joekaufmanexpensify curious for your thoughts. In this case, should we display, "required" error first and then if user's input is out of 1-50 range, then display the another error?
Hi @MonilBhavsar We have similar issue in Account Holder Name Field and Beneficiary bank branch name. Should we need create a separate issue or it is the same? Thank you
Activity
melvin-bot commentedon Dec 31, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 31, 2024
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 31, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
NJ-2020 commentedon Dec 31, 2024
Offending PR: #52322
App/src/pages/settings/Wallet/InternationalDepositAccount/utils.ts
Lines 130 to 139 in e5108a1
I think we need to add return statement here
App/src/pages/settings/Wallet/InternationalDepositAccount/utils.ts
Lines 137 to 139 in e5108a1
jliexpensify commentedon Jan 1, 2025
Assigning @DylanDylann and @MonilBhavsar as they worked on the offending PR.
DylanDylann commentedon Jan 1, 2025
@shubham1206agra Could you please fix this bug?
MonilBhavsar commentedon Jan 1, 2025
@joekaufmanexpensify curious for your thoughts. In this case, should we display, "required" error first and then if user's input is out of 1-50 range, then display the another error?
We can discuss here https://expensify.slack.com/archives/C01GTK53T8Q/p1735689150858259
izarutskaya commentedon Jan 2, 2025
Hi @MonilBhavsar We have similar issue in Account Holder Name Field and Beneficiary bank branch name. Should we need create a separate issue or it is the same? Thank you
shubham1206agra commentedon Jan 2, 2025
@izarutskaya No
shubham1206agra commentedon Jan 2, 2025
No
MonilBhavsar commentedon Jan 2, 2025
No separate issue is required 👍
MonilBhavsar commentedon Jan 3, 2025
Closing as we're tracking in #54743