Skip to content

[HOLD for payment 2025-02-04] [Tracking Issue] Fixes to Implemented International Bank Account flow #54743

Closed

Description

@Beamanator

This big PR has lots of little issues we need to fix. Tracking them here so we can try to keep them all in 1 place & note what the next steps are for each

cc @shubham1206agra @DylanDylann @MonilBhavsar

Activity

  1. shubham1206agra commented on Jan 2, 2025

    @shubham1206agra
    Contributor

    Still marked as blockers - now need to be tested to see if they're fixed in staging:

    Issues marked NAB - probably can close them all, but need to be addressed before next mega PR is merged:

  2. Julesssss commented on Jan 2, 2025

    @Julesssss
    Contributor

    Happy 2025, here's another bug to fix, I added it to the list above: #54746

  3. Beamanator commented on Jan 2, 2025

    @Beamanator
    ContributorAuthor

    Reverted the big PR (#54729), will CP soon after making sure it didn't break everything

  4. parasharrajat commented on Jan 2, 2025

    @parasharrajat
    Member

    We can start closing the related issues in that case.

  5. Beamanator commented on Jan 2, 2025

    @Beamanator
    ContributorAuthor

    Yeah once it's CP'd 🙏

  6. Beamanator commented on Jan 2, 2025

    @Beamanator
    ContributorAuthor

    Ok so the revert CP was successful, in 9.0.80.6

    I'm going to ask QA to help test all of the issues on this list, starting with the blockers, to at least help us unblock the deploy

  7. Beamanator commented on Jan 2, 2025

    @Beamanator
    ContributorAuthor

    Once each is confirmed fix / not reproducible in staging, we can check them of the list above.

    Finally, @shubham1206agra will be working on making sure none exist in his next PR (looks like the draft was started above)

  8. izarutskaya commented on Jan 3, 2025

    @izarutskaya

    #54737 - found issue - #52199
    #54738 - issue #52199
    #54740 - issue #52199
    #54746 - found issue #54767
    #54749 - issue #52199
    #54751 - issue #52199
    #54742 - issue #52199
    #54692 - pending on Web

  9. izarutskaya commented on Jan 3, 2025

    @izarutskaya

    #54692 - all slots are passed. Checking off

  10. shubham1206agra commented on Jan 3, 2025

    @shubham1206agra
    Contributor

    @MonilBhavsar Can you close all the issues? Since I will keep track of these through this tracker.

  11. added
    ReviewingHas a PR in review
    and removed on Jan 4, 2025
  12. melvin-bot commented on Jan 23, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. melvin-bot commented on Jan 24, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 28, 2025
  15. changed the title [-][Tracking Issue] Fixes to Implemented International Bank Account flow[/-] [+][HOLD for payment 2025-02-04] [Tracking Issue] Fixes to Implemented International Bank Account flow[/+] on Jan 28, 2025
  16. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-04. 🎊

    For reference, here are some details about the assignees on this issue:

  18. shubham1206agra commented on Jan 28, 2025

    @shubham1206agra
    Contributor
  19. MonilBhavsar commented on Jan 28, 2025

    @MonilBhavsar
    Contributor

    Thanks for handing this! I think we can close this as payment will be handled in the main issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions