Skip to content

Wallet - Make default payment method option uses a message icon instead of star icon #54750

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): applausetester+394034@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: User Settings

Action Performed:

Precondition:

  • Account has two personal bank accounts.
  1. Go to staging.new.expensify.com
  2. Go to Account settings > Wallet.
  3. Click on the non-default bank account.

Expected Result:

Make default payment method option uses a star icon (according to this doc https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit?tab=t.0)

Actual Result:

Make default payment method option uses a message icon instead of star icon.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704997_1735809214614.20250102_163155.mp4
Bug6704997_1735809214591!Screenshot_2025-01-02_at_16 32 25

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 2, 2025
  2. melvin-bot commented on Jan 2, 2025

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. linhvovan29546 commented on Jan 2, 2025

    @linhvovan29546
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Make default payment method option uses a message icon instead of star icon.

    What is the root cause of that problem?

    In the wallet page, we useMail icon for "Make default payment method" button

    What changes do you think we should make in order to solve the problem?

    We need to update Mail icon to Star icon here

    from

    {shouldShowMakeDefaultButton && (
    <MenuItem
    title={translate('walletPage.setDefaultConfirmation')}
    icon={Expensicons.Mail}

    to

      <MenuItem
       title={translate('walletPage.setDefaultConfirmation')}
        icon={Expensicons.Star}

    We can also consider updating here as well.

    POC Screenshot 2025-01-02 at 5 41 36 PM

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    No, it only UI

    What alternative solutions did you explore? (Optional)

    N/A

  4. github-actions commented on Jan 2, 2025

    @github-actions
    Contributor

    Haochensong Your proposal will be dismissed because you did not follow the proposal template.

  5. nkdengineer commented on Jan 3, 2025

    @nkdengineer
    Contributor

    I think this will be fixed here.

  6. melvin-bot commented on Jan 6, 2025

    @melvin-bot

    @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions