You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wallet - Make default payment method option uses a message icon instead of star icon #54750
Version Number: 9.0.80-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#52322 Email or phone of affected tester (no customers):applausetester+394034@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.0 / Chrome App Component: User Settings
Activity
melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.linhvovan29546 commentedon Jan 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Make default payment method option uses a message icon instead of star icon.
What is the root cause of that problem?
In the wallet page, we use
Mailicon for "Make default payment method" buttonWhat changes do you think we should make in order to solve the problem?
We need to update
Mailicon toStaricon herefrom
App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx
Lines 580 to 583 in 629220d
to
We can also consider updating here as well.
POC
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No, it only UI
What alternative solutions did you explore? (Optional)
N/A
github-actions commentedon Jan 2, 2025
Haochensong Your proposal will be dismissed because you did not follow the proposal template.
nkdengineer commentedon Jan 3, 2025
I think this will be fixed here.
melvin-bot commentedon Jan 6, 2025
@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!