You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-04] [$250] Wallet - In debug menu any toggle action applied with a delay #54767
Issue was found while executing issue retest #54746
Version Number: v9.0.80-6 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#54746 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: MacOS Catalina 10.15.7 App Component: Other
Action Performed:
Precondition: user is logged in desktop app.
Go to Settings > Wallet
Press key combination Cmd+D
Turn any toggle (e.g. Force offline)
Expected Result:
Toggle is switched immediately.
Actual Result:
Toggle is not response. User has to close debug menu and go to another tad to see change applied.
And in debug menu we have Switch component, we handle onToggle callback inside InteractionManager.runAfterInteractions come from this PR #40650 and it never called because the Lottie Animation in the Wallet page is running loop
Note: This issue only occurs when using the BankVault animation. I tested with other animations, and they worked well.(I'm not sure if the BankVault animation behaves differently from other animations)
The root cause related to the Lottie animation prevents the InteractionManager.runAfterInteractions callback from executing, While that issue is marked as 'Hold for React Native 0.76,' I think it is not related to the RN version. 🤔
changed the title [-]Wallet - In debug menu any toggle action applied with a delay[/-][+][$250] Wallet - In debug menu any toggle action applied with a delay[/+]on Jan 7, 2025
changed the title [-][$250] Wallet - In debug menu any toggle action applied with a delay[/-][+][HOLD for payment 2025-02-04] [$250] Wallet - In debug menu any toggle action applied with a delay[/+]on Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rayane-djouah@bfitzexpensify@rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@bfitzexpensify] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
#### Test:
1. Go to Settings > Wallet
2. Press key combination Cmd+D
3. Turn any toggle (e.g. Force offline)
4. Verify that toggle is switched immediately.
📣 @rayane-d! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
melvin-bot commentedon Jan 2, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.linhvovan29546 commentedon Jan 3, 2025
Edited by proposal-police: This proposal was edited at 2025-01-03 03:07:12 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet - Toggle is not response. User has to close debug menu and go to another tad to see change applied.
What is the root cause of that problem?
In the wallet page, we have Lottie Animation here
App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx
Lines 373 to 378 in 1cfcfa4
And in debug menu we have
Switchcomponent, we handleonTogglecallback insideInteractionManager.runAfterInteractionscome from this PR #40650 and it never called because the Lottie Animation in theWalletpage is running loopNote: This issue only occurs when using the
BankVaultanimation. I tested with other animations, and they worked well.(I'm not sure if theBankVaultanimation behaves differently from other animations)App/src/components/Switch.tsx
Lines 45 to 53 in 1cfcfa4
What changes do you think we should make in order to solve the problem?
We can replace
InteractionManager.runAfterInteractionstoor
Alternatively, we can remove
InteractionManager.runAfterInteractions.I've tested the update and can no longer reproduce the issue #40650
POC
Screen.Recording.2025-01-03.at.9.42.06.AM.mov
Screen.Recording.2025-01-03.at.9.07.25.AM.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No, it only UI
What alternative solutions did you explore? (Optional)
We can consider adding a new prop to the
Switchcomponent to specify whetherInteractionManager.runAfterInteractionsshould be usedWe can consider pause Lottie Animation when debug menu is opened here
andriivitiv commentedon Jan 5, 2025
This is similar to #53208
melvin-bot commentedon Jan 6, 2025
@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
linhvovan29546 commentedon Jan 6, 2025
The root cause related to the
Lottieanimation prevents theInteractionManager.runAfterInteractionscallback from executing, While that issue is marked as 'Hold for React Native 0.76,' I think it is not related to the RN version. 🤔bfitzexpensify commentedon Jan 7, 2025
This isn't a customer flow, but not ideal for debugging.
[-]Wallet - In debug menu any toggle action applied with a delay[/-][+][$250] Wallet - In debug menu any toggle action applied with a delay[/+]melvin-bot commentedon Jan 7, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021876724087999435775
35 remaining items
[-][$250] Wallet - In debug menu any toggle action applied with a delay[/-][+][HOLD for payment 2025-02-04] [$250] Wallet - In debug menu any toggle action applied with a delay[/+]melvin-bot commentedon Jan 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 28, 2025
@rayane-djouah @bfitzexpensify @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rayane-d commentedon Feb 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/40650/files#r1939526071
If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[@bfitzexpensify] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Do we agree 👍 or 👎
melvin-bot commentedon Feb 3, 2025
📣 @rayane-d! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
rayane-d commentedon Feb 4, 2025
Requested in NewDot
bfitzexpensify commentedon Feb 4, 2025
Payment summary:
$250 for @linhvovan29546 - paid via Upwork
$250 for @rayane-d - to be paid via ND request
garrettmknight commentedon Feb 11, 2025
$250 approved for @rayane-d