You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] [$500] We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over #54915
We load the correct "Travel and expense, at the speed of chat" modal - but you can hear the music start from the "Welcome to Expensify" modal/video in the background
When I click Let's go! the "Welcome to Expensify" modal loads. You can also see the background show "Hmm... it's not here"
Both the "Welcome to Expensify" modal should not load and the "Hmm... it's not here" should not show up. The reports page should be in the background so after I click Let's go it should take me to the reports page.
We're looking to have this fixed immediately so I'll ask someone from C+ to pick
changed the title [-]We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over[/-][+][$500] We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over[/+]on Jan 7, 2025
### Test 1 (Migrated account):
#### Precondition:
You need an account that is opened from oldot and which has some expenses:
1. Sign in to a new account on OldDot web (expensify.com).
2. Logout
3. Sign in again in the same account to validate it with a magic code
4. Create a workspace.
5. Create a report with expenses and submit it.
6. run this script in browse's console to to directly open New Expensify on signin and to migrate the account:
```
NVP.set('tryNewDot', {classicRedirect: {dismissed: false, completedHybridAppOnboarding: false}, nudgeMigration: {timestamp: '2024-01-07'}});
```
#### Test Steps:
1. Sign in to the same account on Oldot/HybridApp.
2. New Expensify will open
3. Verify that the "Welcome to Expensify" modal does not appear.
4. Confirm that the "Travel and expense, at the speed of chat" modal is displayed.
5. Ensure that there is no music playing.
6. Click "Let's go!" and verify:
- The "Welcome to Expensify" modal does not load.
- The "Hmm... it's not here" modal does not appear.
- The search page is displayed in the background and clicking "Let's go!" redirects you to the search page.
7. Open the expenses.
8. Verify that you can open expenses and interact with the app without freezing or crashing.
9. Close the app and reopen it.
10. Verify that neither the "Welcome to Expensify" modal nor the "Travel and expense, at the speed of chat" modal appear.
11. Log out and log in again.
12. Verify that neither the "Welcome to Expensify" modal nor the "Travel and expense, at the speed of chat" modal appear.
### Test 2 (Unmigrated account):
#### Precondition:
You need an account that is opened from oldot and which has some expenses:
1. Sign in to a new account on OldDot web (expensify.com).
2. Logout
3. Sign in again in the same account to validate it with a magic code
4. Create a workspace.
5. Create a report with expenses and submit it.
6. run this script in browse's console to to directly open New Expensify on signin:
```
NVP.set('tryNewDot', {classicRedirect: {dismissed: false, completedHybridAppOnboarding: false}});
```
#### Test Steps:
1. Sign in to the same account on Oldot/HybridApp.
2. New Expensify will open
3. Verify that the "Welcome to Expensify" modal appears.
4. Confirm that the "Travel and expense, at the speed of chat" modal does not appear.
5. Click "Get Started!" and verify that the "Welcome to Expensify" modal disappears.
@Christinadobrzyn - @allroundexperts and I resolved the bug on staging with a follow-up PR. Therefore, I believe no regression penalty is applicable here, and we can close #55021 without payment.
The payment for this issue is $500.
Hey @rayane-djouah - The regression penalty still applies here, I was incorrect. This is not accurate - #54915 (comment)
Our rules are
If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):
payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue
So I'm going to add that 50% reduction for this issue to the payment section.
@Christinadobrzyn I don't think we should add the penalty here. I was pushing hard to get these PRs out and cherry picked, so we didn't take as long on testing/QA as normal. That's on me more than the contributors, so I don't think we should penalize them for it.
Activity
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)[-]We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over[/-][+][$500] We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over[/+]melvin-bot commentedon Jan 7, 2025
melvin-bot commentedon Jan 7, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.rayane-d commentedon Jan 8, 2025
PR merged 🎉
48 remaining items
Christinadobrzyn commentedon Jan 18, 2025
Payday is here! Payment summary - #54915 (comment)
Ah wait, do we need a regression test @allroundexperts?
rayane-d commentedon Jan 20, 2025
Regression Test Proposal
Do we agree 👍 or 👎
rayane-d commentedon Jan 20, 2025
@Christinadobrzyn - @allroundexperts and I resolved the bug on staging with a follow-up PR. Therefore, I believe no regression penalty is applicable here, and we can close #55021 without payment.
The payment for this issue is $500.
Christinadobrzyn commentedon Jan 21, 2025
Oh awesome, this makes sense, thanks @rayane-djouah!
Regression test here - https://github.com/Expensify/Expensify/issues/463325
I updated the payment summary based on the above comment.
Christinadobrzyn commentedon Jan 23, 2025
Hey @rayane-djouah - The regression penalty still applies here, I was incorrect. This is not accurate - #54915 (comment)
Our rules are
If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):
payments will be issued 7 days after all regressions are fixed (ie: deployed to production)
a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue
So I'm going to add that 50% reduction for this issue to the payment section.
puneetlath commentedon Jan 24, 2025
@Christinadobrzyn I don't think we should add the penalty here. I was pushing hard to get these PRs out and cherry picked, so we didn't take as long on testing/QA as normal. That's on me more than the contributors, so I don't think we should penalize them for it.
garrettmknight commentedon Jan 29, 2025
$500 approved for @rayane-djouah
JmillsExpensify commentedon Jun 13, 2025
$500 approved for @allroundexperts. Re-open though so that the payment summary is updated to be accurate.
Christinadobrzyn commentedon Jun 13, 2025
Thank you for reopening! I updated the payment summary to $500 for each contributor.