Skip to content

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] Hybrid - Android - Onboarding - "Travel and expense, at the speed of chat" modal appears after every login #55021

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #54972
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Other

Action Performed:

Setup:
It can be run on the Web (https://staging.expensify.com)

  1. Sign in to a new account on OldDot
  2. Create a workspace
  3. Create a report with expenses and submit it
  4. Run this script in the browser console:
    NVP.set('tryNewDot', {classicRedirect: {dismissed: true, completedHybridAppOnboarding: false}, nudgeMigration: {timestamp: '2024-01-07'}});

Steps:

  1. Open the Expensify app
  2. Sign in to the same account registered in the setup
  3. Switch to NewDot
  4. Confirm that the "Travel and expense, at the speed of chat" modal is displayed
  5. Tap on "Let's go!"
  6. Log out and log in again

Expected Result:

The "Travel and expense, at the speed of chat" modal only appears after the first login for migrated accounts.

Actual Result:

The "Travel and expense, at the speed of chat" modal appears after every login in migrated accounts.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709600_1736393099906.Onboarding_-_Modal_always_appears.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 9, 2025
  2. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jan 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. aldo-expensify commented on Jan 9, 2025

    @aldo-expensify
    Contributor

    Seems like this is getting fixed by #55005, so this doesn't look like a DeployBlocker

  7. 30 remaining items

  8. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    @allroundexperts / @rayane-djouah @muttmuure @allroundexperts / @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  10. changed the title [-][HOLD for payment 2025-01-17] Hybrid - Android - Onboarding - "Travel and expense, at the speed of chat" modal appears after every login[/-] [+][HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] Hybrid - Android - Onboarding - "Travel and expense, at the speed of chat" modal appears after every login[/+] on Jan 11, 2025
  11. melvin-bot commented on Jan 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-18. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 11, 2025

    @melvin-bot

    @allroundexperts / @rayane-djouah @muttmuure @allroundexperts / @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Jan 18, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@muttmuure)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. Christinadobrzyn commented on Jan 20, 2025

    @Christinadobrzyn
    Contributor

    I believe this is a regression of #54915, correct?

    So payment would only be made - #54915 and this will just be closed?

  15. rayane-d commented on Jan 20, 2025

    @rayane-d
    Contributor

    Yes, we can close this one without payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions