[Due for payment 2025-02-19] [$250] mweb - Onboarding - Accounting software selection has blue border when redirected from OD

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.84-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): wijdwjmwdowdjo@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Other

Action Performed:

Go to staging.expensify.com
Select "Manage expenses for a small team".
Enter email.
Tap Get started.
Tap Join.
On ND, select any accounting software.

Expected Result:

The accounting software selection will not have blue border.

Actual Result:

The accounting software selection has blue border when redirected from OD.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6712636_1736716164990.ScreenRecording_01-13-2025_05-04-33_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021878829529063238484
Upwork Job ID: 1878829529063238484
Last Price Increase: 2025-02-03
Automatic offers:

allgandalf | Reviewer | 105980400
nkdengineer | Contributor | 105980401

Issue Owner

Current Issue Owner: @trjExpensify

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

issue also reproducible in Web

Proposal

Please re-state the problem that we are trying to solve in this issue.

The accounting software selection has blue border when redirected from OD.

What is the root cause of that problem?

When a row is selected, it's focused here

Then because CONST.INNER_BOX_SHADOW_ELEMENT label is true

App/src/components/SelectionList/BaseListItem.tsx

Line 98 in c30c298

    
           dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}

The blue border is displayed based on this style.

App/web/index.html

Lines 68 to 80 in c30c298

    
           :focus-visible[data-inner-box-shadow-element]{ 
        
               overflow: hidden; 
        
           } 
        
           :focus-visible[data-inner-box-shadow-element]::before { 
        
               content: ''; 
        
               position: absolute; 
        
               top: 0; 
        
               left: 0; 
        
               right: 0; 
        
               bottom: 0; 
        
               box-shadow: inset 0px 0px 0px 1px #5AB0FF; 
        
               pointer-events: none; 
        
               z-index: 1000;

What changes do you think we should make in order to solve the problem?

This bug also happens on other pages that use the selection list, which we don't navigate after selecting a row.

App/src/components/SelectionList/BaseListItem.tsx

Line 98 in c30c298

    
           dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}

This style is added here to fix the blue border style in ReportListItem so we can define a prop like shouldShowBlueBorderOnFoucs prop in BaseSelectionList with the default value is false

App/web/index.html

Lines 68 to 80 in c30c298

    
           :focus-visible[data-inner-box-shadow-element]{ 
        
               overflow: hidden; 
        
           } 
        
           :focus-visible[data-inner-box-shadow-element]::before { 
        
               content: ''; 
        
               position: absolute; 
        
               top: 0; 
        
               left: 0; 
        
               right: 0; 
        
               bottom: 0; 
        
               box-shadow: inset 0px 0px 0px 1px #5AB0FF; 
        
               pointer-events: none; 
        
               z-index: 1000;

Then we set the CONST.INNER_BOX_SHADOW_ELEMENT label to shouldShowBlueBorderOnFoucs.

dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: shouldShowBlueBorderOnFoucs}}

App/src/components/SelectionList/BaseListItem.tsx

Line 98 in c30c298

    
           dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}

Pass shouldShowBlueBorderOnFoucs as true here

App/src/components/SelectionList/Search/ReportListItem.tsx

Line 143 in 06549e5

<BaseListItem

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

We can remove the sync focus here. and remove shouldSyncFocus prop.

App/src/components/SelectionList/BaseListItem.tsx

Line 49 in c30c298

useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

I can repro:

Where did this regression come from? I'm surprised it hasn't cropped up on the @Expensify/design radar before now.

Job added to Upwork: https://www.upwork.com/jobs/~021878829529063238484

@allgandalf

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@allgandalf

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: selection has blue border when redirected from OD #56301

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

@allgandalf requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

@allgandalf

@allgandalf @trjExpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@allgandalf

👋 @allgandalf let's get the checklist in for tomorrow!

sure thing!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/50914/files#r1961027766
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

N/A

Test:

Go toexpensify.com
Select "Manage expenses for a small team" > Enter email > Tap Get started > Tap Join.
On ND, select any accounting software.

Verify that: The accounting software selection will not have blue border.

Do we agree 👍 or 👎

@trjExpensify

bring in those 💸 @trjExpensify

@allgandalf

Go toexpensify.com

🦶😆

Going to forgo the test on this as a visual display bug that should be caught in testing the onboarding flows.

Payment summary as follows:

$250 to @allgandalf for the C+ review
$250 to @nkdengineer for the PR

Paid, closing!

Navigation Menu

Repository navigation

[Due for payment 2025-02-19] [$250] mweb - Onboarding - Accounting software selection has blue border when redirected from OD #55145

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

52 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	:focus-visible[data-inner-box-shadow-element]{
	overflow: hidden;
	}
	:focus-visible[data-inner-box-shadow-element]::before {
	content: '';
	position: absolute;
	top: 0;
	left: 0;
	right: 0;
	bottom: 0;
	box-shadow: inset 0px 0px 0px 1px #5AB0FF;
	pointer-events: none;
	z-index: 1000;

[Due for payment 2025-02-19] [$250] mweb - Onboarding - Accounting software selection has blue border when redirected from OD #55145

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 13, 2025

mitarachim commented on Jan 13, 2025

nkdengineer commented on Jan 13, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

trjExpensify commented on Jan 13, 2025

melvin-bot commented on Jan 13, 2025

melvin-bot commented on Jan 13, 2025

52 remaining items

melvin-bot commented on Feb 12, 2025

melvin-bot commented on Feb 12, 2025

melvin-bot commented on Feb 12, 2025

trjExpensify commented on Feb 18, 2025

allgandalf commented on Feb 19, 2025

allgandalf commented on Feb 19, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

allgandalf commented on Feb 19, 2025

trjExpensify commented on Feb 19, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions