Skip to content

Search - Blue border on the group expense is cut off when the expense is selected #50914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 7 commits into from
Oct 29, 2024
Merged

Search - Blue border on the group expense is cut off when the expense is selected #50914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
699acb1
Fix cuting blue border
shahinyan11 Oct 16, 2024
eb511fd
Change style name
shahinyan11 Oct 16, 2024
5c3fe16
Revert prev changes and implement new solution
shahinyan11 Oct 25, 2024
3609f22
Pull main
shahinyan11 Oct 25, 2024
09b1e87
Add new dataSet in BaseListItem
shahinyan11 Oct 25, 2024
17a4a5e
run prettier
shahinyan11 Oct 25, 2024
665b815
Updates to fix square corners
shahinyan11 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4186,6 +4186,7 @@ const CONST = {
// The attribute used in the SelectionScraper.js helper to query all the DOM elements
// that should be removed from the copied contents in the getHTMLOfSelection() method
SELECTION_SCRAPER_HIDDEN_ELEMENT: 'selection-scrapper-hidden-element',
INNER_BOX_SHADOW_ELEMENT: 'inner-box-shadow-element',
MODERATION: {
MODERATOR_DECISION_PENDING: 'pending',
MODERATOR_DECISION_PENDING_HIDE: 'pendingHide',
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function BaseListItem<TItem extends ListItem>({
role={CONST.ROLE.BUTTON}
hoverDimmingValue={1}
hoverStyle={[!item.isDisabled && styles.hoveredComponentBG, hoverStyle]}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}

@allgandalf allgandalf Feb 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't had assumed value to be true, this caused #55145

onMouseDown={(e) => e.preventDefault()}
id={keyForList ?? ''}
style={pressableStyle}
Expand Down
14 changes: 14 additions & 0 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@
outline: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
}
:focus-visible[data-inner-box-shadow-element]{
overflow: hidden;
}
:focus-visible[data-inner-box-shadow-element]::before {
content: '';
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
pointer-events: none;
z-index: 1000;
}
:focus[data-focusvisible-polyfill] {
outline: 0;
box-shadow: inset 0px 0px 0px 1px #5AB0FF;
Expand Down