Search - Blue border on the group expense is cut off when the expense is selected by shahinyan11 · Pull Request #50914 · Expensify/App

shahinyan11 · 2024-10-16T14:24:37Z

Details

Fixed Issues

$ #50316
PROPOSAL: #50316 (comment)

Tests

Go to staging.new.expensify.com
Submit two expenses to any user.
Go to Search > Outstanding.
Use keyboard to navigate to the group expense in Step 2.
Select an expense via checkbox.

Verify that no errors appear in the JS console

Offline tests

Same as in the Tests section.

QA Steps

Same as in the Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (Reported here)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Untitled.mov

MacOS: Desktop

Untitled.mov

melvin-bot · 2024-10-16T14:24:44Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shahinyan11 · 2024-10-16T15:14:06Z

@rayane-djouah There are console errors when going to the search screen, but they are not related to our changes.

shahinyan11 · 2024-10-16T15:17:29Z

@rayane-djouah I don't provide videos for native platforms as this case is not relevant for them.

shahinyan11 · 2024-10-16T17:18:43Z

I found a case where the the top border is cut off. It happens only when the item is first in list.

We can solve this problem by adding paddingTop: 1 to contentContainerStyle of the SectionList here. What do you think about it @shawnborton @rayane-djouah

shawnborton · 2024-10-16T17:55:33Z

Hmm I'm not the biggest fan of adding 1px of padding just to account for this.

shahinyan11 · 2024-10-16T18:50:33Z

@shawnborton The I can suggest another solution, But it is different from the changes that I added in my proposal .

We can add below style in here. This ensures that the container's inner shadow is not obscured by its children, even if the children are 100% wide and tall.

        :focus-visible::before {
            content: '';
            position: absolute;
            top: 0;
            left: 0;
            right: 0;
            bottom: 0;
            box-shadow: inset 0px 0px 0px 1px #5AB0FF;
            pointer-events: none;
            z-index: 1;
        }

shawnborton · 2024-10-17T08:33:50Z

Can you share a screenshot/video of what that looks like? Thanks!

shahinyan11 · 2024-10-17T14:11:52Z

Can you share a screenshot/video of what that looks like? Thanks!

It works fine in our case but I have tested and found regression in other places. So that i updated it like below to avoid regress

  :focus-visible[data-selection-scrapper-hidden-element]::before {
      content: '';
      position: absolute;
      top: 0;
      left: 0;
      right: 0;
      bottom: 0;
      box-shadow: inset 0px 0px 0px 1px #5AB0FF;
      pointer-events: none;
      z-index: 1;
  }

Screen.Recording.2024-10-17.at.19.00.49.mov

rayane-d · 2024-10-23T00:03:27Z

@shahinyan11 Wouldn't having a clickable element with a z-index greater than 1 be a problem, since the focus-visible highlight is at z-index 1?

shahinyan11 · 2024-10-23T08:34:25Z

@shahinyan11 Wouldn't having a clickable element with a z-index greater than 1 be a problem, since the focus-visible highlight is at z-index 1?

@rayane-djouah Do you mean that in this case the blue frame might be cut off, or the clickable element might not work?If so, I have tested both cases and they work.

rayane-d · 2024-10-23T21:26:30Z

in this case the blue frame might be cut off

@shahinyan11 - Yes, that's what I mean. Perhaps we can use a larger z-index value, such as 1000? What do you think?

shahinyan11 · 2024-10-23T21:29:42Z

@rayane-djouah Yes we can. I agree with you

rayane-d · 2024-10-23T21:31:30Z

@shahinyan11 Can we apply this style only to the listItemPressableStyle?

shahinyan11 · 2024-10-23T21:38:05Z

@shahinyan11 Can we apply this style only to the listItemPressableStyle?

We can't apply this style to listItemPressableStyle object. But we can add this style.for specific componemt by using dataSet prop

rayane-d · 2024-10-23T21:47:20Z

@shahinyan11 That sounds good to me. I prefer applying this style to the list items only to avoid any potential regressions.
Could you apply these changes? Thanks!

shahinyan11 · 2024-10-23T22:02:23Z

@rayane-djouah the implementation provided here works onlily for BaseListItem component

shahinyan11 · 2024-10-24T07:38:12Z

@rayane-djouah Do you approve the changes in this comment?

rayane-d · 2024-10-27T22:15:39Z

@shahinyan11 We need to apply dataSet={{[CONST.INNER_BOX_SHADOW_ELEMENT]: true}} to the inner view here:

App/src/components/SelectionList/BaseListItem.tsx

Line 105 in 5103b4b

This should be done instead of applying it to the pressable. This is because the blue border is currently square and does not follow the rounded corners of the list item, as shown in the screenshot below:

After making the change, it should look like this:

shahinyan11 · 2024-10-28T13:05:40Z

@rayane-djouah Thanks for raising the problem, but your suggested variant do not work as expected. I made other changes to fix square corners

rayane-d · 2024-10-28T20:31:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

Screen.Recording.2024-10-28.at.9.27.42.PM.mov

Screen.Recording.2024-10-28.at.9.29.45.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-28.at.9.22.09.PM.mov

rayane-d

LGTM and tests well 👍

shawnborton · 2024-10-29T09:18:47Z

Screenshots look good from a design perspective 👍

OSBotify · 2024-10-29T13:29:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-31T11:40:27Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-04T14:13:11Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

allgandalf · 2025-02-19T06:33:28Z

                hoverDimmingValue={1}
                hoverStyle={[!item.isDisabled && styles.hoveredComponentBG, hoverStyle]}
-                dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
+                dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true, [CONST.INNER_BOX_SHADOW_ELEMENT]: true}}


We shouldn't had assumed value to be true, this caused #55145

Fix cuting blue border

699acb1

melvin-bot Bot requested review from rayane-d and removed request for a team October 16, 2024 14:24

shawnborton reviewed Oct 16, 2024

View reviewed changes

Comment thread src/styles/index.ts Resolved

Change style name

eb511fd

shahinyan11 added 2 commits October 25, 2024 16:39

Revert prev changes and implement new solution

5c3fe16

Pull main

3609f22

rayane-d suggested changes Oct 25, 2024

View reviewed changes

Comment thread web/index.html Resolved

shahinyan11 added 2 commits October 25, 2024 18:57

Add new dataSet in BaseListItem

09b1e87

run prettier

17a4a5e

Updates to fix square corners

665b815

rayane-d approved these changes Oct 28, 2024

View reviewed changes

melvin-bot Bot requested a review from arosiclair October 28, 2024 20:31

arosiclair approved these changes Oct 29, 2024

View reviewed changes

arosiclair merged commit ac4dc92 into Expensify:main Oct 29, 2024

github-actions Bot mentioned this pull request Oct 31, 2024

Deploy Checklist: New Expensify 2024-10-31 #51778

Closed

melvin-bot Bot mentioned this pull request Nov 4, 2024

[HOLD for payment 2024-11-11] [$250] Search - Blue border on the group expense is cut off when the expense is selected #50316

Closed

2 of 6 tasks

allgandalf reviewed Feb 19, 2025

View reviewed changes

Conversation

shahinyan11 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 16, 2024

Uh oh!

shahinyan11 commented Oct 16, 2024

Uh oh!

shahinyan11 commented Oct 16, 2024

Uh oh!

Uh oh!

shahinyan11 commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Oct 16, 2024

Uh oh!

shahinyan11 commented Oct 16, 2024

Uh oh!

shawnborton commented Oct 17, 2024

Uh oh!

shahinyan11 commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Oct 23, 2024

Uh oh!

shahinyan11 commented Oct 23, 2024

Uh oh!

rayane-d commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahinyan11 commented Oct 23, 2024

Uh oh!

rayane-d commented Oct 23, 2024

Uh oh!

shahinyan11 commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Oct 23, 2024

Uh oh!

shahinyan11 commented Oct 23, 2024

Uh oh!

shahinyan11 commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rayane-d commented Oct 27, 2024

Uh oh!

shahinyan11 commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Oct 28, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Oct 29, 2024

Uh oh!

OSBotify commented Oct 29, 2024

Uh oh!

github-actions Bot commented Oct 31, 2024

Uh oh!

github-actions Bot commented Nov 4, 2024

Uh oh!

allgandalf Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

shahinyan11 commented Oct 16, 2024 •

edited

Loading

shahinyan11 commented Oct 16, 2024 •

edited

Loading

shahinyan11 commented Oct 17, 2024 •

edited

Loading

rayane-d commented Oct 23, 2024 •

edited

Loading

shahinyan11 commented Oct 23, 2024 •

edited

Loading

shahinyan11 commented Oct 24, 2024 •

edited

Loading

shahinyan11 commented Oct 28, 2024 •

edited

Loading