Repository navigation
Deploy Checklist: New Expensify 2024-10-31 #51778
Description
Release Version: 9.0.56-9
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [Android / iOS] Code blocks are overflowing the app border #44953
- fix: Remove GBR from the account settings on initial signup. #49004
- [No QA] Enable Fast Refresh for Web and Desktop Platforms #49181
- Bank account verification modal info #49536
- Write platform specific mute settings to backend #50493
- Invoicing details section #50571
- Localize memoize #50698
- fix: Subject of the room briefly displayed as json string #50838
- Search - Blue border on the group expense is cut off when the expense is selected #50914
- Add limit value for expensify card #50985
- Bump expensify-common to 2.0.101 #51073
- feat: create upload picker component #51104
- [Major]: Refactor Netsuite Custom Field From to save draft values and save screen state #51109
- add extra css selector to global autofill style -add css class to the… #51117
- fix negative amount #51122
- change background color of focus element #51158
- fix owner tooltip for expense reports #51180
- [NoQA] e2e: add AWS retries #51182
- Add regex to TextInput #51202
- fix: expense is shown when sending send invoice #51217
- Provide autocomplete suggestions in SearchRouterList #51237
- fix: saved search name is blank after clearing name field #51305
- iOS - Hybrid app - Split - Cursor jumps in front of digit when deleting participant's amount #51306
- Fix some bugs on Bank account Flow #51315
- Don't dismiss modal after workspace upgrade for approval case #51379
- Fix emoji is cut off when the message has emoji and mention only #51380
- Fix able to dismiss onboarding flow with going back #51382
- fix ensure category is grayed out and name is updated when modified o… #51390
- Feat/50699 loading state for provisioning policy #51407
- Add comment text update by edit comment #51422
- [NO QA] Fix notifications for HybridApp deeplinks PR #51429
- Update en.ts #51442
- fix: navigate back in export page #51446
- [NOQA] remove redundant performance tests #51461
- [NoQA] Added Workspace_Downgrade route #51518
- Fix receipt disappears when dismissing distance editor after receipt is generated #51519
- fix report preview optimistic actorAccountID #51534
- fix authenticator app link #51535
- fix: prevent open search when onboarding is not completed #51547
- fix: hide "saved" text when deleting saved search #51549
- [Workspace Feeds] Use %bank% cards #51559
- [Custom feeds] The freeform fields limit #51569
- Fix - Track expense - Edited amount is not reflected correctly in amount editor on confirmation page #51579
- Update Connect-to-QuickBooks-Online.md #51589
- Fix formatting on image in help article #51604
- Update Send-and-Receive-Payment-for-Invoices help article with images #51629
- fix: Unable to select payment option in the dropdown in expense preview in the main chat #51645
- [No QA] Add Per Diem Beta #51646
- [NoQA] Update the channel name for slack announcements #51652
- feat: add timer on validate code action modal #51663
- [No QA]Update and rename Billing-page-coming-soon.md to Billing-page.md #51668
- Fix search for report to mention #51686
- [No QA] Update Configure-Xero.md #51691
- Update PR template
DetailstoExplanation of Change, update instructions #51692 - Update Standard.md #51698
- [NoQA] Change generated artifact name in the Android build action #51720
- [Search] Handle approving and paying money requests on search #51727
- [NoQA] fix: take last version of the code for e2e tests #51734
- [No QA] chore: use
react-native-app-logsfromnpm#51740 - [No QA] Bump eslint-config-expensify version (boolean-conditional-rendering rule) #51741
- improve handling of commas and special characters #51743
- [NoQA] Increase Jest test timeout #51745
- [ImgBot] Optimize images #51748
- [NoQA] fix: fetch main only if we are not on main #51751
- Update en.ts #51758
- Update en.ts #51760
- [No QA]Fix Android submission and asset naming for deploy #51766
- Images for Personal and Corp Karma help article #51774
- [CP Staging] Revert "Merge pull request #51158 from nkdengineer/fix/50779" #51795
- Revert "fix ensure category is grayed out and name is updated when modified o…" #51829
- [CP Staging] fix: remove unnecessary condition #51848
- [CP Staging] Revert "Fix some bugs on Bank account Flow" #51857
- [No QA]Use explicit
app_identifierto prevent build errors #51873 - [CP Stag] Add cycle detection to getRootParentReport #51879
- [No QA] Remove
app_identifierfrombuild_app#51889 - [CP Staging] fix: cannot display description which contains only number #51943
Deploy Blockers:
- Web - Search - Group expense box is not highlighted evenly when selected by keyboard #51784
- Distance - Receipt briefly shows placeholder after receipt is generated #51785
- Group chat - Selected user is highlighted after clicking Add to group #51786
- Workspace - Item (member, category, tag etc) in focus has two shades when selected by keyboard #51788
- [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] Room – Unable to save room description with numbers only #51789
- GBR - No GBR on settings avatar, profile and contact method #51792
- [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] Validate account - Need to click "Didn't receive a magic code?" twice to restart timer #51797
- Bank account - Almost done screen shown briefly when coming from choose an account page #51799
- [HOLD for payment 2024-11-14] [$250] Splitting 9000 with 4 users, the confirmation page incorrectly displays the participant amounts as 0. #51800
- [HOLD 49931] Expensify Card - Empty state screen not visible and issue card button and settings shown #51801
- [HOLD for payment 2024-11-14] [$250] Can't edit the participant amounts on the confirmation page. #51802
- [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] Workspace - categories edited online are greyed out in settings when offline #51812
- Expensify Card - Clicking on the bank account on a new workspace does nothing at first #51813
- Expensify card - Success screen shown instead of list accounts and no One more step screen #51819
- mWeb - BA - On tapping "next" in manually enter bank account page, user directed to continue setup #51823
- [HOLD for payment 2024-11-13][$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError #51853
- Bank Account - Validating account with wrong numbers takes you to "Connect Bank Account" #51854
- [HOLD App#52252] [$250] [Workspace Feeds] Company Cards - Unable to remove card feed that's under review #51858
- [HOLD for payment 2024-11-18] [Workspace feeds] Company Cards - Bank name persists between different banks in the Other card feed #51860
- Invoices - Unable to update company name and website #51871
- Invoices - Unable to send invoice if the company info is entered in Invoices settings first #51872
- [HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page #51883
- [Waiting on checklist] [$250] Expensify Card - Verifying page does not show offline indication when user is offline #51885
- Hybrid app - Android - Workspace - On new account, previous account WS appear while submitting expense #51928
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Oct 31, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.56-0 🚀
grgia commentedon Oct 31, 2024
Demoted #51799
kavimuru commentedon Nov 1, 2024
Regression is 28% left
Unchecked PRs:
Android Hybrid app is not available yet. So all the android slots are still pending.
#51390 is reverted. Should we verify this PR?
Beamanator commentedon Nov 1, 2024
@kavimuru do you have access to the latest android hybrid app by now? I think i see that y'all should have access to 9.0.56.2
Beamanator commentedon Nov 1, 2024
checking off #51792 as expected, not a bug
izarutskaya commentedon Nov 1, 2024
Regression is at 90 % completed
PRs:
#49536 - Failing with #51801
#51390 - KI found #51812
#51407 - Failing with #51819
#51422 - Found KI #51825
#51645 - KI #51312
#51663 - Failing with #51797
Blockers:
#51784
#51786
#51788
#51789
#51797
#51813
#51819
#51823
kavimuru commentedon Nov 1, 2024
@Beamanator Hybrid app is updated and we are working on android slots too.
kavimuru commentedon Nov 1, 2024
Regression completed
Unchecked PRs:
#49536 - Failing with #51801
#50698 - Failing with #51577 and #50194 KI is not fixed in all the platforms
#51390 failing with #50563 #51390 (comment)
#51117 - is blocked in Desktop with #10107 (comment) Ok to check it off
#51217 failing with #51872
#51407 - Failing with #51819
#51663 - Failing with #51797
Blockers:
#51784
#51786
#51788
#51789
#51797
#51813
#51823
#51853
#51854
#51858
#51860
#51871
#51872
#51885
Beamanator commentedon Nov 4, 2024
Checking off #51784, #51788, and #51786 as fixed by #51795
Beamanator commentedon Nov 4, 2024
Checkin off #51797 as fixed by #51848
Beamanator commentedon Nov 4, 2024
Checking off #51789 as fixed by #51943
Julesssss commentedon Nov 4, 2024
Checking off #51885 as not a blocker
Julesssss commentedon Nov 4, 2024
Checking off #51871.
Julesssss commentedon Nov 4, 2024
Also downgrading #51872, Invoicing is a brand new feature
Julesssss commentedon Nov 4, 2024
Downgrading #51860 as it's an incredibly minor issue.
Julesssss commentedon Nov 4, 2024
#51853 was fixed by #51879
Julesssss commentedon Nov 4, 2024
#51813 is also being downgraded as it is a minor UI issue, and will be fixed by a separate PR that is in progress.
Julesssss commentedon Nov 4, 2024
I'm just awaiting testing on this issue, which should have been fixed by a CP. Details below on the others I checked off:
Issue fixed.
Issue was closed as will not fix.
Marked not blockers
Yep I agree with closing as expected behaviour
Issue was marked not a blocker
Issue was closed as dupe
Fixed.
Julesssss commentedon Nov 4, 2024
Final blocker marked not-reproducable 🎉
Julesssss commentedon Nov 4, 2024
Julesssss commentedon Nov 4, 2024