[NJ-2020]

Details

In this PR we decided to match a room name if they are preceded by newline/space.

Fixed Issues

$ #46299
PROPOSAL: #46299 (comment)

Tests

1. Open Expensify App
2. Navigate to any chat e.g. a workspace chat.
3. Enter the message #4856₹&_#7553 in composer and verify that only #4856 is highlighted.
4. Send the message and verify that the Concierge message mentions only #4856 for room creation.
5. Repeat Steps (2) and (3) and verify the expected result:
   a. Message: #gh4h_+&&&-#ehhh, Expected Result: Only #gh4h
   b. Message: #4856₹& #7553, Expected Result: #4856 and #7553
   c. Message: #4856₹&
#7553, Expected Result: #4856 and #7553
   d. Message: #4856₹&*#7553, Expected Result: Only #4856
   e. Message: #4856₹&~#7553, Expected Result: Only #4856
   f. Message: #4856₹& *#7553, Expected Result: #4856 and #7553
   g. Message: #4856₹& ~#7553, Expected Result: #4856 and #7553
   h. Message: #4856₹&
*#7553, Expected Result: #4856 and #7553
   i. Message: #4856₹&
~#7553, Expected Result: #4856 and #7553
   j. Message: #4856₹&
_#7553, Expected Result: #4856 and #7553
   k. Message: #4856₹&
-#7553, Expected Result: Only #4856
   l. Message: #room-name123, Expected Result: #room-name123
   m. Message: https://abc.com/abc#qwer, Expected Result: Nothing is highlighted

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-26.at.05.25.42.mov

Android: mWeb Chrome

Screen.Recording.2024-10-26.at.06.40.54.mov

iOS: Native

Screen.Recording.2024-10-26.at.05.55.43.mov

iOS: mWeb Safari

Screen.Recording.2024-10-26.at.06.25.36.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-26.at.04.51.17.mov

MacOS: Desktop

Screen.Recording.2024-10-26.at.04.56.52.mov

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[rojiphil]

@NJ-2020 The version bump from 0.1.164 to 0.1.173 for the live-markdown library would also introduce other changes along with ours. Let us hold until the E/App PR comes up here.

Meanwhile can you please upload test videos on all platforms as required by the PR author checklist? Thanks.

[NJ-2020]

@rojiphil Okay thank you

[Skalakid]

Here is the PR with the Live Markdown library bump, where we will address all the regressions that may appear

[Skalakid]

The PR with the Live Markdown bump has been merged

[rojiphil]

The PR with the Live Markdown bump has been merged

Ah! Nice. Thanks @Skalakid.

@NJ-2020 We can take this off hold. Also, #50990 has bumped the expensify-common version to 2.0.100. That means we only have to bump the version to 2.0.101 so that it matches the one in parser\dependencies in expensify-live-markdown.
Can you please merge with the latest main, make the above change, and upload the test videos for all platforms?

[NJ-2020]

@rojiphil Okay, will do

[rojiphil]

Okay, will do

@NJ-2020 Can you please give an ETA for this as the issue does not deserve to be on-hold?

[NJ-2020]

@rojiphil Sorry for the delay, Done

[rojiphil]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

51073-web-safari-002.mp4

Android: Native

51073-android-native-001.mp4

iOS: mWeb Safari

51073-mweb-safari-001.mp4

Android: mWeb Chrome

51073-mweb-chrome-001.mp4

iOS: Native

51073-ios-native-001.mp4

MacOS: Desktop

51073-desktop-001.mp4

[rojiphil]

@NJ-2020 Thanks. I think being more specific in test cases as shown below can help the QA better:

1. Navigate to any chat e.g. a workspace chat.
2. Enter the message #4856₹&_#7553 in composer and verify that only #4856 is highlighted.
3. Send the message and verify that the Concierge message mentions only #4856 for room creation.
4. Repeat Steps (2) and (3) and verify the expected result:
   a. Message: #gh4h_+&&&-#ehhh, Expected Result: Only #gh4h
   b. Message: #4856₹& #7553, Expected Result: #4856 and #7553
   c. Message: #4856₹&
#7553, Expected Result: #4856 and #7553
   d. Message: #4856₹&*#7553, Expected Result: Only #4856
   e. Message: #4856₹&~#7553, Expected Result: Only #4856
   f. Message: #4856₹& *#7553, Expected Result: #4856 and #7553
   g. Message: #4856₹& ~#7553, Expected Result: #4856 and #7553
   h. Message: #4856₹&
*#7553, Expected Result: #4856 and #7553
   i. Message: #4856₹&
~#7553, Expected Result: #4856 and #7553
   j. Message: #4856₹&
_#7553, Expected Result: #4856 and #7553
   k. Message: #4856₹&
-#7553, Expected Result: Only #4856
   l. Message: #room-name123, Expected Result: #room-name123
   m. Message: https://abc.com/abc#qwer, Expected Result: Nothing is highlighted

@Beamanator @rlinoz This PR ensures that the changes in expensify-common PR and react-native-live-markdown PR are working as expected.
Changes LGTM and works well too.
Over to you for review. Thanks.

[NJ-2020]

I think being more specific in test cases as shown below can help the QA better

Done, thank you

[Beamanator]

NAB: Why this change? 🤷

[NJ-2020]

Ohh sorry, done

[Beamanator]

thanks for updating!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫