You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-03] mWeb - Reports - Navigation bar is displayed above keyboard when tapping on search input. #57170
Please re-state the problem that we are trying to solve in this issue.
Navigation bar moves above the keyboard when tapping on the search input on "Reports" section.
What is the root cause of that problem?
On mweb, the content will automatically push above the keyboard, we can refer the same behavior on chat
What changes do you think we should make in order to solve the problem?
When showing the search router list open, we shouldn't show the bottom tab bar. We already hide the bottom tab bar when click search icon on the header to open search modal
I think we can so the same here, but the Search page in this case is not the modal so
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can detect the keyboard is open to hide the BottomTabBar. On native we can use useKeyboardState hook, but on mweb platform we have to use the workaround to detect the keyboard is open or not.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@dylanexpensify@SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 20, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Feb 20, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Navigation bar moves above the keyboard when tapping on the search input on "Reports" section.
What is the root cause of that problem?
On mweb, the content will automatically push above the keyboard, we can refer the same behavior on chat
What changes do you think we should make in order to solve the problem?
When showing the search router list open, we shouldn't show the bottom tab bar. We already hide the bottom tab bar when click search icon on the header to open search modal
I think we can so the same here, but the Search page in this case is not the modal so
SHOULD_HIDE_BOTTOM_TAB_BARSearchPageNarrowTopLevelBottomTabBarWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
We can detect the keyboard is open to hide the
BottomTabBar. On native we can useuseKeyboardStatehook, but on mweb platform we have to use the workaround to detect the keyboard is open or not.Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Feb 25, 2025
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?
dylanexpensify commentedon Feb 26, 2025
@trjExpensify is this expected irt bottom tabs lifting with the keyboard?
trjExpensify commentedon Feb 26, 2025
No, not AFAIK. CC: @Expensify/design
dannymcclain commentedon Feb 26, 2025
Definitely not!
shawnborton commentedon Feb 26, 2025
Agree!
shawnborton commentedon Feb 26, 2025
cc @luacmartins - another Search bug we should have the agency follow up on.
luacmartins commentedon Feb 26, 2025
@SzymczakJ @Kicu if you wanna take this one on
SzymczakJ commentedon Feb 28, 2025
@luacmartins I could do it as a part of follow up as it's basically a bug introduced by me 😅
39 remaining items
melvin-bot commentedon Mar 27, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 27, 2025
@luacmartins @dylanexpensify @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 2, 2025
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.dylanexpensify commentedon Apr 2, 2025
Hi @miljakljajic, I'll be OOO during this time! Would you mind finishing the payment here when due?? TY! 🙇♂
SzymczakJ commentedon Apr 2, 2025
The PR fixing this was merged, I think we can close this one.
trjExpensify commentedon Apr 2, 2025
@SzymczakJ I take it Kevin is being paid on the OG issue as this was a follow-up/regression?
luacmartins commentedon Apr 2, 2025
Yea, that sounds correct to me