Skip to content

[Due for payment 2025-04-03] mWeb - Reports - Navigation bar is displayed above keyboard when tapping on search input. #57170

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): ibellicotest+282@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Search

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Tap on "Reports" on the bottom of the screen.
  3. Tap on "Search for something"
  4. Check the navigation bar´s behaviour when keyboard is opened.

Expected Result:

Navigation bar should remain hidden behind keyboard when tapping on the search input.

Actual Result:

Navigation bar moves above the keyboard when tapping on the search input on "Reports" section.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6748775_1740038914890.Nav.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 20, 2025
  2. melvin-bot commented on Feb 20, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Feb 20, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Navigation bar moves above the keyboard when tapping on the search input on "Reports" section.

    What is the root cause of that problem?

    On mweb, the content will automatically push above the keyboard, we can refer the same behavior on chat

    What changes do you think we should make in order to solve the problem?

    When showing the search router list open, we shouldn't show the bottom tab bar. We already hide the bottom tab bar when click search icon on the header to open search modal

    Image

    I think we can so the same here, but the Search page in this case is not the modal so

    1. Create the onyx SHOULD_HIDE_BOTTOM_TAB_BAR
    2. In SearchPageNarrow
    useEffect(()=>{
            if(searchRouterListVisible){
                Onyx.set(ONYXKEYS.SHOULD_HIDE_BOTTOM_TAB_BAR, true);
            }else{
                Onyx.set(ONYXKEYS.SHOULD_HIDE_BOTTOM_TAB_BAR, false);
            }
        },[searchRouterListVisible])
    
    1. In TopLevelBottomTabBar
        const [shouldHide] = useOnyx(ONYXKEYS.SHOULD_HIDE_BOTTOM_TAB_BAR);
    
    ...
    {!shouldHide && <BottomTabBar
    }
    

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    We can detect the keyboard is open to hide the BottomTabBar. On native we can use useKeyboardState hook, but on mweb platform we have to use the workaround to detect the keyboard is open or not.

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Feb 25, 2025

    @melvin-bot

    @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

  5. dylanexpensify commented on Feb 26, 2025

    @dylanexpensify
    Contributor

    @trjExpensify is this expected irt bottom tabs lifting with the keyboard?

  6. trjExpensify commented on Feb 26, 2025

    @trjExpensify
    Contributor

    No, not AFAIK. CC: @Expensify/design

  7. dannymcclain commented on Feb 26, 2025

    @dannymcclain
    Contributor

    Definitely not!

  8. shawnborton commented on Feb 26, 2025

    @shawnborton
    Contributor

    Agree!

  9. shawnborton commented on Feb 26, 2025

    @shawnborton
    Contributor

    cc @luacmartins - another Search bug we should have the agency follow up on.

  10. luacmartins commented on Feb 26, 2025

    @luacmartins
    Contributor

    @SzymczakJ @Kicu if you wanna take this one on

  11. SzymczakJ commented on Feb 28, 2025

    @SzymczakJ
    Contributor

    @luacmartins I could do it as a part of follow up as it's basically a bug introduced by me 😅

  12. 39 remaining items

  13. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-03. 🎊

    For reference, here are some details about the assignees on this issue:

    • @SzymczakJ does not require payment (Contractor)
  14. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    @luacmartins @dylanexpensify @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. removed their assignment
    on Apr 2, 2025
  16. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 2, 2025
  17. melvin-bot commented on Apr 2, 2025

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  18. dylanexpensify commented on Apr 2, 2025

    @dylanexpensify
    Contributor

    Hi @miljakljajic, I'll be OOO during this time! Would you mind finishing the payment here when due?? TY! 🙇‍♂

  19. SzymczakJ commented on Apr 2, 2025

    @SzymczakJ
    Contributor

    The PR fixing this was merged, I think we can close this one.

  20. trjExpensify commented on Apr 2, 2025

    @trjExpensify
    Contributor

    @SzymczakJ I take it Kevin is being paid on the OG issue as this was a follow-up/regression?

  21. luacmartins commented on Apr 2, 2025

    @luacmartins
    Contributor

    Yea, that sounds correct to me

  22. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions