Repository navigation
Follow up for "add search input to mobile search page issue" #57191
Description
This is group issue for all the follow-ups of add search input to mobile search page issue PR.
What needs to be done?
- iOS - Search - Unable to double tap on the search field to highlight it
- design change - fadeIn/Out of the content
- design change - flicker of bookmark button
- boost Reports page performance [Due for payment 2025-04-03] Reports - Search input is slow to expand when opening the second time onward #57069
- Search autocomplete list not visible [CP Staging] fix blank area and status bar #57113 (comment)
- [Due for payment 2025-04-03] mWeb - Reports - Navigation bar is displayed above keyboard when tapping on search input. #57170
cc @luacmartins
Metadata
Metadata
Type
Projects
- Status
Activity
melvin-bot commentedon Feb 20, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 24, 2025
@luacmartins, @NicMendonca, @ikevin127, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!
SzymczakJ commentedon Feb 24, 2025
WIP, I started looking at the performance of Reports page.
SzymczakJ commentedon Feb 26, 2025
Update: I'm testing out an option to replace SelectionList(from our Search/index.tsx component) with a FlashList. Writing a small POC to check. if it's even doable and what performance gains it might give us.
SzymczakJ commentedon Feb 27, 2025
I've done measurements with React Native dev tools profiler:
I've measured the total count of react commits that are caused by navigating for the first time to Reports page and I also summed the total render time(plus time spent on running useEffects and useLayoutEffects)
These are the results:
Old version: total commits ~35, total time: ~4000 ms
New version using flash list: total commits: ~23-24, total time ~1500ms
Selection list implements many functionalities(and a lot of them are not performant) that Reports page doesn't need and that's the main reason using Flash list helps so much.
I don't have all of the functionalities implemented yet(like selecting items with arrows), so the total time of the new approach will be higher, but I still think this will be tremendous upgrade in the Reports page performance. WDYT of this @luacmartins. Migrating this fully will take some time(probably the draft should be ready next week), so I need your green light to continue 😄
32 remaining items
ikevin127 commentedon Mar 29, 2025
@NicMendonca No payment action required here for me, payment for #57191 (comment) will be handled in the regression issue where I'll get -50% of the bounty.
NicMendonca commentedon Apr 7, 2025
Not overdue
NicMendonca commentedon Apr 24, 2025
Not overdue
luacmartins commentedon May 5, 2025
I think everything here is done, right?
SzymczakJ commentedon May 6, 2025
It seems so, let's just close this.
luacmartins commentedon May 6, 2025
Thanks for the work everyone!