You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-14] Move attendees from Transaction type to Comment #57717
📣 @sibtain-ali-deel! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Okay. I delved into this today. Having attendees directly on transaction seems like a better option to me. Consider this piece of code. If we move attendees to comment, it'd be difficult to have it as pending.
As an example, we already have waypoints inside the Comment type, and modifiedWaypoints in Transaction. Can we mimic the same thing here for attendees?
@allroundexperts@sakluger@allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
I think it ended up being a larger task with more edge cases than initially expected, so I think it'd be fair to double it. Curious what you think @allroundexperts based on previous issues you've worked on.
I agree that this involved a lot more than we initially thought. Can we raise it to $750? Also, I am assuming here that the follow up issues would be separate than this one?
changed the title [-][Due for payment 2025-04-16] [Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/-][+][Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/+]on Apr 14, 2025
Activity
francoisl commentedon Mar 4, 2025
@allroundexperts this will be the first piece we need for https://expensify.slack.com/archives/C02NK2DQWUX/p1741128361803779?thread_ts=1741053521.226809&cid=C02NK2DQWUX, let me know if you have any questions!
allroundexperts commentedon Mar 5, 2025
Seems clear enough to me. Will try to raise a PR tomorrow!
melvin-bot commentedon Mar 6, 2025
📣 @sibtain-ali-deel! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
allroundexperts commentedon Mar 6, 2025
Okay. I delved into this today. Having attendees directly on transaction seems like a better option to me. Consider this piece of code. If we move attendees to comment, it'd be difficult to have it as pending.
francoisl commentedon Mar 6, 2025
Is that the only case that's hard to migrate?
As an example, we already have
waypointsinside theCommenttype, andmodifiedWaypointsinTransaction. Can we mimic the same thing here for attendees?francoisl commentedon Mar 7, 2025
@allroundexperts does that make sense?
53 remaining items
melvin-bot commentedon Apr 9, 2025
@allroundexperts @sakluger @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
allroundexperts commentedon Apr 9, 2025
I agree that this involved a lot more than we initially thought. Can we raise it to $750? Also, I am assuming here that the follow up issues would be separate than this one?
[-][Due for payment 2025-04-16] [Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/-][+][Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/+]sakluger commentedon Apr 14, 2025
Edited April 23, 2025 to add @fedirjh as C+
Summarizing payment on this issue:
Contributor: @allroundexperts $750, please request via NewDot
Contributor+: @fedirjh $750, please request on Newdot
fedirjh commentedon Apr 14, 2025
@francoisl Can you please assign me as C+ reviewer on #58120?
garrettmknight commentedon Apr 22, 2025
@sakluger can you update the payment summary?
sakluger commentedon Apr 23, 2025
Updated! Please reopen if any additional changes are needed.
garrettmknight commentedon May 2, 2025
$750 approved for @fedirjh
JmillsExpensify commentedon Jun 13, 2025
$750 approved for @allroundexperts