Skip to content

[Due for payment 2025-04-14] Move attendees from Transaction type to Comment #57717

Closed

Description

@francoisl

Problem

In #48008, an attendees prop was added to the Transaction type.

/** Selected attendees */
attendees?: Attendee[];

However, this is inconsistent with our backend, where attendees are stored inside the comment instead:

  • Example transaction with attendees set on Expensify Classic
    Image

  • Example if you set attendees from NewDot at the moment
    Image

Solution

  1. Move attendees from Transaction to Comment (i.e. this), and update everywhere we read/set transaction.attendees to transaction?.comment?.attendees
  2. Test creating an expense with attendees in Expensify Classic (OldDot), make sure attendees are displayed properly when opening the expense in NewDot

Notes for testing

  • To be able to see the attendees in NewDot, uncomment the commented code in shouldShowAttendees() (i.e. this)-
  • The backend changes to set and update attendees via New Expensify aren't complete yet, so create transactions with attendees from OldDot like so:
  1. Create a workspace in New Expensify
  2. Sign in to the same account on Classic (www.expensify.com or staging.expensify.com)
  3. Go to Expenses > New Expense > Manually Create
  4. Enter any merchant name, amount, date, and values in the Attendees selector
  5. Save the expense
  6. In NewDot, find and open the corresponding expense
  7. Make sure the attendees are displayed correctly

This is part of #44725

Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 4, 2025
  2. self-assigned this
    on Mar 4, 2025
  3. francoisl commented on Mar 4, 2025

    @francoisl
    ContributorAuthor
  4. allroundexperts commented on Mar 5, 2025

    @allroundexperts
    Contributor

    Seems clear enough to me. Will try to raise a PR tomorrow!

  5. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    📣 @sibtain-ali-deel! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  6. allroundexperts commented on Mar 6, 2025

    @allroundexperts
    Contributor

    Okay. I delved into this today. Having attendees directly on transaction seems like a better option to me. Consider this piece of code. If we move attendees to comment, it'd be difficult to have it as pending.

  7. francoisl commented on Mar 6, 2025

    @francoisl
    ContributorAuthor

    Is that the only case that's hard to migrate?

    As an example, we already have waypoints inside the Comment type, and modifiedWaypoints in Transaction. Can we mimic the same thing here for attendees?

  8. francoisl commented on Mar 7, 2025

    @francoisl
    ContributorAuthor

    @allroundexperts does that make sense?

  9. 53 remaining items

  10. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    @allroundexperts @sakluger @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. allroundexperts commented on Apr 9, 2025

    @allroundexperts
    Contributor

    I think it ended up being a larger task with more edge cases than initially expected, so I think it'd be fair to double it. Curious what you think @allroundexperts based on previous issues you've worked on.

    I agree that this involved a lot more than we initially thought. Can we raise it to $750? Also, I am assuming here that the follow up issues would be separate than this one?

  12. changed the title [-][Due for payment 2025-04-16] [Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/-] [+][Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`[/+] on Apr 14, 2025
  13. sakluger commented on Apr 14, 2025

    @sakluger
    Contributor

    Edited April 23, 2025 to add @fedirjh as C+

    Summarizing payment on this issue:

    Contributor: @allroundexperts $750, please request via NewDot
    Contributor+: @fedirjh $750, please request on Newdot

  14. fedirjh commented on Apr 14, 2025

    @fedirjh
    Contributor

    @francoisl Can you please assign me as C+ reviewer on #58120?

  15. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    @sakluger can you update the payment summary?

  16. sakluger commented on Apr 23, 2025

    @sakluger
    Contributor

    Updated! Please reopen if any additional changes are needed.

  17. garrettmknight commented on May 2, 2025

    @garrettmknight
    Contributor

    $750 approved for @fedirjh

  18. JmillsExpensify commented on Jun 13, 2025

    @JmillsExpensify
    Contributor

    $750 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions