Skip to content

[Awaiting Payment - 27th March] [$125] Bulk select button in the wrong place on the Reports page #57760

New issue
New issue
Closed
Closed
[Awaiting Payment - 27th March] [$125] Bulk select button in the wrong place on the Reports page#57760
Assignees
trjExpensifyluacmartinsjayeshmangwaniikevin127
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@trjExpensify
trjExpensify
opened on Mar 4, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): None, discovered when testing something else.

Action Performed:

  1. Go to the Reports page
  2. Select a couple of expenses

Expected Result:

The button should be beneath the router:

Image

Note: The colour should be green, ignore that.

Actual Result:

The button is inside the router:

Image

Workaround:

N/A, UI issue. The button still works.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

In-line.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021899852538789820773
  • Upwork Job ID: 1899852538789820773
  • Last Price Increase: 2025-03-20
Issue OwnerCurrent Issue Owner: @

Activity

  1. trjExpensify
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    DailyKSv2
    on Mar 4, 2025
  2. trjExpensify
    self-assigned this
    on Mar 4, 2025
  3. trjExpensify
    added this to #expensify-bugson Mar 4, 2025

  4. melvin-bot commented on Mar 4, 2025

    @melvin-bot
    melvin-botBot
    on Mar 4, 2025 – with Melvin Bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  5. trjExpensify commented on Mar 4, 2025

    @trjExpensify
    trjExpensify
    on Mar 4, 2025
    ContributorAuthor

    @SzymczakJ I believe you worked on this, right? CC: @luacmartins

  6. trjExpensify
    moved this to Bugs and Follow Up Issues in #expensify-bugson Mar 4, 2025

  7. JmillsExpensify commented on Mar 4, 2025

    @JmillsExpensify
    JmillsExpensify
    on Mar 4, 2025
    Contributor

    Ugh oh, design crimes have been committed.

  8. SzymczakJ commented on Mar 4, 2025

    @SzymczakJ
    SzymczakJ
    on Mar 4, 2025
    Contributor

    I'm guilty of it 😄. Assign me to this issue and I will link it to #57191. The performance PR is close to "ready for review" and after that the bulked design fixes will come.

  9. luacmartins
    assigned
    SzymczakJ
    and
    luacmartins
    on Mar 4, 2025

  10. trjExpensify commented on Mar 4, 2025

    @trjExpensify
    trjExpensify
    on Mar 4, 2025
    ContributorAuthor

    Haha, sounds good!

  11. melvin-bot
    added
    Overdue
    on Mar 7, 2025

  12. trjExpensify commented on Mar 7, 2025

    @trjExpensify
    trjExpensify
    on Mar 7, 2025
    ContributorAuthor

    Should we tap a C+ or someone for this @SzymczakJ, so you can focus on TradReports?

  13. melvin-bot
    removed
    Overdue
    on Mar 7, 2025

  14. 54 remaining items

  15. trjExpensify
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Mar 20, 2025
  16. trjExpensify
    changed the title [-][$250] Bulk select button in the wrong place on the Reports page[/-] [+][Awaiting Payment - 27th March] [$125] Bulk select button in the wrong place on the Reports page[/+] on Mar 20, 2025

  17. melvin-bot commented on Mar 20, 2025

    @melvin-bot
    melvin-botBot
    on Mar 20, 2025 – with Melvin Bot

    Upwork job price has been updated to $125

  18. trjExpensify commented on Mar 20, 2025

    @trjExpensify
    trjExpensify
    on Mar 20, 2025
    ContributorAuthor

    Done!

  19. ikevin127 commented on Mar 26, 2025

    @ikevin127
    ikevin127
    on Mar 26, 2025
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No offending PR since the issue was raised because the initial implementation was the result of the original design (at the time).

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Note

    Mobile (narrow layout devices) UI was not changed, everything should look and work the same on narrow layouts.

    1. Go to the Reports page.
    2. Select a couple of expenses.
    3. Verify that the bulk select button placement follows the design as shown below.
    4. Verify that all dropdown functionality types work as expected on both wide and narrow layout devices on different types of selected expenses (download, hold, unhold, delete).

    ✅ Design updates (based on issue discussions)

    Dark theme
    dark
    Light
    light
    Popover open placement
    popover-placement

    ❌ How it looked before

    Do we agree 👍 or 👎.

    ☝ Markdown source snippet 
    > [!note]
> Mobile (narrow layout devices) UI was not changed, everything should look and work the same on narrow layouts.

1. Go to the Reports page.
2. Select a couple of expenses.
3. Verify that the bulk select button placement follows the design as shown below.
4. Verify that all dropdown functionality types work as expected on both wide and narrow layout devices on different types of selected expenses (download, hold, unhold, delete).

## ✅ Design updates (based on issue discussions)

| Dark theme |
| ------------- |
| <img width="1436" alt="dark" src="https://github.com/user-attachments/assets/a26c3ca4-b540-46a3-b2a8-ce8314d9b0e0" /> |

| Light |
| ------------- |
| <img width="1436" alt="light" src="https://github.com/user-attachments/assets/06f0201a-4ffb-45cb-9700-dad6e8838908" /> |

| Popover open placement |
| ------------- |
| <img width="911" alt="popover-placement" src="https://github.com/user-attachments/assets/8652bddc-f7c8-44cf-b1bc-44b1adf15a77" /> |

## ❌ How it looked before (from issue)

<img width="700" src="https://github.com/user-attachments/assets/08202be8-8eb3-4462-b8e8-346871c491ee">

  20. jayeshmangwani commented on Mar 27, 2025

    @jayeshmangwani
    jayeshmangwani
    on Mar 27, 2025
    Contributor

    @ikevin127 Thanks for taking care of the checklist.

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Mar 27, 2025

  22. trjExpensify commented on Mar 27, 2025

    @trjExpensify
    trjExpensify
    on Mar 27, 2025
    ContributorAuthor

    Payment summary as follows:

  23. ikevin127 commented on Mar 27, 2025

    @ikevin127
    ikevin127
    on Mar 27, 2025
    Contributor

    @trjExpensify Offer accepted, thank you!

  24. trjExpensify commented on Mar 27, 2025

    @trjExpensify
    trjExpensify
    on Mar 27, 2025
    ContributorAuthor

    Paid, closing!

  25. trjExpensify
    closed this as completedon Mar 27, 2025
  26. github-project-automation
    moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 27, 2025

  27. garrettmknight commented on Mar 31, 2025

    @garrettmknight
    garrettmknight
    on Mar 31, 2025
    Contributor

    $125 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions