Skip to content

[Due for payment 2025-03-21] Help panel - Get assistance and Help buttons have the same icon on invite member RHP #57808

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.9-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePaneExpanded', {}) in console.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workspace members.
  3. Click Invite member.

Expected Result:

Get assistance and Help icons will be distinctive.

Actual Result:

Get assistance and Help icons look the same.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761310_1741131111430.20250305_072741.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 5, 2025
  2. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 5, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 40 remaining items

  7. Christinadobrzyn commented on Mar 26, 2025

    @Christinadobrzyn
    Contributor

    Just a heads up that I'm going to be ooo March 27th - April 6th. Back on the 7th.

    I'm going to assign a BZ teammate to help with this if we need to pay here. cc @JmillsExpensify

    @brunovjk can you provide a summary of where we are with testing the regressions? Are we still planning on paying out here and not paying in this issue?

  8. removed their assignment
    on Mar 26, 2025
  9. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 26, 2025
  10. melvin-bot commented on Mar 26, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  11. brunovjk commented on Mar 26, 2025

    @brunovjk
    Contributor

    @Christinadobrzyn the payment will be handled here
    But I also wonder about the regression test. If I make one for each issue related or not

  12. Christinadobrzyn commented on Mar 26, 2025

    @Christinadobrzyn
    Contributor

    Thanks @brunovjk! Hum that is a good question. It looks like you've summarized the regressions here #59081 - right?

    I think that is a good plan to use #59081 as a summary of all the regression testing and also where you'll be paid. Let me know if I'm missing something!

  13. brunovjk commented on Mar 26, 2025

    @brunovjk
    Contributor

    Great!!! I will do that! Thank you!!!

  14. JmillsExpensify commented on Mar 26, 2025

    @JmillsExpensify
    Contributor

    Nice, so then what's the plan with this issue. Do we close it?

  15. brunovjk commented on Mar 26, 2025

    @brunovjk
    Contributor

    I think we can close. If is necessary I ask to reopen :D

  16. brunovjk commented on Mar 27, 2025

    @brunovjk
    Contributor

    I can't reproduce this anymore. Payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions