Skip to content

Deploy Checklist: New Expensify 2021-10-23 #6017

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2021-10-23#6017
Assignees
applausebot
Labels
MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Oct 23, 2021

Release Version: 1.1.10-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Oct 23, 2021
  2. OSBotify
    assigned
    applausebot
    on Oct 23, 2021

  3. roryabraham commented on Oct 23, 2021

    @roryabraham
    roryabraham
    on Oct 23, 2021
    Contributor

    There are many PRs that were added to this checklist that should not have been. This PR is a likely culprit. cc @stitesExpensify @Julesssss

  4. roryabraham
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    and removed
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Oct 25, 2021

  5. roryabraham commented on Oct 25, 2021

    @roryabraham
    roryabraham
    on Oct 25, 2021
    Contributor

    Actually I'm unlocking this again real quick just to test #6047, which will not affect the app itself at all.

  6. isagoico commented on Oct 26, 2021

    @isagoico
    isagoico
    on Oct 26, 2021

    @roryabraham Just to confirm, we're good to start QA now right? Not sure if you finished the testing from last night 😬 (All slots are setup on our side so we just need the 🟢 light to add the lock label)

  7. roryabraham commented on Oct 26, 2021

    @roryabraham
    roryabraham
    on Oct 26, 2021
    Contributor

    Glad you asked first, finishing up testing now...

  8. roryabraham commented on Oct 26, 2021

    @roryabraham
    roryabraham
    on Oct 26, 2021
    Contributor

    Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

  9. roryabraham
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Oct 26, 2021

  10. roryabraham commented on Oct 26, 2021

    @roryabraham
    roryabraham
    on Oct 26, 2021
    Contributor

    🟢

  11. isagoico commented on Oct 26, 2021

    @isagoico
    isagoico
    on Oct 26, 2021

    Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

    Beautiful 🥺 seems small but this will actually will make the PRs setup a lot easier! thanks a lot 🙇‍♀️

  12. MelvinBot
    added
    MonthlyKSv2
    on Oct 26, 2021

  13. roryabraham commented on Oct 27, 2021

    @roryabraham
    roryabraham
    on Oct 27, 2021
    Contributor

    #5955 Passed internal QA and has no accessibility testing needed, checking it off.

  14. isagoico commented on Oct 27, 2021

    @isagoico
    isagoico
    on Oct 27, 2021

    Regression is almost finished! Posting a summary of what has been found:

    Issues found:

    1. The field border is not red while the error "Please provide a valid Phone Number" is shown on the bottom page  #6071 - Closed 🎉 (was found while executing Added minimum phone number length #5938)
    2. Desktop - Blank screen appears when exiting the onfido page in IOU flow #6082
    3. Split bill - Text is distorted in Spanish #6078
    4. Split bill - When writing a comment, Who paid gets hidden #6077
    5. Web - Attachment - No magnifying glass seen when hoovered over image in chat #6075
    6. [HOLD for payment 2021-11-29] ipad - Signin - Blank color startup page appears in sign in screen #6070

    PRs left:

    Thanks!

  15. nickmurray47 commented on Oct 27, 2021

    @nickmurray47
    nickmurray47
    on Oct 27, 2021
    Contributor

    @isagoico Navigate to the Enable Payments Flow from within the Send Money Flow #5928 has a bug in it and I'm planning to deploy a fix to Staging

  16. roryabraham commented on Oct 27, 2021

    @roryabraham
    roryabraham
    on Oct 27, 2021
    Contributor

    Since Send Money is still behind a beta, I'm going to check off #6082 – it got demoted from deploy blocker to regular bug.

  17. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    #6086 has been fully deployed to staging, please QA it

  18. isagoico commented on Oct 28, 2021

    @isagoico
    isagoico
    on Oct 28, 2021

    I drafted a message that the regression was done a while ago and didn't hit comment.

    Regression is finished!

    One last issue was raised here #6085

    QAd PRs have been checked off.

  19. isagoico commented on Oct 28, 2021

    @isagoico
    isagoico
    on Oct 28, 2021

    #6086 was a pass! Checking it off 🎉

  20. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    #6085 is fixed, checking it off 🎉

  21. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    It seems like the following PRs still need QA:

  22. isagoico commented on Oct 28, 2021

    @isagoico
    isagoico
    on Oct 28, 2021

    My bad I must have missed checking off #4270. For #5828 I left a comment here, we were unable to verify step number 10 (https://expensify.slack.com/archives/C9YU7BX5M/p1635357929037000)

  23. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    Oof, looks like we've got a new blocker: #6097

  24. marcaaron commented on Oct 28, 2021

    @marcaaron
    marcaaron
    on Oct 28, 2021
    Contributor

    Tested internally and checking off #5828

  25. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    Solution to the last blocker is being deployed in 1.1.10-2 here.

  26. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    Confirmed #6097 is fixed in 1.1.10-2

  27. roryabraham commented on Oct 28, 2021

    @roryabraham
    roryabraham
    on Oct 28, 2021
    Contributor

    :shipit:

  28. roryabraham
    closed this as completedon Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions