You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment 2025-05-27] Room - "You appear to be offline" is displayed overlapping the "Create Room" button. #60377
Version Number: 9.1.29-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):ibellicotest+575@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome App Component: Other
Action Performed:
Prerequisite: User has at least one workspace created.
Open the staging.new.expensify.com website.
Turn off internet connection.
Tap on FAB and select "Start Chat"
Select "Room"
Open the keyboard if it is not opened yet.
Check the "You appear to be offline" message position after this action.
Expected Result:
"You appear to be offline" message, should be displayed above the "Create Room" button and not overlapping it.
Actual Result:
"You appear to be offline" button while creating a room conversation, is displayed overlapping the "Create Room" button when keyboard is opened.
It seems all kinds of messed up in this screens. Misaligned in the Chat tab, and then I can't get it to appear at all on the Room tab at all. Comparably on the confirm workspace page, I can see the same translucent background to peak the button behind it, so I'm wondering if that part is actually expected? CC: @Expensify/design
// Disable the focus trap of this page to activate the parent focus trap in `NewChatSelectorPage`.
focusTrapSettings={{active: false}}
testID={NewChatPage.displayName}
>
Note: we can do the same with other pages that have the same issue
Screen.Recording.2025-04-17.at.10.59.49.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Looking into it! I agree, that the translucent offline indicator is not the best choice for the "Start chat/room" page.
In general, the translucent offline indicator docked to the bottom was per-design, as this allows content to go below it and the navigation bar/gesture bar. We should probably disable the translucent offline indicator for screens with a bottom docked submit/confirm button though.
For this screen specifically, do we want to make the "Create room" button always stick to the bottom? Therefore removing it from the scrollable content, and only let the rest of the form scroll?
I think the main thing that trips me up is that I don't know why the offline indicator would ever be translucent - that's something we never had before. Can we just make the offline indicator opaque and call it a day?
Before, the offline indicator would always be opaque. The problem with that is that with the edge-to-edge bottom safe area handling, content can go below the navigation bar and gesture bar. If the offline indicator is opaque though, this would mean that whenever the user goes offline, we would need to basically "turn off" the edge-to-edge scrolling, because otherwise the content would go below an opaque offline indicator and then again under the translucent gesture bar.
I think the main thing that trips me up is that I don't know why the offline indicator would ever be translucent - that's something we never had before. Can we just make the offline indicator opaque and call it a day?
We've discussed this back here and i've received pretty broad consensus on the translucency. I think this is the cleanest approach to show the offline indicator while still being able to scroll content edge-to-edge.
The alternative - as described in the previous question - is to "turn off" the edge-to-edge scrolling by also disabling the navigation bar translucency, whenever the user is offline.
Looking into it! I agree, that the translucent offline indicator is not the best choice for the "Create room" page.
We can definitely turn this off for specific screens, where a different offline indicator placing is better, e.g. for the "Create room" page. As mentioned above, there is a isOfflineIndicatorTranslucent prop which turns of translucency.
In the specific case of "Create room" page, we would again place the offline indicator on top of the button though, i think that was the previous approach
changed the title [-]Room - "You appear to be offline" is displayed overlapping the "Create Room" button.[/-][+][Due for Payment 2025-05-27] Room - "You appear to be offline" is displayed overlapping the "Create Room" button.[/+]on May 20, 2025
Activity
melvin-bot commentedon Apr 16, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Apr 17, 2025
It seems all kinds of messed up in this screens. Misaligned in the
Chattab, and then I can't get it to appear at all on theRoomtab at all. Comparably on the confirm workspace page, I can see the same translucent background to peak the button behind it, so I'm wondering if that part is actually expected? CC: @Expensify/designScreenRecording_04-17-2025.01-24-55_1.MP4
dubielzyk-expensify commentedon Apr 17, 2025
Yeah that seems really broken. Surely we'd just wanna update the screen that's affected in the original bug
bernhardoj commentedon Apr 17, 2025
The translucent offline indicator background was added in #58507, so I think it's expected?
nkdengineer commentedon Apr 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"You appear to be offline" button while creating a room conversation, is displayed overlapping the "Create Room" button when keyboard is opened.
What is the root cause of that problem?
We don't add the
isOfflineIndicatorTranslucentprops toScreenWrapperinNewChatPageorWorkspaceNewRoomPageSo it'll show the background with the opacity is 0.8, and it feels like the offline indicator is overlapping on the button
App/src/components/ScreenWrapper.tsx
Line 373 in 5e7543e
What changes do you think we should make in order to solve the problem?
We should add
isOfflineIndicatorTranslucentprops toNewChatPageorWorkspaceNewRoomPageto usestyles.appBGas the backgroundApp/src/pages/workspace/WorkspaceNewRoomPage.tsx
Lines 237 to 246 in 5e7543e
App/src/pages/NewChatPage.tsx
Lines 334 to 342 in 5e7543e
Note: we can do the same with other pages that have the same issue
Screen.Recording.2025-04-17.at.10.59.49.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
shawnborton commentedon Apr 17, 2025
Agree we definitely should fix this. cc @chrispader in case this is related to some of the bottom SafeArea changes you had been working on?
shawnborton commentedon Apr 17, 2025
I personally don't think we want it to be translucent, I'm not sure why or how that happened.
chrispader commentedon Apr 17, 2025
Looking into it! I agree, that the translucent offline indicator is not the best choice for the "Start chat/room" page.
In general, the translucent offline indicator docked to the bottom was per-design, as this allows content to go below it and the navigation bar/gesture bar. We should probably disable the translucent offline indicator for screens with a bottom docked submit/confirm button though.
chrispader commentedon Apr 17, 2025
For this screen specifically, do we want to make the "Create room" button always stick to the bottom? Therefore removing it from the scrollable content, and only let the rest of the form scroll?
shawnborton commentedon Apr 17, 2025
What did it look like before your changes?
I think the main thing that trips me up is that I don't know why the offline indicator would ever be translucent - that's something we never had before. Can we just make the offline indicator opaque and call it a day?
chrispader commentedon Apr 17, 2025
Before, the offline indicator would always be opaque. The problem with that is that with the edge-to-edge bottom safe area handling, content can go below the navigation bar and gesture bar. If the offline indicator is opaque though, this would mean that whenever the user goes offline, we would need to basically "turn off" the edge-to-edge scrolling, because otherwise the content would go below an opaque offline indicator and then again under the translucent gesture bar.
We've discussed this back here and i've received pretty broad consensus on the translucency. I think this is the cleanest approach to show the offline indicator while still being able to scroll content edge-to-edge.
The alternative - as described in the previous question - is to "turn off" the edge-to-edge scrolling by also disabling the navigation bar translucency, whenever the user is offline.
cc @shawnborton @Expensify/design
Here are the screen recordings on Android again for reference:
Screen_Recording_20250314_172752_New.Expensify.Dev.mp4
Screen_Recording_20250314_172935_New.Expensify.Dev.mp4
chrispader commentedon Apr 17, 2025
We can definitely turn this off for specific screens, where a different offline indicator placing is better, e.g. for the "Create room" page. As mentioned above, there is a
isOfflineIndicatorTranslucentprop which turns of translucency.In the specific case of "Create room" page, we would again place the offline indicator on top of the button though, i think that was the previous approach
35 remaining items
melvin-bot commentedon May 20, 2025
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
trjExpensify commentedon May 20, 2025
Deployed to prod 8 hours ago. Adding the payment hold.
[-]Room - "You appear to be offline" is displayed overlapping the "Create Room" button.[/-][+][Due for Payment 2025-05-27] Room - "You appear to be offline" is displayed overlapping the "Create Room" button.[/+]trjExpensify commentedon May 23, 2025
Not overdue, awaiting regression period.
trjExpensify commentedon May 28, 2025
Going to close this issue then. All the payments will have been handled on the OG issue: #53186
hungvu193 commentedon May 29, 2025
@trjExpensify Do you think I'm eligible for payment here since I reviewed the PR, and this issue didn't come from PR I reviewed before?
trjExpensify commentedon May 30, 2025
Sorry man, bit confused. Weren't you paid over on the other issue?