You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD @ikevin127 NewDot payment] private domain onboarding check doesn't show for hybrid app iOS #61629
On latest iOS Hybrid App version the private domain onboarding check doesn't appear. This PR seems to make the private domain onboarding check reappear but it's throwing an error 404 Login not found or unauthorized when calling AddWorkEmail with a work email that is not connected to an existing account.
We need iOS HybridApp users to be able to use this feature. It also seems like revealing this feature might have exposed a iOS HybridApp specific bug.
Also let me know also if you think this should be considered follow up or not. I know we did have this working, so I'm open to paying this out separately if the root cause is something that we couldn't reasonably have caught in previous PRs.
which is merging onyx USER properties into ACCOUNT including isFromPublicDomain which is used in the onboarding flow to return the private domain onboarding route, but since the variable is currently undefined (both Native and HybridApp) due to the migration I'm assuming, and we are notified not to use isFromPublicDomain here (see perma below) -> this is the root cause of the issue.
/// All of the fields/attributes after this comment are currently being migrated from the User model into this Account model
/// Please do not use any of it until the list of action tasks in the table at https://github.com/Expensify/App/issues/59277#issuecomment-2818283478 is fully completed
/** Whether or not the user is subscribed to news updates */
isSubscribedToNewsletter?: boolean;
/** Whether we should use the staging version of the secure API server */
shouldUseStagingServer?: boolean;
/** Whether or not the user is on a public domain email account or not */
FYI @mallenexpensify I canceled this contract for @allgandalf. Reason being, I accidentally paid him $250 as part of this issue due to some confusion in the issue. At any rate, we agreed to just keep the payment for the other issue and then cancel the payment here to even things out. It also avoids having to do refunds through Upwork.
Reacted by Gandalf, Matt Allen, Benjamin Limpich and Joseph Kaufman
changed the title [-][$250] [Due for payment 2025-05-27] private domain onboarding check doesn't show for hybrid app iOS[/-][+][HOLD @ikevin127 NewDot payment] private domain onboarding check doesn't show for hybrid app iOS[/+]on May 29, 2025
Back from OOO and catching up. Thanks for handling this one @mallenexpensify. Seems like all payment has been issued here and we can close this out. Is that right?
Activity
melvin-bot commentedon May 8, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.blimpich commentedon May 8, 2025
@allgandalf @ikevin127 when you have a change to look at this I'd appreciate it 🙂
Also let me know also if you think this should be considered follow up or not. I know we did have this working, so I'm open to paying this out separately if the root cause is something that we couldn't reasonably have caught in previous PRs.
ikevin127 commentedon May 8, 2025
Looked into it and I think this was not caused by any of the the Private Domain Onboarding PRs but by this issue instead:
Usermodel and merge intoAccountmodel #59277which is merging onyx
USERproperties intoACCOUNTincludingisFromPublicDomainwhich is used in the onboarding flow to return the private domain onboarding route, but since the variable is currentlyundefined(both Native and HybridApp) due to the migration I'm assuming, and we are notified not to useisFromPublicDomainhere (see perma below) -> this is the root cause of the issue.App/src/types/onyx/Account.ts
Lines 205 to 216 in bd59655
↪ Find more details on Slack comment.
allgandalf commentedon May 12, 2025
Fix here:
allgandalf commentedon May 12, 2025
Please also assign me to the issue
joekaufmanexpensify commentedon May 12, 2025
@blimpich is @ikevin127 reviewing this too? If so I will handle issue assignments so automation works as expected.
37 remaining items
allgandalf commentedon May 27, 2025
Accepted!! @mallenexpensify .
Please ask me the same questionnnnnnn 😿
ikevin127 commentedon May 27, 2025
@mallenexpensify Let's do NewDot for a change!
Payments email / ND account will be
kevin.bader96@gmail.com, please let me know where to request 👍mallenexpensify commentedon May 27, 2025
@allgandalf , got you down for September for NewDot payments - 2025-09-13
can you please accept the job and reply here once you have? (I think I was able to 'hire' you )
https://www.upwork.com/jobs/~021927446048357832280
allgandalf commentedon May 28, 2025
accepted thanks!
greg-schroeder commentedon May 28, 2025
FYI @mallenexpensify I canceled this contract for @allgandalf. Reason being, I accidentally paid him $250 as part of this issue due to some confusion in the issue. At any rate, we agreed to just keep the payment for the other issue and then cancel the payment here to even things out. It also avoids having to do refunds through Upwork.
allgandalf commentedon May 29, 2025
Yeahhh, we hadd a DEALLLL @greg-schroeder 🌚
[-][$250] [Due for payment 2025-05-27] private domain onboarding check doesn't show for hybrid app iOS[/-][+][HOLD @ikevin127 NewDot payment] private domain onboarding check doesn't show for hybrid app iOS[/+]mallenexpensify commentedon May 30, 2025
@ikevin127 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021927446048357832280
ikevin127 commentedon May 30, 2025
@mallenexpensify Offer accepted, thanks!
mallenexpensify commentedon May 30, 2025
Contributor+: @ikevin127 paid $250 via Upwork.
Thanks y'all!
joekaufmanexpensify commentedon Jun 1, 2025
Back from OOO and catching up. Thanks for handling this one @mallenexpensify. Seems like all payment has been issued here and we can close this out. Is that right?
joekaufmanexpensify commentedon Jun 3, 2025
Closing this out for now. Thanks everyone!