Skip to content

[HOLD @ikevin127 NewDot payment] private domain onboarding check doesn't show for hybrid app iOS #61629

Closed

Description

@blimpich

Problem

On latest iOS Hybrid App version the private domain onboarding check doesn't appear. This PR seems to make the private domain onboarding check reappear but it's throwing an error 404 Login not found or unauthorized when calling AddWorkEmail with a work email that is not connected to an existing account.

We need iOS HybridApp users to be able to use this feature. It also seems like revealing this feature might have exposed a iOS HybridApp specific bug.

Relevant slack thread.

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021927446048357832280
  • Upwork Job ID: 1927446048357832280
  • Last Price Increase: 2025-05-27
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on May 8, 2025
  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 8, 2025
  3. added theissue type on May 8, 2025
  4. melvin-bot commented on May 8, 2025

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. blimpich commented on May 8, 2025

    @blimpich
    ContributorAuthor

    @allgandalf @ikevin127 when you have a change to look at this I'd appreciate it 🙂

    Also let me know also if you think this should be considered follow up or not. I know we did have this working, so I'm open to paying this out separately if the root cause is something that we couldn't reasonably have caught in previous PRs.

  6. ikevin127 commented on May 8, 2025

    @ikevin127
    Contributor

    Looked into it and I think this was not caused by any of the the Private Domain Onboarding PRs but by this issue instead:

    which is merging onyx USER properties into ACCOUNT including isFromPublicDomain which is used in the onboarding flow to return the private domain onboarding route, but since the variable is currently undefined (both Native and HybridApp) due to the migration I'm assuming, and we are notified not to use isFromPublicDomain here (see perma below) -> this is the root cause of the issue.

    /// All of the fields/attributes after this comment are currently being migrated from the User model into this Account model
    /// Please do not use any of it until the list of action tasks in the table at https://github.com/Expensify/App/issues/59277#issuecomment-2818283478 is fully completed
    /** Whether or not the user is subscribed to news updates */
    isSubscribedToNewsletter?: boolean;
    /** Whether we should use the staging version of the secure API server */
    shouldUseStagingServer?: boolean;
    /** Whether or not the user is on a public domain email account or not */
    isFromPublicDomain?: boolean;

    ↪ Find more details on Slack comment.

  7. allgandalf commented on May 12, 2025

    @allgandalf
    Contributor
  8. allgandalf commented on May 12, 2025

    @allgandalf
    Contributor

    Please also assign me to the issue

  9. joekaufmanexpensify commented on May 12, 2025

    @joekaufmanexpensify
    Contributor

    @blimpich is @ikevin127 reviewing this too? If so I will handle issue assignments so automation works as expected.

  10. 37 remaining items

  11. allgandalf commented on May 27, 2025

    @allgandalf
    Contributor

    Accepted!! @mallenexpensify .

    @ikevin127 you wanna be paid through Upwork or wait for NewDot?

    Please ask me the same questionnnnnnn 😿

  12. ikevin127 commented on May 27, 2025

    @ikevin127
    Contributor

    @mallenexpensify Let's do NewDot for a change!

    Payments email / ND account will be kevin.bader96@gmail.com, please let me know where to request 👍

  13. mallenexpensify commented on May 27, 2025

    @mallenexpensify
    Contributor

    @allgandalf , got you down for September for NewDot payments - 2025-09-13
    can you please accept the job and reply here once you have? (I think I was able to 'hire' you )
    https://www.upwork.com/jobs/~021927446048357832280

  14. allgandalf commented on May 28, 2025

    @allgandalf
    Contributor

    accepted thanks!

  15. greg-schroeder commented on May 28, 2025

    @greg-schroeder
    Contributor

    FYI @mallenexpensify I canceled this contract for @allgandalf. Reason being, I accidentally paid him $250 as part of this issue due to some confusion in the issue. At any rate, we agreed to just keep the payment for the other issue and then cancel the payment here to even things out. It also avoids having to do refunds through Upwork.

  16. allgandalf commented on May 29, 2025

    @allgandalf
    Contributor

    we agreed to just keep the payment for the other issue and then cancel the payment here to even things out.

    Yeahhh, we hadd a DEALLLL @greg-schroeder 🌚

  17. changed the title [-][$250] [Due for payment 2025-05-27] private domain onboarding check doesn't show for hybrid app iOS[/-] [+][HOLD @ikevin127 NewDot payment] private domain onboarding check doesn't show for hybrid app iOS[/+] on May 29, 2025
  18. mallenexpensify commented on May 30, 2025

    @mallenexpensify
    Contributor

    @ikevin127 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021927446048357832280

  19. ikevin127 commented on May 30, 2025

    @ikevin127
    Contributor

    @mallenexpensify Offer accepted, thanks!

  20. mallenexpensify commented on May 30, 2025

    @mallenexpensify
    Contributor

    Contributor+: @ikevin127 paid $250 via Upwork.

    Thanks y'all!

  21. joekaufmanexpensify commented on Jun 1, 2025

    @joekaufmanexpensify
    Contributor

    Back from OOO and catching up. Thanks for handling this one @mallenexpensify. Seems like all payment has been issued here and we can close this out. Is that right?

  22. joekaufmanexpensify commented on Jun 3, 2025

    @joekaufmanexpensify
    Contributor

    Closing this out for now. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions