Skip to content

[C+ Checklist Needs Completion] [$250] Categories - Checkmark appears briefly next to the toggle after exiting selection mode #61823

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.43-7
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories.
  3. Long press on any category.
  4. Tap Select.
  5. Tap app back button to exit selection mode.

Expected Result:

Checkmark will not appear next to the toggle after exiting selection mode.

Actual Result:

Checkmark appears briefly next to the toggle after exiting selection mode.

This issue also happens to Members, Tags, Taxes, Per diem etc.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6827149_1746862380989.Screen_Recording_20250510_152731_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021922117839038973532
  • Upwork Job ID: 1922117839038973532
  • Last Price Increase: 2025-05-13
  • Automatic offers:
    • thelullabyy | Contributor | 107282602
    • allgandalf | Contributor | 107286457
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 10, 2025
  2. melvin-bot commented on May 10, 2025

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 10, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 10, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 10, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. techievivek commented on May 12, 2025

    @techievivek
    Contributor

    @daledah Could this also be related to your PR here #60488? Do you mind taking a look.

  7. 39 remaining items

  8. DylanDylann commented on May 28, 2025

    @DylanDylann
    Contributor

    @techievivek @mountiny Could you please help to handle payment to me and the contributor on this issue?

  9. techievivek commented on May 28, 2025

    @techievivek
    Contributor

    Hi, yes, sorry I didn't reliaze we had a different author/C+ reviewing the PR.

  10. techievivek commented on May 28, 2025

    @techievivek
    Contributor

    @greg-schroeder Can you handle the payment for @DylanDylann and @thelullabyy

  11. greg-schroeder commented on May 28, 2025

    @greg-schroeder
    Contributor

    I've been OOO, apologies for the delay. 👀

  12. greg-schroeder commented on May 28, 2025

    @greg-schroeder
    Contributor

    Payment summary:

    Contributor: @thelullabyy - $250 - Upwork
    C+: @DylanDylann - $250 - You can make a manual request via ND for payment

  13. greg-schroeder commented on May 28, 2025

    @greg-schroeder
    Contributor

    @DylanDylann Can you complete the checklist for this issue so we can close it out re: discussion + regression testing?

  14. changed the title [-][Due for payment 2025-05-20] [$250] Categories - Checkmark appears briefly next to the toggle after exiting selection mode[/-] [+][C+ Checklist Needs Completion] [$250] Categories - Checkmark appears briefly next to the toggle after exiting selection mode[/+] on May 28, 2025
  15. greg-schroeder commented on May 28, 2025

    @greg-schroeder
    Contributor

    Ah, shoot, I paid you by mistake for this issue @allgandalf given the confusion and multiple assignments. I've requested a refund via Upwork.

    EDIT:

    We're leaving the payment from this contract in place. We canceled a matching payment for @allgandalf here instead to even things out.

  16. DylanDylann commented on May 28, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open the App
    2. Go to workspace settings > Categories.
    3. Long press on any category.
    4. Tap Select.
    5. Tap app back button to exit selection mode
    6. Verify checkmark not appear next to the toggle after exiting selection mode

    Do we agree 👍 or 👎

  17. greg-schroeder commented on Jun 3, 2025

    @greg-schroeder
    Contributor

    filed test, closing

  18. JmillsExpensify commented on Aug 7, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions