Skip to content

[HOLD for payment 2022-02-01] Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside #6235

Closed

Description

@aldo-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Type an address that yield results
  2. Press "Tab" key
  3. Click somewhere else in the form

Expected Result:

The list of results should close after clicking outside
Focused element of the list after pressing tab should be highlighted

Actual Result:

The list remains open event after focusing other inputs
No element of the list gets highlighted even if the focus changed to one of them after pressing tab

Screen.Recording.2021-11-04.at.8.44.53.PM.mov

Workaround:

The user can still close the list by focusing again on the AddressSearch input and clicking outside. Or the user can just ignore the opened list.

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Nov 5, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Nov 5, 2021
  3. MelvinBot commented on Nov 5, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Dal-Papa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. removed their assignment
    on Nov 5, 2021
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 5, 2021
  6. MelvinBot commented on Nov 5, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  7. MelvinBot commented on Nov 8, 2021

    @MelvinBot
    Contributor

    @Dal-Papa, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. 74 remaining items

  9. NikkiWines commented on Jan 13, 2022

    @NikkiWines
    Contributor

    Oh yep, sorry - I forgot we have to handle that internally. @parasharrajat, just to be clear, you mentioned theGooglePlacesAutocomplete lib, but the lib we're currently using is react-native-google-places-autocomplete. The repo we'd be forking is https://github.com/FaridSafi/react-native-google-places-autocomplete

  10. parasharrajat commented on Jan 13, 2022

    @parasharrajat
    Member

    Sorry for the confusion, I mean the same repo react-native-google-places-autocomplete. It has only one component GooglePlacesAutocomplete and I mentioned its name.

  11. NikkiWines commented on Jan 13, 2022

    @NikkiWines
    Contributor
  12. parasharrajat commented on Jan 13, 2022

    @parasharrajat
    Member

    Spinning up the PR. Thanks.

  13. parasharrajat commented on Jan 13, 2022

    @parasharrajat
    Member
  14. parasharrajat commented on Jan 25, 2022

    @parasharrajat
    Member

    Leaving a note.
    @kevinksullivan Based on this #7330 (comment), please hire me whenever ready.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 25, 2022
  16. botify commented on Jan 25, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.32-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-02-01. 🎊

  17. changed the title [-]Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/-] [+][HOLD for payment 2022-02-01] Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/+] on Jan 25, 2022
  18. kevinksullivan commented on Jan 28, 2022

    @kevinksullivan
    Contributor

    Thanks @parasharrajat . Sent you an invite to the reposted job.

  19. parasharrajat commented on Feb 3, 2022

    @parasharrajat
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions