You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-02-01] Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside #6235
The list of results should close after clicking outside
Focused element of the list after pressing tab should be highlighted
Actual Result:
The list remains open event after focusing other inputs
No element of the list gets highlighted even if the focus changed to one of them after pressing tab
Screen.Recording.2021-11-04.at.8.44.53.PM.mov
Workaround:
The user can still close the list by focusing again on the AddressSearch input and clicking outside. Or the user can just ignore the opened list.
Platform:
Where is this issue occurring?
Web
Desktop App
Version Number: Reproducible in staging?: Reproducible in production?: Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
Sorry for the confusion, I mean the same repo react-native-google-places-autocomplete. It has only one component GooglePlacesAutocomplete and I mentioned its name.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.32-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/-][+][HOLD for payment 2022-02-01] Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/+]on Jan 25, 2022
Activity
MelvinBot commentedon Nov 5, 2021
Triggered auto assignment to @flaviadefaria (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.MelvinBot commentedon Nov 5, 2021
Triggered auto assignment to @Dal-Papa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Nov 5, 2021
Triggered auto assignment to @kevinksullivan (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.MelvinBot commentedon Nov 8, 2021
@Dal-Papa, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
74 remaining items
NikkiWines commentedon Jan 13, 2022
Oh yep, sorry - I forgot we have to handle that internally. @parasharrajat, just to be clear, you mentioned the
GooglePlacesAutocompletelib, but the lib we're currently using isreact-native-google-places-autocomplete. The repo we'd be forking is https://github.com/FaridSafi/react-native-google-places-autocompleteparasharrajat commentedon Jan 13, 2022
Sorry for the confusion, I mean the same repo
react-native-google-places-autocomplete. It has only one componentGooglePlacesAutocompleteand I mentioned its name.NikkiWines commentedon Jan 13, 2022
Should be all good now @parasharrajat - https://github.com/Expensify/react-native-google-places-autocomplete
parasharrajat commentedon Jan 13, 2022
Spinning up the PR. Thanks.
parasharrajat commentedon Jan 13, 2022
PR is up Expensify/react-native-google-places-autocomplete#1.
parasharrajat commentedon Jan 25, 2022
Leaving a note.
@kevinksullivan Based on this #7330 (comment), please hire me whenever ready.
botify commentedon Jan 25, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.32-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-02-01. 🎊
[-]Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/-][+][HOLD for payment 2022-02-01] Pressing "Tab" key while the result list of AddressSearch is open leaves it open even after clicking outside[/+]kevinksullivan commentedon Jan 28, 2022
Thanks @parasharrajat . Sent you an invite to the reposted job.
parasharrajat commentedon Feb 3, 2022
Ping for

@kevinksullivan