Repository navigation
Fix: Search results list closing issues - #1
Conversation
|
Also, please do test it on Native. I wasn't able to do it. I am not sure about how |
|
@NikkiWines This is ready. |
NikkiWines
left a comment
There was a problem hiding this comment.
@parasharrajat this looks pretty good and seems to work well. Can you include a video showing the behavior for the desktop app as well, please?
| setListViewDisplayed(false); | ||
| }; | ||
|
|
||
| document.addEventListener('click', outsideClickHandler); |
There was a problem hiding this comment.
NAB: but I've noticed for Expensify/App we tend to use mousedown instead of click for these kinds of event listeners.
|
Sorry @NikkiWines but I am not able to test it on Desktop. The address list is not loading on the development server. I used the hack to test it on the web but the same is not working on the desktop. But I am 99% sure that it works for Desktop as well. |
There was a problem hiding this comment.
Sorry for the delay @parasharrajat - I was doing some digging into whether we could easily add the blue border for focused list elements.
Tested and this worked well on desktop as well:
Screen.Recording.2022-01-19.at.12.08.09.mov
Tested on iOS and got an error but also getting the same error when testing on master 🤔
VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead.
NikkiWines
left a comment
There was a problem hiding this comment.
Dig some digging and found out that people have experienced this before this PR (see this slack post) so I think we're good to go here.
Also looks like it's just a console error and you can still use the list functionality correctly
|
Hi 👋 It looks like we merged this change in a fork of our repo but didn't open a pull request from our fork to the upstream. Can we make sure we create an issue in the upstream (if there's not one already) and then open a PR? I'm happy to help with that but don't have all the context. I just know we don't want our fork to diverge from the upstream without making every effort possible to get our changes merged. |
|
I went ahead and created a PR against the upstream from our fork: FaridSafi#799 |
|
Thanks, @roryabraham. |
|
Just noting that this ancient PR caused this issue where the address suggestions no longer show after clicking the "fix the errors" link. This happens because this PR always hides the list even though in this case the input is still in a focused state. More details in the proposal that fixes the issue. |
cc: @NikkiWines
I am focusing on these issues for now
Issue Expensify/App#6235
screen-2022-01-13-054406_WVDEpzeq.mp4
How to test
node_modules/react-native-google-places-autocomplete/GooglePlacesAutocomplete.jswith the copied code.