You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-05] [Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user #62695
Version Number: v9.1.51-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught during regression testing, add the test name, ID and link from TestRail:#58020 Email or phone of affected tester (no customers):applausetester+mentiont1@applause.expensifail.com Issue reported by: Applause Internal Team Device used: MacOS Chrome, Desktop App Component: Money Requests
Action Performed:
Start a chat with a new user
Submit two manual expenses
Open the combined expense report
Click on More button > Click on Delete > Click on Delete on confirmation modal
Open one of the expenses that were deleted on step 4 and is moved to personal expenses
Open the expense detail > click on the report header > submit it to someone
Select the same user you have started chat with on step 1
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
which is missing when expenses deleted from a report are transferred in selfDM, this causes us to return early and the endless spinner is present because when we get linkedTrackedExpenseReportAction in createDraftTransactionAndNavigateToParticipantSelector while submitting an expense:
changed the title [-][Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user[/-][+][Due for payment 2025-06-05] [Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user[/+]on May 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@chiragsalian@mallenexpensify@chiragsalian The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon May 23, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 23, 2025
Triggered auto assignment to @chiragsalian (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 23, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 23, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
twilight2294 commentedon May 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unending spinner when submitting an expense to a user.
What is the root cause of that problem?
There is an endless spinner because when we request money we need
linkedTrackedExpenseReportAction:App/src/libs/actions/IOU.ts
Lines 5195 to 5200 in 526a0e4
which is missing when expenses deleted from a report are transferred in selfDM, this causes us to return early and the endless spinner is present because when we get
linkedTrackedExpenseReportActionincreateDraftTransactionAndNavigateToParticipantSelectorwhile submitting an expense:App/src/libs/ReportUtils.ts
Lines 9592 to 9594 in 526a0e4
This will return none as there is no IOU report action for that report created and also we don't have it's
IOUTransactionID.This is the RCA.
What changes do you think we should make in order to solve the problem?
When deleting the report, we should optimistically add the
actionNameandIOUTransactionIDhere:App/src/libs/actions/Report.ts
Lines 4772 to 4781 in 526a0e4
Result video:
Screen.Recording.2025-05-25.at.3.25.51.AM.mov
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
twilight2294 commentedon May 24, 2025
I can raise a quick PR @chiragsalian @mallenexpensify
33 remaining items
[-][Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user[/-][+][Due for payment 2025-06-05] [Due for payment 2025-06-04] IOU - Unending spinner when submitting an expense to a user[/+]melvin-bot commentedon May 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-05. 🎊
melvin-bot commentedon May 29, 2025
@chiragsalian @mallenexpensify @chiragsalian The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jun 5, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Jun 6, 2025
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Jun 6, 2025
@allgandalf I see you drafted the PR and that the PR also fixed the below. Are you do payment? Was this a regression?
Thx.
allgandalf commentedon Jun 9, 2025
Hi @mallenexpensify, This issue and the issue you pointed above were regressions from my PR:
So as the author, I fixed the issues, so no payments due here
melvin-bot commentedon Jun 10, 2025
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!