Skip to content

[Due for payment 2025-06-05] [Due for payment 2025-06-04] [$250] Unreported per diem expense can be submitted to user, incorrect redirection with RHP back button on the confirmation page #62727

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): applausetester+sjdoidwsn11j12@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Workspace has per diem rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two per diem expenses in the workspace chat.
  4. Click on the expense preview to go to expense report.
  5. Click More > Delete.
  6. Delete the report.
  7. Go to self DM.
  8. Click on the per diem expense.
  9. Click on the report header.
  10. Click Submit it to someone.
  11. Select a user (not workspace).
  12. Note that selecting a user is possible when submitting unreported per diem expense.
  13. Click app back button.
  14. Not here page opens.
  15. Click app back button again.
  16. Click Submit it to someone.
  17. Select a workspace.
  18. Click RHP back button on the confirmation page.
  19. Note that RHP back button returns to per diem expense creation flow.

Expected Result:

In Step 12, user should not be able to select another user to submit unreported per diem expense.
In Step 14, RHP back button on confirmation page should return to report details page.

In Step 18, per diem expense receipt should not appear on the confirmation page.
In Step 19, RHP back button on confirmation page should return to report details page.

Actual Result:

In Step 12, user is able to select another user to submit unreported per diem expense.
In Step 14, RHP back button on confirmation page opens not here page when a user is selected.

In Step 18, per diem expense receipt appears on the confirmation page.
In Step 19, RHP back button on confirmation page returns to per diem expense creation flow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021927016765901331120
  • Upwork Job ID: 1927016765901331120
  • Last Price Increase: 2025-06-07
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 24, 2025
  2. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on May 24, 2025

    @melvin-bot

    Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on May 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on May 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mjasikowski commented on May 26, 2025

    @mjasikowski
    Contributor

    Working on a fix

  7. added
    ReviewingHas a PR in review
    and removed on May 26, 2025
  8. 24 remaining items

  9. melvin-bot commented on May 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.52-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-04. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on May 28, 2025

    @melvin-bot

    @jayeshmangwani @sonialiap @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. changed the title [-][Due for payment 2025-06-04] [$250] Unreported per diem expense can be submitted to user, incorrect redirection with RHP back button on the confirmation page[/-] [+][Due for payment 2025-06-05] [Due for payment 2025-06-04] [$250] Unreported per diem expense can be submitted to user, incorrect redirection with RHP back button on the confirmation page[/+] on May 29, 2025
  12. melvin-bot commented on May 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-05. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on May 29, 2025

    @melvin-bot

    @jayeshmangwani @sonialiap @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mallenexpensify commented on Jun 6, 2025

    @mallenexpensify
    Contributor

    @mjasikowski The issue was external, and the fix #62800 is the same as my #62727 (comment). Should I get a partial payment here?

    @mkzie2 can you provide more details and a timeline, with links? We also have this issue which was fixed by the same PR

  15. melvin-bot commented on Jun 7, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  16. mkzie2 commented on Jun 7, 2025

    @mkzie2
    Contributor

    @mallenexpensify Here is the timeline

    PR was CP'd to staging, but there's still the back button functionality to fix - I'm opening the issue up for external contributors so they can help with that!

    1. The issue was external, and I posted the proposal at this time (10:17 PM)
    Image
    1. Here is the time the PR was created (11:53 PM),
    Image

    and the solution that is used to fix this issue is the same as my main solution

    Image Image
  17. mallenexpensify commented on Jun 9, 2025

    @mallenexpensify
    Contributor

    @mkzie2 , for future timelines, please link to the time stamped comment to make it a lil easier to find.

    Rephrasing your summary as to provide reasoning of payment

    1. Issue made External
    2. You submitted proposal
    3. Another PR fixed the issue
    4. Other PR used your solution

    You are due 50%, $125, because "You did the job of proposing a solution that was viable. We added External without knowing there was another issue or PR that was being worked on".

    @mkzie2 can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021927016765901331120

  18. mkzie2 commented on Jun 10, 2025

    @mkzie2
    Contributor

    @mallenexpensify Thanks for helping! I accepted the job.

  19. mallenexpensify commented on Jun 11, 2025

    @mallenexpensify
    Contributor

    Contributor: @mkzie2 paid $125 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions