You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-03] [$1000] Fix console errors post React 19 upgrade #67033
Please re-state the problem that we are trying to solve in this issue.
We're getting the below errors in console after upgrading to react 19.
What is the root cause of that problem?
This is happening because now in react 19 ref can be passed down as any other regular prop and we don't need to wrap the child component which is receiving ref from its parent component with forwardRef.
What changes do you think we should make in order to solve the problem?
We should simply avoid wrapping component in forwardRef. Pass ref as regular prop.
One such example is ActiveHoverable component. I have given an example with ActiveHoverable. similar changes can be applied to other components that are using forwardRef.
An example with ActiveHoverable.
We can replace this part of the code with the suggested code.
return without wrapping the comopnent in forwardRef
exportdefaultActiveHoverable
Note: I only suggested an example with ActiveHoverable there are other components that are using forwardRef so we need to change them in a similar way.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][Due for payment 2026-02-03] Fix console errors post React 19 upgrade[/-][+][Due for payment 2026-02-03] [$1000] Fix console errors post React 19 upgrade[/+]on Jan 27, 2026
Activity
melvin-bot commentedon Jul 24, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.aadil42 commentedon Jul 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
We're getting the below errors in console after upgrading to react 19.
What is the root cause of that problem?
This is happening because now in react 19
refcan be passed down as any other regularpropand we don't need to wrap the child component which is receivingreffrom its parent component withforwardRef.What changes do you think we should make in order to solve the problem?
We should simply avoid wrapping component in
forwardRef. Passrefas regularprop.One such example is
ActiveHoverablecomponent. I have given an example withActiveHoverable. similar changes can be applied to other components that are usingforwardRef.An example with
ActiveHoverable.We can replace this part of the code with the suggested code.
App/src/components/Hoverable/ActiveHoverable.tsx
Lines 16 to 18 in 0717d3f
suggested code:
We should add correct type here in the type definition:
App/src/components/Hoverable/types.ts
Lines 6 to 9 in 0717d3f
add this type:
We should pass correct prop here:
App/src/components/Hoverable/index.tsx
Lines 24 to 28 in 0717d3f
Avoid using
forwardRefhere.App/src/components/Hoverable/ActiveHoverable.tsx
Line 112 in 0717d3f
return without wrapping the comopnent in
forwardRefNote: I only suggested an example with
ActiveHoverablethere are other components that are usingforwardRefso we need to change them in a similar way.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
aadil42 commentedon Jul 24, 2025
Here's the Documentation for Deprecated
element.ref.https://react.dev/blog/2024/04/25/react-19-upgrade-guide#deprecated-element-ref
mountiny commentedon Jul 24, 2025
@aadil42 thanks! This issue is not open for proposals, please check out others with
Help Wantedlabelaadil42 commentedon Jul 25, 2025
@mountiny, No problemo brother. Happy to help. Was my RCA correct? I'm new, so looking for validations from pros 😅😅.
trjExpensify commentedon Jul 30, 2025
@jakubkalinski0 are you working on this?
jakubkalinski0 commentedon Jul 30, 2025
@trjExpensify Yes, I am still working on it. Apologies for not updating earlier, I was very focused on resolving the deploy blockers.
213 remaining items
mountiny commentedon Jan 27, 2026
@aimane-chnaif can you please summarize the prs you had not been paid for yet? this will be ready to pay
aimane-chnaif commentedon Jan 27, 2026
#72072
#73422
#78119
#78270
mountiny commentedon Jan 27, 2026
$1000 to @aimane-chnaif
[-][Due for payment 2026-02-03] Fix console errors post React 19 upgrade[/-][+][Due for payment 2026-02-03] [$1000] Fix console errors post React 19 upgrade[/+]melvin-bot commentedon Jan 27, 2026
melvin-bot commentedon Feb 3, 2026
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Feb 6, 2026
Payment summary as follows:
trjExpensify commentedon Feb 9, 2026
Awaiting offer acceptance.
trjExpensify commentedon Feb 9, 2026
Paid @aimane-chnaif, closing.