You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Jakubkalinski0/fix console errors related to forward ref batch8 - #72072
The whole issue comes from forwardRef being deprecated in the near future of react thus we will no longer be able to access the passed ref by element.ref as forwardRef is needed for passing ref as a separate attribute. Now in order to pass there reference it has to be passed as one of the props so we can access it directly or like that -> element.props.ref.
In order to adjust the codebase to new react recommendations in every file that was using forwardRef the ref had to be moved to the props instead of being a separate attribute and forwardRef had to be completely removed.
Some files had to be changed due to the changes made in other components. In response to the number of files that needed adjusting the changes are made in batches with this one being the eighth one.
This batch is pretty scattered all over the place just as the previous one due to there being no more clear flows that can provide us with meaningful number of files that require the change.
Modified files are grouped below by the components they are related to. In order to make testing easier there are also screenshots of places in app where you can find those components.
!!! I couldn't find a single place where this component can be naturally seen by a user - it's only present in Expensify.tsx but it doesn't seem to me like it's triggered anywhere. I suggest to remove it in a followup !!!
Verify that the animation on signInPage works correctly - testing Lottie
Now log in with a new login in order to create a new account
Follow the Onboarding flow until you get to the People you may know are already here! Verify your email to join them. screen. (I believe there have to be workspaces created within your organization i.e. in my case it's a workspace created by someone with @swmansion.com domain, but I suppose that shouldn't be a problem) - testing ValidateCodeForm
Fill the validation code and verify if those existing workspaces are properly shown to you.
(Now log into an account where you have already existing workspaces etc. it will be easier than creating everything from scratch.)
When you are logged in click the Floating Action Button in the bottom left corner -> then press Start chat and choose # Room
Now input the room name and verify it works correctly - testing RoomNameInput
Choose the workspace that the room should be associated with and verify it works correctly - testing ValuePicker
Now within any chat writhe a message and verify that the input bar at the bottom works correctly - testing Composer
Hover over the message and open the emoji picker menu; verify that the menu works properly and if you can choose any emoji - testing PopoverWithoutOverlay
When you choose an emoji verify that it is properly displayed in a bubble under the message - testing EmojiReactionBubble
Now to to inbox and verify if you can properly navigate through the items in you inbox (i.e. chats, messages etc.) - testing LHNOptionsList
Now go to any workspace with more than 1 member (owner)
Go to Members section and verify that you can navigate through the list of members properly - testing SelectionListWithModal
While still in workspace go to Features and turn on Taxes and then go to Taxes
Now click Add rate in the top right corner then verify if naming this rate works properly - testing TextPicker
Now go to Account -> Profile
Now go to Status, input any message and press the Clear after row -> choose custom. Then change the time and verify that it works properly (you can verify if the status is automatically dropped after the set time, although that isn't influenced by the changes of this PR) - testing TimePicker
Change the avatar and verify that it works properly - testing AvatarCapture
Press the Contact methods row and press on any of your contact methods to verify if the details about this contact show up properly - testing ContactMethodDetailsPage
Now go to Security and press Merge accounts row, input any account and press Next. Verify that the next screen asking for the magic code sent to another account opens up properly - testing AccountValidatePage
Fill out the magic code and merge the accounts, verify that it works properly - testing ValidateCodeActionForm
When filling out the phone number verify that it works correctly and that the phone number is properly saved on the confirmation page - testing SingleFieldStep
When you finish filling out the bank info, verify that the Onfido verification properly shows up and responds correctly to your actions (there is no possibility for me to actually pass the Onfido verification - it's very good at it's job) - testing Onfido
Verify that no errors appear in the JS console
Offline tests
Same as Tests
QA Steps
Same as Tests
Verify that no errors appear in the JS console
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
The assets are optimized and compressed (for SVG files, run npm run compress-svg)
The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
I verified the steps for local testing are in the Tests section
I verified the steps for Staging and/or Production testing are in the QA steps section
I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
A similar component doesn't exist in the codebase
All props are defined accurately and each prop has a /** comment above it */
The file is named correctly
The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
The only data being stored in the state is data necessary for rendering and nothing else
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
All JSX used for rendering exists in the render method
The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
I will Respond to the comments in the evening today, as I have some personal matters to attend to.
Although I see that those comments regard only unused refs which we will take care of in the followup alongside the unused refs from the batch 7, so maybe we can move forward with this PR anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The whole issue comes from
forwardRefbeing deprecated in the near future of react thus we will no longer be able to access the passedrefbyelement.refasforwardRefis needed for passingrefas a separate attribute. Now in order to pass there reference it has to be passed as one of thepropsso we can access it directly or like that ->element.props.ref.In order to adjust the codebase to new react recommendations in every file that was using
forwardRefthe ref had to be moved to thepropsinstead of being a separate attribute andforwardRefhad to be completely removed.Some files had to be changed due to the changes made in other components. In response to the number of files that needed adjusting the changes are made in batches with this one being
the eighth one.This batch is pretty
scattered all over the placejust as the previous one due to there being no more clear flows that can provide us with meaningful number of files that require the change.Modified files are grouped below by the components they are related to. In order to make testing easier there are also screenshots of places in app where you can find those components.
Composer
GrowlNotification
!!! I couldn't find a single place where this component can be naturally seen by a user - it's only present in Expensify.tsx but it doesn't seem to me like it's triggered anywhere. I suggest to remove it in a followup !!!
LHNOptionsList
Lottie
Onfido
PopoverWithoutOverlay
Reactions/EmojiReactionBubble
RoomNameInput
SelectionListWithModal
SubStepForms/SingleFieldStep
TextPicker
TimePicker
ValidateCodeActionForm
ValidateCodeForm
ValuePicker
withNavigationFallback
It's display name differs hence, thats why you see screenshot of WithNavigationFocusWithFallback

AvatarCapture
ContactMethodDetailsPage
AccountValidatePage
NO QA FOR THE CHANGES MADE IN THE FILES BELOW
tests/ui
__mocks__
Performance
Fixed Issues
$ #67033
PROPOSAL: N/A
Tests
LottiePeople you may know are already here! Verify your email to join them.screen. (I believe there have to be workspaces created within your organization i.e. in my case it's a workspace created by someone with@swmansion.comdomain, but I suppose that shouldn't be a problem) - testingValidateCodeFormFloating Action Buttonin the bottom left corner -> then pressStart chatand choose# RoomRoomNameInputValuePickerComposeremoji picker menu; verify that the menu works properly and if you can choose any emoji - testingPopoverWithoutOverlayEmojiReactionBubbleLHNOptionsListMemberssection and verify that you can navigate through the list of members properly - testingSelectionListWithModalFeaturesand turn onTaxesand then go toTaxesAdd ratein the top right corner then verify if naming this rate works properly - testingTextPickerAccount->ProfileStatus, input any message and press theClear afterrow -> choose custom. Then change the time and verify that it works properly (you can verify if the status is automatically dropped after the set time, although that isn't influenced by the changes of this PR) - testingTimePickerAvatarCaptureContact methodsrow and press on any of your contact methods to verify if the details about this contact show up properly - testingContactMethodDetailsPageSecurityand pressMerge accountsrow, input any account and pressNext. Verify that the next screen asking for the magic code sent to another account opens up properly - testingAccountValidatePageValidateCodeActionFormWalletEnable walletphone numberverify that it works correctly and that the phone number is properly saved on the confirmation page - testingSingleFieldStepOnfidoverification properly shows up and responds correctly to your actions (there is no possibility for me to actually pass the Onfido verification - it's very good at it's job) - testingOnfidoOffline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Steps from 1 to 5:
1to5.mp4
Steps from 6 to 9:
6to9.mp4
Steps from 10 to 12:
10to12.mp4
Steps from 13 to 17:
13to17.mp4
Steps from 18 to 23:
18to23.mp4
Steps from 24 to 28:
24to28.mp4
MacOS: Desktop