You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-08-29] [$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview #67360
Version Number: v9.1.87-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: exploratory Email or phone of affected tester (no customers):gibethlehem@gmail.com Issue reported by: Applause Internal Team Device used: macOS/chrome App Component: Other
Action Performed:
Create a new gmail account
Choose any onboarding intent other than “Manage my team's expenses”
Continue the onboarding flow until you reach "Take us for a test drive" modal
Enter any email address not associated with an existing user
Click on "Start test drive"
On the "Confirm details" screen click on the receipt
Refresh page
Expected Result:
Page stays on the "Confirm details" screen or the Test Drive Receipt preview
Actual Result:
"Create expense" page is shown and "Hmm... it not here" is shown on the background
Please re-state the problem that we are trying to solve in this issue.
Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview
What is the root cause of that problem?
Used invalid reportID from test drive blindly (the report ID is 1 by default in onboarding step which means a creating report - so that the data is not existed --> Then causing the "Not here..." issue)
Then we need to check if it is really a valid report or not, if not we need to skip it to avoid "Not here" issue
It is guarantee the correctness and prevent unexpected issues even if we update the default values for creating report later on.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
Not found report screen is shown after refreshing while receipt modal is shown.
What is the root cause of that problem?
This can be reproduced with another steps:
Open FAB > Create Expense
Enter any amount
Change the participant to a new user you never chatted before
Add a receipt
Open the receipt
Refresh
This happens because when we refresh while the receipt modal is open, the receipt modal page route matches the REPORT_ID_FROM_PATH regex, and the report ID from the route will be used as the report ID of the report screen.
If we choose a participant whom we have never chatted with before, then the report screen will be rendered with the non-existent reportID, and OpenReport will give no report found.
What changes do you think we should make in order to solve the problem?
We have a few options.
First, we can ignore the reportID if the route contains a transaction with a transaction ID of 1.
const reportIdFromPath = currentURL && !currentURL.includes('transaction\/1\/') && new URL(currentURL).pathname.match(CONST.REGEX.REPORT_ID_FROM_PATH)?.at(1);
If the transactionID is 1, then it means we are creating a new expense. This is the simplest one to check if we are creating a new expense or not.
Second, we can ignore the reportID completely for the transaction receipt page route by comparing the pathname with the transaction receipt page regex (new regex).
Third, we can create a separate route for the transaction receipt page for the new expense flow that doesn't use /r/[reportID] pattern. So, instead of
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
If we choose first or second, then we can render ReportsSplitNavigator and mock getCurrentUrl to return transaction receipt page and verify the ReportScreen is rendered with reportID not from the receipt page route.
changed the title [-]Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/-][+][$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/+]on Aug 5, 2025
changed the title [-][$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/-][+][Due for payment 2025-08-29] [$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/+]on Aug 22, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.97-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@zanyrenney The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - no obvious source for this, it's probably been around for a while
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Web/Desktop/mWeb
Open FAB > Create Expense
Enter any amount
Change the participant to a new user you never chatted before
Add a receipt
Open the receipt
Refresh
Verify not found report screen is not shown
For Android & iOS, just make sure the receipt can be opened and closed.
@jjcoffee requires payment through NewDot Manual Requests - $250 to be paid on ND. Please request! @bernhardoj requires payment through NewDot Manual Requests - $250 to be paid on ND. Please request!
Activity
melvin-bot commentedon Jul 29, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lorretheboy commentedon Jul 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview
What is the root cause of that problem?
Used invalid reportID from test drive blindly (the report ID is 1 by default in onboarding step which means a creating report - so that the data is not existed --> Then causing the "Not here..." issue)
The ID is getting from here
App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx
Lines 29 to 30 in b17531e
Then it matches the regex check (a weak check), and go to this follow
App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx
Line 31 in b17531e
Since it is an invalid report --> Showing "Not here...." issue
What changes do you think we should make in order to solve the problem?
The easiest way to check if it is a valid reportID is:
First, we can get all reports that available
Then we need to check if it is really a valid report or not, if not we need to skip it to avoid "Not here" issue
It is guarantee the correctness and prevent unexpected issues even if we update the default values for creating report later on.
if (reportIdFromPath && allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportIdFromPath}`]?.reportID) { return reportIdFromPath; }App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx
Lines 31 to 33 in b17531e
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
To make sure that the check valid report ID are always up to date, we can wrap to
useEffectReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
bernhardoj commentedon Jul 30, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Not found report screen is shown after refreshing while receipt modal is shown.
What is the root cause of that problem?
This can be reproduced with another steps:
This happens because when we refresh while the receipt modal is open, the receipt modal page route matches the
REPORT_ID_FROM_PATHregex, and the report ID from the route will be used as the report ID of the report screen.App/src/libs/Navigation/AppNavigator/Navigators/ReportsSplitNavigator.tsx
Lines 28 to 33 in b73ebe2
If we choose a participant whom we have never chatted with before, then the report screen will be rendered with the non-existent
reportID, and OpenReport will give no report found.What changes do you think we should make in order to solve the problem?
We have a few options.
First, we can ignore the reportID if the route contains a transaction with a transaction ID of 1.
If the
transactionIDis 1, then it means we are creating a new expense. This is the simplest one to check if we are creating a new expense or not.Second, we can ignore the reportID completely for the transaction receipt page route by comparing the pathname with the transaction receipt page regex (new regex).
Third, we can create a separate route for the transaction receipt page for the new expense flow that doesn't use
/r/[reportID]pattern. So, instead ofr/:reportID/transaction/:transactionID/receipt/:action?/:iouType?we can do
:action/:iouType/receipt/:transactionID/:reportIDThis will be more inline with the other IOU flow route. For example,
App/src/ROUTES.ts
Lines 629 to 630 in b73ebe2
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
If we choose first or second, then we can render ReportsSplitNavigator and mock
getCurrentUrlto return transaction receipt page and verify the ReportScreen is rendered with reportID not from the receipt page route.melvin-bot commentedon Aug 1, 2025
@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 5, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021952717258906572021
[-]Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/-][+][$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/+]melvin-bot commentedon Aug 5, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)26 remaining items
[-][$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/-][+][Due for payment 2025-08-29] [$250] Onboarding - "It is not here... " is shown when refreshing on Test Drive Receipt preview[/+]melvin-bot commentedon Aug 22, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 22, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.97-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-08-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 22, 2025
@jjcoffee @zanyrenney The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
zanyrenney commentedon Aug 29, 2025
@jjcoffee please can you complete the checklist so we can pay this out?
jjcoffee commentedon Aug 29, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - no obvious source for this, it's probably been around for a while
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Web/Desktop/mWeb
For Android & iOS, just make sure the receipt can be opened and closed.
Do we agree 👍 or 👎
zanyrenney commentedon Aug 29, 2025
Payment summary
@jjcoffee requires payment through NewDot Manual Requests - $250 to be paid on ND. Please request!
@bernhardoj requires payment through NewDot Manual Requests - $250 to be paid on ND. Please request!
bernhardoj commentedon Aug 29, 2025
Requested in ND.
JmillsExpensify commentedon Aug 31, 2025
$250 approved for @bernhardoj
quinthar commentedon Sep 1, 2025
$250 approved for @jjcoffee