Repository navigation
Fix after refresh money request receipt, not found report screen is shown - #68467
yuwenmemon merged 4 commits into
Conversation
|
@bernhardoj Can you check the failing tests? I'm having trouble with my Mac instance at the moment, I'll try to get it sorted today, but otherwise will test this on Monday! 🙇 |
|
Fixed |
|
Not sure where the eslint error comes from. It's unrelated. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-08-18_10.10.38.mp4Android: mWeb Chromeandroid-chrome-2025-08-18_10.14.44.mp4iOS: HybridAppiOS: mWeb Safariios-safari-2025-08-18_09.31.48.mp4MacOS: Chrome / Safaridesktop-chrome-2025-08-18_09.10.02.mp4MacOS: Desktopdesktop-app-2025-08-18_09.15.41.mp4 |
jjcoffee
left a comment
There was a problem hiding this comment.
LGTM!
(I couldn't test on iOS due to a known issue with the file/gallery selector on iOS >17.5, but this bug was only affecting web anyway.)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.97-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.97-5 🚀
|
Explanation of Change
Fixed Issues
$ #67360
PROPOSAL: #67360 (comment)
Tests
Same as QA Steps
Offline tests
QA Steps
Web/Desktop/mWeb
For Android & iOS, just make sure the receipt can be opened and closed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
deskop.mp4