Skip to content

[Due for payment 2025-09-12] Chat - Missing placeholder text in the composer and search field #69048

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #67743
Email or phone of affected tester (no customers): sdhshssdjiosdndjs@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open any report.
  3. Open search router.

Expected Result:

  • Composer will show "Write something" placeholder text.
  • Search field will show "Search for someting" placeholder text.

Actual Result:

Composer and search field are missing placeholder text.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 22, 2025
  2. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Aug 22, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Aug 22, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. blimpich commented on Aug 22, 2025

    @blimpich
    Contributor
  7. ikevin127 commented on Aug 22, 2025

    @ikevin127
    Contributor

    RCA breakdown from the Slack 🧵:

    I remember looking at the react-native-live-markdown PRs in between versions 0.1.299 and 0.1.301 and PR: Implement code and pre blocks support on web authored by @BartoszGrajdek was one of the in-between versions PR, my error is that I didn't think to ask about / test those PRs behaviour in E/App to check whether there would be regressions coming from them - I keept things within scope, only testing our PR: Fix/68518 - Strike through is not applied for quote markdown text behaviour.

    I wouldn't count this as a regression of our PR, but of Implement code and pre blocks support on web's PR, as for who should handle that IMO the PRs author and we could either:

    • revert E/App react-native-live-markdown version back to 0.1.299 to unblock deploy // optionally applying patch of PR: Fix/68518 - Strike through is not applied for quote markdown text to maintain the fix untill react-native-live-markdown is fixed
    • have offending PR author open and merge a follow-up react-native-live-markdown PR fixing the issue and then bump the E/App react-native-live-markdown version to the new one including the fix

    As for the RCA of this issue, refer to this comment.

  8. blimpich commented on Aug 22, 2025

    @blimpich
    Contributor

    Thank you for the breakdown Kevin!

    I'm about to go on vacation and am not working on this issue, but I just wanted to ask, to whoever works on this, can we please create unit tests as part of the solution to this issue? This is something that I think really should've been covered by unit tests. Rendering the correct placeholder text should be something that we can assert via Jest pretty easily, and if it's not easy we should use this as an opportunity to think about how we could make it easier.

  9. 8 remaining items

  10. added and removed on Aug 23, 2025
  11. ikevin127 commented on Aug 23, 2025

    @ikevin127
    Contributor

    @mountiny Makes sense. I dropped a comment on our issue which bumped the RNLM version to let the contributor know that this shouldn't count a regression of their work.

    Noted in the comment that due to this deploy blocker / revert, payments for our work will most likely be delayed until the version is bumped again (including the placeholder fix). Also who should open this PR, the offending RNLM PR author or us who opened it initially ?

    ❓ What do you think we should do in the future in case of similar situations with RNLM where there are other PRs in-between versions, but those PRs did not actually originate from an E/App issue, but rather new features / fixes directly in the RNLM library like PR Implement code and pre blocks support on web did, so we can avoid such inconveniences in the future ?

    • should this always fall on the contributor / C+ reviewer who is performing the E/App version bump to test all PRs in-between the versions even though they didn't author them and they don't originate from E/App issues (no testing steps) ?
    • besides the requirement to always add unit tests for such changes, should direct RNLM PRs (features / fixes) authors always manually test their changes on E/App before merging the RNLM PR ?
  12. mountiny commented on Aug 23, 2025

    @mountiny
    Contributor

    besides the requirement to always add unit tests for such changes, should direct RNLM PRs (features / fixes) authors always manually test their changes on E/App before merging the RNLM PR ?

    Yes they should test it in the App I think as that is the core usage of the library

    should this always fall on the contributor / C+ reviewer who is performing the E/App version bump to test all PRs in-between the versions even though they didn't author them and they don't originate from E/App issues (no testing steps) ?

    I think that, ideally, same as Onyx, the library is always bumped in App after each PR within the library; however, if not done, then it makes sense for the contributor who is bumping the library that includes other changes, not just theirs, to also test whatever is included in the changelog. I know it is not their change; however, you cannot just ignore it as it will add us more work later. We can discuss increasing payment for it in such cases, but it is not showing a careful approach to the PR if the full changelog was not considered in the bump PR.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Sep 5, 2025
  14. changed the title [-]Chat - Missing placeholder text in the composer and search field[/-] [+][Due for payment 2025-09-12] Chat - Missing placeholder text in the composer and search field[/+] on Sep 5, 2025
  15. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.1-20 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-09-12. 🎊

  17. melvin-bot commented on Sep 5, 2025

    @melvin-bot

    @mountiny @sakluger The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions