Skip to content

[Due for payment 2026-03-30] [BACK BUTTON][$250] report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section #70180

Closed

Description

@mitarachim

Version Number: V9.2.3-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #70012
Email or phone of affected tester (no customers): Slottwo1 bxvb@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: User Settings

Action Performed:

  1. Launch app
  2. Go to reports
  3. Tap advance filter - paid - before
  4. Tap app back button
  5. Note user directed to paid page
  6. Tap before
  7. Tap device back button
  8. Note user directed to filters page

Expected Result:

User should be redirect to "Paid" section page

Actual Result:

User redirect to Filter page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6939279_1757407907361.Screenrecorder-2025-09-09-14-14-18-275.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022041164885000186897
  • Upwork Job ID: 2041164885000186897
  • Last Price Increase: 2026-04-06

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 9, 2025
  2. melvin-bot commented on Sep 9, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Sep 9, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User redirect to Filter page

    What is the root cause of that problem?

    We're using modal for the calendar picker

    <CalendarPicker
    value={ephemeralDateValue}
    onSelected={setEphemeralDateValue}
    minDate={CONST.CALENDAR_PICKER.MIN_DATE}
    maxDate={CONST.CALENDAR_PICKER.MAX_DATE}
    />

    so when users press device back button, we'll go to the previous page, it's filter page

    What changes do you think we should make in order to solve the problem?

    We can consider to create the new page for CalendarPicker and navigate to the new page in

    onSelectDateModifier(dateModifier);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. abzokhattab commented on Sep 9, 2025

    @abzokhattab
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section

    What is the root cause of that problem?

    • The SearchDatePresetFilterBasePage component only handles app back button navigation through the HeaderWithBackButton component
    • Android device back button presses are not intercepted by the component's custom goBack logic
    • The component lacks the useHandleBackButton hook that other similar components use to handle device back button consistently
    • Device back button follows default React Navigation behavior instead of the component's intended navigation flow

    What changes do you think we should make in order to solve the problem?

    • Add useHandleBackButton hook import to SearchDatePresetFilterBasePage component
    • Follow the existing pattern used in other components like SearchPageNarrow
    • This fix will automatically resolve the issue for all date filter pages (Paid, Date, Submitted, Approved, etc.) since they all use the same base component
        useHandleBackButton(() => {
            goBack();
            return true;
        });

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

  5. dmkt9 commented on Sep 9, 2025

    @dmkt9
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    User redirect to Filter page

    What is the root cause of that problem?

    Currently, CalendarPicker is rendered based on the selectedDateModifier state:

    return !selectedDateModifier ? (
    <>
    {presets?.map((preset) => (
    <SingleSelectListItem
    key={preset}
    showTooltip
    item={{
    text: translate(`search.filters.date.presets.${preset}`),
    isSelected: dateValues[CONST.SEARCH.DATE_MODIFIERS.ON] === preset,
    }}
    onSelectRow={() => setDateValue(CONST.SEARCH.DATE_MODIFIERS.ON, preset)}
    wrapperStyle={styles.flexReset}
    />
    ))}
    {shouldShowHorizontalRule && (
    <SpacerView
    shouldShow
    style={[StyleUtils.getBorderColorStyle(theme.border), styles.mh3]}
    />
    )}
    <MenuItem
    shouldShowRightIcon
    viewMode={CONST.OPTION_MODE.COMPACT}
    title={translate('common.on')}
    description={dateDisplayValues[CONST.SEARCH.DATE_MODIFIERS.ON]}
    onPress={() => selectDateModifier(CONST.SEARCH.DATE_MODIFIERS.ON)}
    />
    <MenuItem
    shouldShowRightIcon
    viewMode={CONST.OPTION_MODE.COMPACT}
    title={translate('common.after')}
    description={dateDisplayValues[CONST.SEARCH.DATE_MODIFIERS.AFTER]}
    onPress={() => selectDateModifier(CONST.SEARCH.DATE_MODIFIERS.AFTER)}
    />
    <MenuItem
    shouldShowRightIcon
    viewMode={CONST.OPTION_MODE.COMPACT}
    title={translate('common.before')}
    description={dateDisplayValues[CONST.SEARCH.DATE_MODIFIERS.BEFORE]}
    onPress={() => selectDateModifier(CONST.SEARCH.DATE_MODIFIERS.BEFORE)}
    />
    </>
    ) : (
    <CalendarPicker
    value={ephemeralDateValue}
    onSelected={setEphemeralDateValue}
    minDate={CONST.CALENDAR_PICKER.MIN_DATE}
    maxDate={CONST.CALENDAR_PICKER.MAX_DATE}
    />
    );

    What changes do you think we should make in order to solve the problem?

    We should wrap CalendarPicker in a Modal component that includes the shouldHandleNavigationBack prop. For example:

    <Modal
        type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
        onClose={() => selectDateModifier(null)}
        isVisible={!!selectedDateModifier}
        shouldHandleNavigationBack
        shouldUseReanimatedModal
        swipeDirection={CONST.SWIPE_DIRECTION.RIGHT}
    >

    <CalendarPicker
    value={ephemeralDateValue}
    onSelected={setEphemeralDateValue}
    minDate={CONST.CALENDAR_PICKER.MIN_DATE}
    maxDate={CONST.CALENDAR_PICKER.MAX_DATE}
    />

    Note: Other components such as HeaderWithBackButton, Button, and FormAlertWithSubmitButton should also be wrapped together with CalendarPicker to ensure the layout remains consistent. And the position of can also be considered accordingly.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  6. RachCHopkins commented on Sep 11, 2025

    @RachCHopkins
    Contributor

    Can repro.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 11, 2025
  8. changed the title [-]report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/-] [+][$250] report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/+] on Sep 11, 2025
  9. melvin-bot commented on Sep 11, 2025

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 11, 2025
  11. melvin-bot commented on Sep 11, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  12. 103 remaining items

  13. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 6, 2026
  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 6, 2026
  15. melvin-bot commented on Apr 6, 2026

    @melvin-bot

    Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

  16. melvin-bot commented on Apr 6, 2026

    @melvin-bot
  17. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 6, 2026
  18. mallenexpensify commented on Apr 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @marufsharifi due $250 via Upwork
    Contributor+: @jjcoffee due $250 via NewDot

    @marufsharifi can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022041164885000186897

    ^ Test case created

  19. mallenexpensify commented on Apr 6, 2026

    @mallenexpensify
    Contributor

    @marufsharifi @jjcoffee 👀 plz. The issue that was a regression was closed as the bug wasn't reproducible. That means that you shouldn't have the regression penalty here... correct?
    #86540 (comment)

  20. marufsharifi commented on Apr 7, 2026

    @marufsharifi

    @mallenexpensify, I've accepted the offer. thanks.

  21. jjcoffee commented on Apr 7, 2026

    @jjcoffee
    Contributor

    The issue that was a regression was closed as the bug wasn't reproducible. That means that you shouldn't have the regression penalty here... correct? #86540 (comment)

    @mallenexpensify Yeah I wasn't sure how it should be handled as it's a bit of an edge case. There was initially a regression as far as I can tell but this later was fixed due to a behaviour change so now it is no longer reproducible. @marufsharifi or @cretadn22 may have more context as this happened whilst I was away/going away 😄

  22. mallenexpensify commented on Apr 7, 2026

    @mallenexpensify
    Contributor

    I'm going to keep the price as $250, 100% cuz, even though this did cause a regression, the bug disappeared. I tried to find what might have fixed it but no other issues linked back to the PR.

    If we can/could show what actually fixed it and that the fix was because of the regression, then I'd reduce 50%.

  23. JmillsExpensify commented on Apr 7, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions