You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] [BACK BUTTON][$250] report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section #70180
Version Number: V9.2.3-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#70012 Email or phone of affected tester (no customers): Slottwo1 bxvb@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: User Settings
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section
What is the root cause of that problem?
The SearchDatePresetFilterBasePage component only handles app back button navigation through the HeaderWithBackButton component
Android device back button presses are not intercepted by the component's custom goBack logic
The component lacks the useHandleBackButton hook that other similar components use to handle device back button consistently
Device back button follows default React Navigation behavior instead of the component's intended navigation flow
What changes do you think we should make in order to solve the problem?
Add useHandleBackButton hook import to SearchDatePresetFilterBasePage component
Follow the existing pattern used in other components like SearchPageNarrow
This fix will automatically resolve the issue for all date filter pages (Paid, Date, Submitted, Approved, etc.) since they all use the same base component
useHandleBackButton(()=>{goBack();returntrue;});
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Note: Other components such as HeaderWithBackButton, Button, and FormAlertWithSubmitButton should also be wrapped together with CalendarPicker to ensure the layout remains consistent. And the position of can also be considered accordingly.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/-][+][$250] report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/+]on Sep 11, 2025
@marufsharifi@jjcoffee 👀 plz. The issue that was a regression was closed as the bug wasn't reproducible. That means that you shouldn't have the regression penalty here... correct? #86540 (comment)
The issue that was a regression was closed as the bug wasn't reproducible. That means that you shouldn't have the regression penalty here... correct? #86540 (comment)
@mallenexpensify Yeah I wasn't sure how it should be handled as it's a bit of an edge case. There was initially a regression as far as I can tell but this later was fixed due to a behaviour change so now it is no longer reproducible. @marufsharifi or @cretadn22 may have more context as this happened whilst I was away/going away 😄
I'm going to keep the price as $250, 100% cuz, even though this did cause a regression, the bug disappeared. I tried to find what might have fixed it but no other issues linked back to the PR.
If we can/could show what actually fixed it and that the fix was because of the regression, then I'd reduce 50%.
Activity
melvin-bot commentedon Sep 9, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User redirect to Filter page
What is the root cause of that problem?
We're using modal for the calendar picker
App/src/components/Search/SearchDatePresetFilterBase.tsx
Lines 191 to 196 in a24b0c0
so when users press device back button, we'll go to the previous page, it's filter page
What changes do you think we should make in order to solve the problem?
We can consider to create the new page for
CalendarPickerand navigate to the new page inApp/src/components/Search/SearchDatePresetFilterBase.tsx
Line 113 in a24b0c0
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
abzokhattab commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section
What is the root cause of that problem?
SearchDatePresetFilterBasePagecomponent only handles app back button navigation through theHeaderWithBackButtoncomponentgoBacklogicuseHandleBackButtonhook that other similar components use to handle device back button consistentlyWhat changes do you think we should make in order to solve the problem?
useHandleBackButtonhook import toSearchDatePresetFilterBasePagecomponentSearchPageNarrowWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
dmkt9 commentedon Sep 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
User redirect to Filter page
What is the root cause of that problem?
Currently,
CalendarPickeris rendered based on theselectedDateModifierstate:App/src/components/Search/SearchDatePresetFilterBase.tsx
Lines 148 to 197 in 32cf88b
What changes do you think we should make in order to solve the problem?
We should wrap
CalendarPickerin aModalcomponent that includes theshouldHandleNavigationBackprop. For example:App/src/components/Search/SearchDatePresetFilterBase.tsx
Lines 191 to 196 in 32cf88b
Note: Other components such as
HeaderWithBackButton,Button, andFormAlertWithSubmitButtonshould also be wrapped together withCalendarPickerto ensure the layout remains consistent. And the position of can also be considered accordingly.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
RachCHopkins commentedon Sep 11, 2025
Can repro.
[-]report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/-][+][$250] report-Inconsistent behavior between device and in-app back navigation in 'Paid' filter section[/+]melvin-bot commentedon Sep 11, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021966032516200532736
melvin-bot commentedon Sep 11, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)103 remaining items
melvin-bot commentedon Apr 6, 2026
Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Apr 6, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022041164885000186897
mallenexpensify commentedon Apr 6, 2026
Payment Summary
Contributor: @marufsharifi due $250 via Upwork
Contributor+: @jjcoffee due $250 via NewDot
@marufsharifi can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022041164885000186897
^ Test case created
mallenexpensify commentedon Apr 6, 2026
@marufsharifi @jjcoffee 👀 plz. The issue that was a regression was closed as the bug wasn't reproducible. That means that you shouldn't have the regression penalty here... correct?
#86540 (comment)
marufsharifi commentedon Apr 7, 2026
@mallenexpensify, I've accepted the offer. thanks.
jjcoffee commentedon Apr 7, 2026
@mallenexpensify Yeah I wasn't sure how it should be handled as it's a bit of an edge case. There was initially a regression as far as I can tell but this later was fixed due to a behaviour change so now it is no longer reproducible. @marufsharifi or @cretadn22 may have more context as this happened whilst I was away/going away 😄
mallenexpensify commentedon Apr 7, 2026
I'm going to keep the price as $250, 100% cuz, even though this did cause a regression, the bug disappeared. I tried to find what might have fixed it but no other issues linked back to the PR.
If we can/could show what actually fixed it and that the fix was because of the regression, then I'd reduce 50%.
JmillsExpensify commentedon Apr 7, 2026
$250 approved for @jjcoffee