Skip to content

[CBN] Set new best practices #79039

Closed
2 of 2 issues completed
Closed

Description

@arosiclair

Activity

  1. arosiclair commented on Jan 8, 2026

    @arosiclair
    ContributorAuthor

    Hey @MrMuzyk I think we're ready to move forward with implementation. Can you link that draft PR you had for useSubPage? I can't seem to find it.

  2. MrMuzyk commented on Jan 9, 2026

    @MrMuzyk
    Contributor

    Sure thig, it's here #78266

  3. MrMuzyk commented on Jan 9, 2026

    @MrMuzyk
    Contributor

    Ive spent some time on the PR today and made sure that all automated checks are passing.

    Im splitting my time between multiple issues so will continue with it next week.

    At the moment whats left to do is:

    • double check the code and make more corrections if needed
    • write some unit tests for new hook
    • test whether the refactored flow works properly
    • fill in the checklist
  4. MrMuzyk commented on Jan 12, 2026

    @MrMuzyk
    Contributor

    I probably won't be able to look into it today - got some deploy blockers to fix

  5. MrMuzyk commented on Jan 13, 2026

    @MrMuzyk
    Contributor

    Issues were demoted from blockers but I will still finish fixing them all before I get back to this. Probably will happen tomorrow

  6. MrMuzyk commented on Jan 15, 2026

    @MrMuzyk
    Contributor

    Back on it from today onwards

  7. MrMuzyk commented on Jan 19, 2026

    @MrMuzyk
    Contributor

    Still working on PR

  8. 5 remaining items

  9. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. MrMuzyk commented on Jan 27, 2026

    @MrMuzyk
    Contributor

    @arosiclair There is one flow that was missed and is not in the doc thus not have corresponding issue yet.

    It's enabling payments from Wallet

    /settings/wallet/enable-payments

    Settings > Wallet > Enable wallet

  12. MrMuzyk commented on Jan 27, 2026

    @MrMuzyk
    Contributor
    Image

    Actually, do you know why we have two very similar pages that have very similar names?

    Their default exports are under the same name and testID is the same.

    My first impression is that somehow this page is duplicated but there are nuanced differences between them. It's a bit strange 🤔

  13. arosiclair commented on Jan 27, 2026

    @arosiclair
    ContributorAuthor

    @arosiclair There is one flow that was missed and is not in the doc thus not have corresponding issue yet.

    It's enabling payments from Wallet

    /settings/wallet/enable-payments

    Settings > Wallet > Enable wallet

    That should be covered in #79041

  14. arosiclair commented on Jan 31, 2026

    @arosiclair
    ContributorAuthor

    @MrMuzyk I think we forgot to mark useSubStep as deprecated btw. Can we open a quick PR for that?

  15. MrMuzyk commented on Feb 2, 2026

    @MrMuzyk
    Contributor

    Yup, will do

  16. MrMuzyk commented on Feb 2, 2026

    @MrMuzyk
    Contributor

    @arosiclair PR here -> #81141

  17. arosiclair commented on Feb 9, 2026

    @arosiclair
    ContributorAuthor

    All done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions